Author: markt Date: Wed Oct 12 09:55:19 2016 New Revision: 1764425 URL: http://svn.apache.org/viewvc?rev=1764425&view=rev Log: Correct the HPACK header table size configuration
Client and server tables sizes were transposed Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1764425&r1=1764424&r2=1764425&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java (original) +++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Wed Oct 12 09:55:19 2016 @@ -615,7 +615,8 @@ class Http2UpgradeHandler extends Abstra private HpackEncoder getHpackEncoder() { if (hpackEncoder == null) { - hpackEncoder = new HpackEncoder(localSettings.getHeaderTableSize()); + + hpackEncoder = new HpackEncoder(remoteSettings.getHeaderTableSize()); } return hpackEncoder; } @@ -1143,7 +1144,7 @@ class Http2UpgradeHandler extends Abstra @Override public HpackDecoder getHpackDecoder() { if (hpackDecoder == null) { - hpackDecoder = new HpackDecoder(remoteSettings.getHeaderTableSize()); + hpackDecoder = new HpackDecoder(localSettings.getHeaderTableSize()); } return hpackDecoder; } Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1764425&r1=1764424&r2=1764425&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Wed Oct 12 09:55:19 2016 @@ -70,6 +70,15 @@ </fix> </changelog> </subsection> + <subsection name="HTTP/2"> + <changelog> + <fix> + Correct the HPACK header table size configuration that transposed the + client and server table sizes when creating the encoder and decoder. + (markt) + </fix> + </changelog> + </subsection> <subsection name="Jasper"> <changelog> <update> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org