[GitHub] [tomee] jgallimore commented on pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

jgallimore commented on pull request #789: URL: https://github.com/apache/tomee/pull/789#issuecomment-838143817 Apart from @rzo1 's feedback, this looks like a solid example to me, thanks for adding it!  -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomee] rzo1 commented on a change in pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

rzo1 commented on a change in pull request #789: URL: https://github.com/apache/tomee/pull/789#discussion_r629877489 ## File path: examples/jpa-hibernate-arquillian/pom.xml ## @@ -0,0 +1,163 @@ + + + +http://maven.apache.org/POM/4.0.0;

The wrong way to close PRs

When creating the tomee-release-tools git repo I mistakenly did a force push to the wrong repo, the main tomee repo. This closed most of the open PRs. Steps taken so far: - Worked with Apache Infra on slack to restore the repo. This still doesn't allow the PRs to be re-opened,

Re: The wrong way to close PRs

If people used a branch, you can re-create the PR like this [image: image.png] Click on the branch link. Then create the pull request. I'll do this one as an example. https://github.com/apache/tomee/pull/791 What other PR do you have to restore? -- Jean-Louis Monteiro

[GitHub] [tomee] rzo1 closed pull request #790: Test, if the re-creation of the PR does work?

rzo1 closed pull request #790: URL: https://github.com/apache/tomee/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] rzo1 opened a new pull request #790: Test, if the re-creation of the PR does work?

rzo1 opened a new pull request #790: URL: https://github.com/apache/tomee/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] jeanouii opened a new pull request #791: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

jeanouii opened a new pull request #791: URL: https://github.com/apache/tomee/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [tomee] jeanouii opened a new pull request #792: TOMEE-2324 v2

jeanouii opened a new pull request #792: URL: https://github.com/apache/tomee/pull/792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [tomee] jeanouii opened a new pull request #797: Initial support for the quick build with JDK 11

jeanouii opened a new pull request #797: URL: https://github.com/apache/tomee/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [tomee] jeanouii opened a new pull request #796: TOMEE-55 - Review alignment for pages that originally had html tables

jeanouii opened a new pull request #796: URL: https://github.com/apache/tomee/pull/796 Fixed the table in the pages according asciidoc syntax. Added new/old page (apache-tomee.adoc) by your relevance. One page (spring-ejb-and-jpa.adoc) were with broken links to old example project

[GitHub] [tomee] jeanouii opened a new pull request #794: Fix for random JMS2AMQTest failure

jeanouii opened a new pull request #794: URL: https://github.com/apache/tomee/pull/794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [tomee] jeanouii opened a new pull request #795: Added back test step for gihub action

jeanouii opened a new pull request #795: URL: https://github.com/apache/tomee/pull/795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [tomee] jeanouii opened a new pull request #793: TOMEE-2917 - Change All WrappingMessage to become serializable

jeanouii opened a new pull request #793: URL: https://github.com/apache/tomee/pull/793 JIRA: https://issues.apache.org/jira/browse/TOMEE-2917 Fix Summary: Change all WrappingMessage to implements Serializable and add unique serialVersionUID. Notes: There is a business use

Re: The wrong way to close PRs

> On May 11, 2021, at 10:18 AM, Jean-Louis Monteiro > wrote: > > If people used a branch, you can re-create the PR like this Note Apache doesn't allow attachments, so the image didn't come through. > Click on the branch link. Then create the pull request. I'll do this one as > an example. >

[GitHub] [tomee] rzo1 edited a comment on pull request #797: Initial support for the quick build with JDK 11

rzo1 edited a comment on pull request #797: URL: https://github.com/apache/tomee/pull/797#issuecomment-838891701 I am closing this one again. As discussed on the dev list, `jacorb` has an incompatible license. We might get https://github.com/apache/tomee/pull/792 to work some day and get

[GitHub] [tomee] rzo1 commented on pull request #793: TOMEE-2917 - Change All WrappingMessage to become serializable

rzo1 commented on pull request #793: URL: https://github.com/apache/tomee/pull/793#issuecomment-838892542 See the discussion in https://github.com/apache/tomee/pull/792 -> closing this one. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomee] rzo1 closed pull request #793: TOMEE-2917 - Change All WrappingMessage to become serializable

rzo1 closed pull request #793: URL: https://github.com/apache/tomee/pull/793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] rzo1 closed pull request #797: Initial support for the quick build with JDK 11

rzo1 closed pull request #797: URL: https://github.com/apache/tomee/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] rzo1 commented on pull request #797: Initial support for the quick build with JDK 11

rzo1 commented on pull request #797: URL: https://github.com/apache/tomee/pull/797#issuecomment-838891701 I am closing this one. As discussed on the dev list, `jacorb` has an incompatible license. We might get https://github.com/apache/tomee/pull/792 to work some day and get J11 build

Re: The wrong way to close PRs

We re-created some (newer) PRs, which were not older than January 2021, linked the related JIRA as well as the original PR to preserve discussions. Sadly, it was not possible to get GitHub to refresh a closed PR (even though the source branch was updated and a "new" PR works). I guess, we can

[GitHub] [tomee] dblevins closed pull request #65: Refactored mockito integration

dblevins closed pull request #65: URL: https://github.com/apache/tomee/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #664: Initial support for build with JDK 11

dblevins closed pull request #664: URL: https://github.com/apache/tomee/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #716: TOMEE-2917 - Change All WrappingMessage to become serializable

dblevins closed pull request #716: URL: https://github.com/apache/tomee/pull/716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #321: Created tomee-cluster.adoc file (html still needed)

dblevins closed pull request #321: URL: https://github.com/apache/tomee/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #360: Cleanup test code and also minor changes in the tested class.

dblevins closed pull request #360: URL: https://github.com/apache/tomee/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #677: Added back test step for gihub action

dblevins closed pull request #677: URL: https://github.com/apache/tomee/pull/677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #634: Examples - move files from javax.* to jakarta.* package

dblevins closed pull request #634: URL: https://github.com/apache/tomee/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #670: TOMEE-55 - Review alignment for pages that originally had html tables

dblevins closed pull request #670: URL: https://github.com/apache/tomee/pull/670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #180: TOMEE-2267 Check Bean Validation signatures at build time

dblevins closed pull request #180: URL: https://github.com/apache/tomee/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #721: TOMEE-2324 - DRAFT: Remove Corba ORB APIs from Codebase

dblevins closed pull request #721: URL: https://github.com/apache/tomee/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #633: move files from javax.* to jakarta.* package updates

dblevins closed pull request #633: URL: https://github.com/apache/tomee/pull/633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #678: Fix for random JMS2AMQTest failure

dblevins closed pull request #678: URL: https://github.com/apache/tomee/pull/678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #268: [Work in Progress] TOMEE-2176 - Arquillian test cannot be run in parallel

dblevins closed pull request #268: URL: https://github.com/apache/tomee/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #467: TOMEE-2502 + Test

dblevins closed pull request #467: URL: https://github.com/apache/tomee/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #316: Interceptor titles

dblevins closed pull request #316: URL: https://github.com/apache/tomee/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tomee] dblevins closed pull request #633: move files from javax.* to jakarta.* package updates

dblevins closed pull request #633: URL: https://github.com/apache/tomee/pull/633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

Re: The wrong way to close PRs

All fixed now! We can get back to fixing the master after TCK work -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, May 11, 2021 at 7:49 PM Zowalla, Richard < richard.zowa...@hs-heilbronn.de> wrote: > We re-created some (newer) PRs, which were not older

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

cesarhernandezgt commented on a change in pull request #789: URL: https://github.com/apache/tomee/pull/789#discussion_r630574953 ## File path: examples/jpa-hibernate-arquillian/README.adoc ## @@ -0,0 +1,323 @@ += JPA Hibernate Arquillian +:index-group: JPA +:jbake-type: page

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

cesarhernandezgt commented on a change in pull request #789: URL: https://github.com/apache/tomee/pull/789#discussion_r630575104 ## File path: examples/jpa-hibernate-arquillian/README.adoc ## @@ -0,0 +1,323 @@ += JPA Hibernate Arquillian +:index-group: JPA +:jbake-type: page

[GitHub] [tomee] cesarhernandezgt commented on pull request #791: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

cesarhernandezgt commented on pull request #791: URL: https://github.com/apache/tomee/pull/791#issuecomment-839231013 Hi @rzo1 Thanks much for the review. I replied to all your comment in #789. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

cesarhernandezgt commented on a change in pull request #789: URL: https://github.com/apache/tomee/pull/789#discussion_r630576753 ## File path: examples/jpa-hibernate-arquillian/README.adoc ## @@ -0,0 +1,323 @@ += JPA Hibernate Arquillian +:index-group: JPA +:jbake-type: page

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

cesarhernandezgt commented on a change in pull request #789: URL: https://github.com/apache/tomee/pull/789#discussion_r630576852 ## File path: examples/jpa-hibernate-arquillian/pom.xml ## @@ -0,0 +1,163 @@ + + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #789: TOMEE-3741 New Example and documentation JPA Hibernate 5 with arquillian

cesarhernandezgt commented on a change in pull request #789: URL: https://github.com/apache/tomee/pull/789#discussion_r630576939 ## File path: examples/jpa-hibernate-arquillian/src/test/resources/arquillian.xml ## @@ -0,0 +1,46 @@ + + +http://jboss.org/schema/arquillian; +