rzo1 merged PR #1103:
URL: https://github.com/apache/tomee/pull/1103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
rzo1 commented on PR #1103:
URL: https://github.com/apache/tomee/pull/1103#issuecomment-1916337770
> Yeah so lets merge?
Yup. Think we are good to go now (at least with this first impl), full build
is ok and we can take care of the new tck later.
--
This is an automated message
tandraschko commented on PR #1103:
URL: https://github.com/apache/tomee/pull/1103#issuecomment-1911848554
Yeah so lets merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rzo1 commented on PR #1103:
URL: https://github.com/apache/tomee/pull/1103#issuecomment-1911833114
Full build looks good now. Only the usual toggles are failing:
https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/69/#showFailuresLink
--
This is an automated message from the
rzo1 commented on PR #1103:
URL: https://github.com/apache/tomee/pull/1103#issuecomment-1910225941
The only failing test related to this change is
`ManagedExecutorServiceGetPrincipalInTaskTest`. I guess, that wiring up the
security service with async/managed executors isn't complete. FYI
rzo1 commented on code in PR #1103:
URL: https://github.com/apache/tomee/pull/1103#discussion_r1457465967
##
container/openejb-core/src/main/java/org/apache/openejb/threads/impl/ManagedExecutorServiceImpl.java:
##
@@ -170,6 +172,7 @@ public void destroyResource() {
}
tandraschko commented on PR #1103:
URL: https://github.com/apache/tomee/pull/1103#issuecomment-1898495189
@jgallimore there are currently 2 tests failing, could you check it?
https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/65/
CustomInjectionTest defines a
rzo1 opened a new pull request, #1103:
URL: https://github.com/apache/tomee/pull/1103
This is a new PR as I moved the code to the TomEE repo in order to allow
people to fork and directly PR this branch. FYI @jgallimore
--
This is an automated message from the Apache Git Service.
To
