Agree with the comments and fixed.
Thank you for approving me as a contributor.
Rod.
On 2/14/20, 5:34 AM, "Jonathan Gallimore" wrote:
Nationwide Information Security Warning: This is an external email. Do not
click on links or open attachments unless you trust the sender.
--
Rod
Are you able to handle the feedback on this PR, specifically around image
tags? https://github.com/docker-library/official-images/pull/7471
Thanks
Jon
On Thu, Feb 13, 2020 at 8:48 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Thanks Rod!
>
> On Thu, Feb 13, 2020 at 8:06 PM Jenkins, Rodney J (Rod) <
> jenki...@nationwide.com> wrote:
>
>> FYI to all
>>
>> Jon merged the pull request this morning. I created a Pull Request to
>> the official images. It can be found here:
>> https://github.com/docker-library/official-images/pull/7471
>>
>> I should note that the new versions are: 7.0.6, 7.1.2, 8.0.1 (I am not
>> sure why this thread says 8.0.0)
>>
>> I would expect the new versions to be live in a couple of days.
>>
>> Thanks,
>> Rod.
>>
>>
>> On 2/5/20, 3:24 PM, "Jenkins, Rodney J (Rod)"
>> wrote:
>>
>> Nationwide Information Security Warning: This is an external email.
>> Do not click on links or open attachments unless you trust the sender.
>>
>>
--
>>
>> Jon,
>>
>> Is there anything I need to do to get the Docker images released?
>>
>> Thanks,
>> Rod.
>>
>>
>> On 1/23/20, 12:58 PM, "Jenkins, Rodney J (Rod)" <
>> jenki...@nationwide.com> wrote:
>>
>> Nationwide Information Security Warning: This is an external
>> email. Do not click on links or open attachments unless you trust the
>> sender.
>>
>>
--
>>
>> For now, I just made sure they all built successfully. They did
>> and you can see my latest on the pull request.
>>
>> For the future, I am undecided. Maybe that it is just enough
>> that TomEE is well tested before we get to Docker.
>>
>> Thanks,
>> Rod.
>>
>>
>> On 1/22/20, 3:05 PM, "Jonathan Gallimore" <
>> jonathan.gallim...@gmail.com> wrote:
>>
>> Nationwide Information Security Warning: This is an external
>> email. Do not click on links or open attachments unless you trust the
>> sender.
>>
>>
--
>>
>> How far do you want to go with testing? Personally I think a
>> quick
>> automated smoke test would be perfect. The distributions are
>> already tested
>> in quite a lot of depth in the build, so I'm not sure we need
>> to repeat
>> that in Docker. That's a development view on the problem, I'm
>> quite
>> interested in what consumers of the Dockers would expect.
>>
>> Jon
>>
>> On Wed, Jan 22, 2020 at 6:22 PM Jenkins, Rodney J (Rod) <
>> jenki...@nationwide.com> wrote:
>>
>> > Jon,
>> >
>> > I was able to get it to build, thank you!!!
>> >
>> > This leads me to a larger concern: Testing of the docker
>> images. I am
>> > open to ideas on how to test these images I create.
>> Currently, I spot
>> > check just to see if they build, which is pretty weak.
>> >
>> > Anyone have ideas for some additional testing?
>> >
>> > Thanks,
>> > Rod.
>> >
>> >
>> > On 1/21/20, 4:21 PM, "Jonathan Gallimore" <
>> jonathan.gallim...@gmail.com>
>> > wrote:
>> >
>> > Nationwide Information Security Warning: This is an
>> external email. Do
>> > not click on links or open attachments unless you trust the
>> sender.
>> >
>> >
>>
--
>> >
>> > These should be there now - my sincere apologies for
>> that.
>> >
>> > Jon
>> >
>> > On Tue, Jan 21, 2020 at 5:30 PM Jonathan Gallimore <
>> > jonathan.gallim...@gmail.com> wrote:
>> >
>> > > I'll get that fixed. Thanks
