Cleaning up ink_gethostbyname_r and ink_gethostbyaddr_r

Hi all, In an effort to get ATS to build on OpenBSD, I noticed that we're using gethostbyname_r and gethostbyaddr_r (see ink_inet.cc), according to the manpage both of these APIs are obsolete and getaddrinfo should be used (which is reentrant by default), I only noticed this because OpenBSD 5.0

Re: Cleaning up ink_gethostbyname_r and ink_gethostbyaddr_r

- Original Message - Hi all, In an effort to get ATS to build on OpenBSD, I noticed that we're using gethostbyname_r and gethostbyaddr_r (see ink_inet.cc), according to the manpage both of these APIs are obsolete and getaddrinfo should be used (which is reentrant by default), I

Re: Cleaning up ink_gethostbyname_r and ink_gethostbyaddr_r

- Original Message - - Original Message - Hi all, In an effort to get ATS to build on OpenBSD, I noticed that we're using gethostbyname_r and gethostbyaddr_r (see ink_inet.cc), according to the manpage both of these APIs are obsolete and getaddrinfo should be

Re: Cleaning up ink_gethostbyname_r and ink_gethostbyaddr_r

Mostly reasonable, just a few things to do better: 1) Do not use the ink_ prefix, we're moving to ats_. 2) It's not clear to me we need to wrap getaddrinfo at all unless you can simplify the api (e.g., ats_getbestaddrinfo). 3) Looking at the call sites which still use ink_gethostbyname, I

Re: TS-857 and finer grained locking

Looks good. I apologize to weijin and ming_zym for being too distracted to look closely at those even though I meant to do so. Not being able to replicate the problem even on old code bases made it problematic as well. Sunday, March 25, 2012, 5:56:01 PM, you wrote: I found the problem and it

Re: TS-857 and finer grained locking

I really should have looked more closely at what their posts as well. It took a long time for me to remember how lock switching was supposed to work. I think it is far too brittle and clearly it was poorly documented. I am going to add some inline documentation and when I can break some time

Re: TS-857 and finer grained locking

Thanks John and AMC, especially for AMC, he contribute a lot to solve this problem. Thanks again.

Re: Cleaning up ink_gethostbyname_r and ink_gethostbyaddr_r

I filed TS-1166, TS-1167, TS-1168, to track some of these places. TS-990 tracks the Cluster issue, and TS-1017 tracks it in logging. I am working on the logging. I will try to get through these others although others are welcome to step up :-).