Re: [New API proposal]TSIOBufferReaderPostGet

2018-03-08 Thread Bryan Call
Yes, I think renaming it would be good. -Bryan > On Mar 7, 2018, at 2:14 PM, CrazyCow wrote: > > Thanks, Alan. > > Yes, TSHttpTxnPostBufferReaderGet seems better to me. It's more consistent > with existing ones and more descriptive about the functionality. > > Bryan, what do you think? > >

Re: [New API proposal]TSIOBufferReaderPostGet

2018-03-07 Thread CrazyCow
Thanks, Alan. Yes, TSHttpTxnPostBufferReaderGet seems better to me. It's more consistent with existing ones and more descriptive about the functionality. Bryan, what do you think? 2018-03-07 12:34 GMT-08:00 Alan Carroll : > Seems reasonable, except maybe `TSHttpTxnPostBufferReaderGet()`? Most o

Re: [New API proposal]TSIOBufferReaderPostGet

2018-03-07 Thread Alan Carroll
Seems reasonable, except maybe `TSHttpTxnPostBufferReaderGet()`? Most of the API that takes a TSHttpTxn is prefixed with 'TSHTTPTxn'. On Wed, Mar 7, 2018 at 11:15 AM, Bryan Call wrote: > +1 > > -Bryan > > > > > On Mar 5, 2018, at 11:19 AM, CrazyCow > wrote: > > > > Hi, Team, > > > > Along with

Re: [New API proposal]TSIOBufferReaderPostGet

2018-03-07 Thread Bryan Call
+1 -Bryan > On Mar 5, 2018, at 11:19 AM, CrazyCow wrote: > > Hi, Team, > > Along with the post buffer PR > which buffers post body > before opening connections to origin servers, I'd introduce a new API that > enables plugins to read the bu