[GitHub] [incubator-tuweni] Nashatyrev commented on issue #186: ConcatenatedBytes bug

2020-12-16 Thread GitBox
Nashatyrev commented on issue #186: URL: https://github.com/apache/incubator-tuweni/issues/186#issuecomment-745964428 More localized testcase: ```java Bytes.wrap( Bytes.wrap(new byte[32]), Bytes.wrap(new byte[6]) ).slice(0, 37).copy() ``` throws:

[GitHub] [incubator-tuweni] atoulme opened a new pull request #187: Improve faucet: make the org check optional, and allow to configure the faucet transaction gas and gas price

2020-12-16 Thread GitBox
atoulme opened a new pull request #187: URL: https://github.com/apache/incubator-tuweni/pull/187 ## PR description Improve faucet: make the org check optional, and allow to configure the faucet transaction gas and gas price --

[GitHub] [incubator-tuweni] atoulme commented on issue #186: ConcatenatedBytes bug

2020-12-16 Thread GitBox
atoulme commented on issue #186: URL: https://github.com/apache/incubator-tuweni/issues/186#issuecomment-747228866 Thanks, looking. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #187: Improve faucet: make the org check optional, and allow to configure the faucet transaction gas and gas price

2020-12-16 Thread GitBox
codecov[bot] commented on pull request #187: URL: https://github.com/apache/incubator-tuweni/pull/187#issuecomment-747232386 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/187?src=pr&el=h1) Report > Merging [#187](https://codecov.io/gh/apache/incubator-tuweni/pull/187?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #187: Improve faucet: make the org check optional, and allow to configure the faucet transaction gas and gas price

2020-12-16 Thread GitBox
codecov[bot] edited a comment on pull request #187: URL: https://github.com/apache/incubator-tuweni/pull/187#issuecomment-747232386 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/187?src=pr&el=h1) Report > Merging [#187](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #187: Improve faucet: make the org check optional, and allow to configure the faucet transaction gas and gas price

2020-12-16 Thread GitBox
atoulme merged pull request #187: URL: https://github.com/apache/incubator-tuweni/pull/187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme opened a new pull request #188: Fix for bug #186

2020-12-16 Thread GitBox
atoulme opened a new pull request #188: URL: https://github.com/apache/incubator-tuweni/pull/188 ## PR description Fixes bug in code managing bytes concatenation. ## Fixed Issue(s) fixes #186 This is an automated

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #188: Fix for bug #186

2020-12-16 Thread GitBox
codecov[bot] commented on pull request #188: URL: https://github.com/apache/incubator-tuweni/pull/188#issuecomment-747252685 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/188?src=pr&el=h1) Report > Merging [#188](https://codecov.io/gh/apache/incubator-tuweni/pull/188?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #188: Fix for bug #186

2020-12-16 Thread GitBox
codecov[bot] edited a comment on pull request #188: URL: https://github.com/apache/incubator-tuweni/pull/188#issuecomment-747252685 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/188?src=pr&el=h1) Report > Merging [#188](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #188: Fix for bug #186

2020-12-16 Thread GitBox
atoulme merged pull request #188: URL: https://github.com/apache/incubator-tuweni/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme closed issue #186: ConcatenatedBytes bug

2020-12-16 Thread GitBox
atoulme closed issue #186: URL: https://github.com/apache/incubator-tuweni/issues/186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-tuweni] atoulme commented on issue #186: ConcatenatedBytes bug

2020-12-16 Thread GitBox
atoulme commented on issue #186: URL: https://github.com/apache/incubator-tuweni/issues/186#issuecomment-747258712 Fixed, thank you for reporting. Time to get 1.4.0 out soon. This is an automated message from the Apache Git

[GitHub] [incubator-tuweni] Nashatyrev commented on issue #168: Bytes32.wrap(Bytes value, int offset) doesn't honor offset for specific Bytes param

2020-12-17 Thread GitBox
Nashatyrev commented on issue #168: URL: https://github.com/apache/incubator-tuweni/issues/168#issuecomment-747292311 I believe this was fixed with #179 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tuweni] Nashatyrev closed issue #168: Bytes32.wrap(Bytes value, int offset) doesn't honor offset for specific Bytes param

2020-12-17 Thread GitBox
Nashatyrev closed issue #168: URL: https://github.com/apache/incubator-tuweni/issues/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tuweni] Nashatyrev commented on issue #88: Bytes.fromByteBuf() incorrectly interpret ByteBuf content

2020-12-17 Thread GitBox
Nashatyrev commented on issue #88: URL: https://github.com/apache/incubator-tuweni/issues/88#issuecomment-747296527 > If you think the existing behavior is the one which is expected (or may be already relied on by other libs), I would add a Javadoc comment and and an alternative method whi

[GitHub] [incubator-tuweni] atoulme commented on issue #124: Add javadoc and dokka docs website to Tuweni website

2020-12-31 Thread GitBox
atoulme commented on issue #124: URL: https://github.com/apache/incubator-tuweni/issues/124#issuecomment-753223152 94dc05b adds dokka docs to the website, you can now consult them here: http://tuweni.apache.org/docs/ This i

[GitHub] [incubator-tuweni] sirinath commented on issue #124: Add javadoc and dokka docs website to Tuweni website

2020-12-31 Thread GitBox
sirinath commented on issue #124: URL: https://github.com/apache/incubator-tuweni/issues/124#issuecomment-753245235 That's great! Will have a look. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tuweni] atoulme closed issue #185: Can some of the reusable components be published separately

2021-01-01 Thread GitBox
atoulme closed issue #185: URL: https://github.com/apache/incubator-tuweni/issues/185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-tuweni] atoulme commented on issue #185: Can some of the reusable components be published separately

2021-01-01 Thread GitBox
atoulme commented on issue #185: URL: https://github.com/apache/incubator-tuweni/issues/185#issuecomment-753444987 I added a tutorial to get started with bytes tonight: http://tuweni.apache.org/tutorials/getting-started-with-bytes/ Hopefully it helps you get situated. I am going to

[GitHub] [incubator-tuweni] atoulme commented on issue #124: Add javadoc and dokka docs website to Tuweni website

2021-01-01 Thread GitBox
atoulme commented on issue #124: URL: https://github.com/apache/incubator-tuweni/issues/124#issuecomment-753445088 Also added a getting started guide for bytes - http://tuweni.apache.org/tutorials/getting-started-with-bytes/ ---

[GitHub] [incubator-tuweni] atoulme opened a new pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-06 Thread GitBox
atoulme opened a new pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189 ## PR description Secure the contents of the secret key into a "secured" Bytes object which is using GuardedBytesArray under the covers.

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-07 Thread GitBox
codecov[bot] commented on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-07 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-07 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-07 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report > Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-08 Thread GitBox
atoulme merged pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme merged pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-09 Thread GitBox
atoulme merged pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet

2021-01-09 Thread GitBox
codecov[bot] edited a comment on pull request #189: URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-tuweni] atoulme opened a new pull request #190: Fix the URLs of the tag names in releases

2021-01-09 Thread GitBox
atoulme opened a new pull request #190: URL: https://github.com/apache/incubator-tuweni/pull/190 ## PR description Fix the URLs of the tag names in releases This is an automated message from the Apache Git

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #190: Fix the URLs of the tag names in releases

2021-01-09 Thread GitBox
codecov[bot] commented on pull request #190: URL: https://github.com/apache/incubator-tuweni/pull/190#issuecomment-757427017 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/190?src=pr&el=h1) Report > Merging [#190](https://codecov.io/gh/apache/incubator-tuweni/pull/190?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #190: Fix the URLs of the tag names in releases

2021-01-09 Thread GitBox
codecov[bot] edited a comment on pull request #190: URL: https://github.com/apache/incubator-tuweni/pull/190#issuecomment-757427017 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/190?src=pr&el=h1) Report > Merging [#190](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #190: Fix the URLs of the tag names in releases

2021-01-10 Thread GitBox
atoulme merged pull request #190: URL: https://github.com/apache/incubator-tuweni/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme closed pull request #162: Add an experimental discv4 scraper

2021-01-10 Thread GitBox
atoulme closed pull request #162: URL: https://github.com/apache/incubator-tuweni/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme closed issue #172: RLPx service enhancements

2021-01-10 Thread GitBox
atoulme closed issue #172: URL: https://github.com/apache/incubator-tuweni/issues/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-tuweni] atoulme commented on issue #172: RLPx service enhancements

2021-01-10 Thread GitBox
atoulme commented on issue #172: URL: https://github.com/apache/incubator-tuweni/issues/172#issuecomment-757437077 All done now. RLPxService#addToKeepAliveList allows to keep connections. This is an automated message from th

[GitHub] [incubator-tuweni] atoulme opened a new pull request #191: Add sodium to hashing

2021-01-10 Thread GitBox
atoulme opened a new pull request #191: URL: https://github.com/apache/incubator-tuweni/pull/191 ## PR description Add sodium to a few sha256 functions that can use directly ## Fixed Issue(s) Fixes #147 -

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #191: Add sodium to hashing

2021-01-10 Thread GitBox
codecov[bot] commented on pull request #191: URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pull/191?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #191: Add sodium to hashing

2021-01-11 Thread GitBox
codecov[bot] edited a comment on pull request #191: URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #191: Add sodium to hashing

2021-01-12 Thread GitBox
codecov[bot] edited a comment on pull request #191: URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #191: Add sodium to hashing

2021-01-12 Thread GitBox
codecov[bot] edited a comment on pull request #191: URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme closed issue #147: Replace the hash functions in Hash to use sodium when possible and when sodium is available

2021-01-15 Thread GitBox
atoulme closed issue #147: URL: https://github.com/apache/incubator-tuweni/issues/147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-tuweni] atoulme merged pull request #191: Add sodium to hashing

2021-01-15 Thread GitBox
atoulme merged pull request #191: URL: https://github.com/apache/incubator-tuweni/pull/191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme opened a new pull request #192: Better handle exceptions for JSON-RPC

2021-01-15 Thread GitBox
atoulme opened a new pull request #192: URL: https://github.com/apache/incubator-tuweni/pull/192 ## PR description Handle timeouts gracefully This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tuweni] atoulme opened a new pull request #193: add bootstrap css to faucet, make it look nicer, display better errors

2021-01-15 Thread GitBox
atoulme opened a new pull request #193: URL: https://github.com/apache/incubator-tuweni/pull/193 ## PR description add bootstrap css to faucet, make it look nicer, display better errors This is an a

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #192: Better handle exceptions for JSON-RPC

2021-01-15 Thread GitBox
codecov[bot] commented on pull request #192: URL: https://github.com/apache/incubator-tuweni/pull/192#issuecomment-760754073 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=h1) Report > Merging [#192](https://codecov.io/gh/apache/incubator-tuweni/pull/192?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #192: Better handle exceptions for JSON-RPC

2021-01-15 Thread GitBox
codecov[bot] edited a comment on pull request #192: URL: https://github.com/apache/incubator-tuweni/pull/192#issuecomment-760754073 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=h1) Report > Merging [#192](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #192: Better handle exceptions for JSON-RPC

2021-01-15 Thread GitBox
atoulme merged pull request #192: URL: https://github.com/apache/incubator-tuweni/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #193: add bootstrap css to faucet, make it look nicer, display better errors

2021-01-15 Thread GitBox
codecov[bot] commented on pull request #193: URL: https://github.com/apache/incubator-tuweni/pull/193#issuecomment-761211170 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/193?src=pr&el=h1) Report > Merging [#193](https://codecov.io/gh/apache/incubator-tuweni/pull/193?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #193: add bootstrap css to faucet, make it look nicer, display better errors

2021-01-15 Thread GitBox
codecov[bot] edited a comment on pull request #193: URL: https://github.com/apache/incubator-tuweni/pull/193#issuecomment-761211170 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/193?src=pr&el=h1) Report > Merging [#193](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #193: add bootstrap css to faucet, make it look nicer, display better errors

2021-01-16 Thread GitBox
atoulme merged pull request #193: URL: https://github.com/apache/incubator-tuweni/pull/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme closed issue #124: Add javadoc and dokka docs website to Tuweni website

2021-01-16 Thread GitBox
atoulme closed issue #124: URL: https://github.com/apache/incubator-tuweni/issues/124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-tuweni] atoulme commented on issue #124: Add javadoc and dokka docs website to Tuweni website

2021-01-16 Thread GitBox
atoulme commented on issue #124: URL: https://github.com/apache/incubator-tuweni/issues/124#issuecomment-761738853 Closing the issue! Let me know if you have something you'd like to see. This is an automated message from the

[GitHub] [incubator-tuweni] atoulme closed issue #52: Stratum mining proxy

2021-01-16 Thread GitBox
atoulme closed issue #52: URL: https://github.com/apache/incubator-tuweni/issues/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tuweni] atoulme opened a new pull request #194: Add syncing capabilities for mainnet

2021-01-26 Thread GitBox
atoulme opened a new pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194 ## PR description This PR includes a set of synchronizing methods that allow the Ethereum client to sync up. It requires more testing. ---

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #194: Add syncing capabilities for mainnet

2021-01-26 Thread GitBox
codecov[bot] commented on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-768043642 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/194?src=pr&el=h1) Report > Merging [#194](https://codecov.io/gh/apache/incubator-tuweni/pull/194?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #194: Add syncing capabilities for mainnet

2021-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-768043642 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/194?src=pr&el=h1) Report > Merging [#194](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme commented on pull request #194: Add syncing capabilities for mainnet

2021-02-02 Thread GitBox
atoulme commented on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-771983365 @nfmelendez would you like to try your hand at reviewing this PR? This is an automated message from the A

[GitHub] [incubator-tuweni] atoulme commented on pull request #194: Add syncing capabilities for mainnet

2021-02-02 Thread GitBox
atoulme commented on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-771983365 @nfmelendez would you like to try your hand at reviewing this PR? This is an automated message from the A

[GitHub] [incubator-tuweni] nfmelendez commented on a change in pull request #194: Add syncing capabilities for mainnet

2021-02-03 Thread GitBox
nfmelendez commented on a change in pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#discussion_r569462258 ## File path: devp2p-eth/src/main/kotlin/org/apache/tuweni/devp2p/eth/EthRequestsManager.kt ## @@ -30,75 +31,126 @@ import org.apache.tuweni.rl

[GitHub] [incubator-tuweni] nfmelendez commented on a change in pull request #194: Add syncing capabilities for mainnet

2021-02-03 Thread GitBox
nfmelendez commented on a change in pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#discussion_r569475522 ## File path: eth-client/src/main/kotlin/org/apache/tuweni/ethclient/FromBestBlockSynchronizer.kt ## @@ -0,0 +1,65 @@ +/* + * Licensed to the A

[GitHub] [incubator-tuweni] atoulme opened a new pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
atoulme opened a new pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195 ## PR description Use the Bytes hash code to perform equals, and cache it if possible. This is an automated m

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
codecov[bot] commented on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pull/195?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #194: Add syncing capabilities for mainnet

2021-02-20 Thread GitBox
atoulme commented on a change in pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#discussion_r579762321 ## File path: eth-client/src/main/kotlin/org/apache/tuweni/ethclient/FromBestBlockSynchronizer.kt ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apac

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #194: Add syncing capabilities for mainnet

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-768043642 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/194?src=pr&el=h1) Report > Merging [#194](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme commented on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
atoulme commented on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782812555 @shemnon you might like to review - this is the improvement you mentioned a while back. I'd like to get that in now so we can cut a release with it, given how bad I've be

[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #194: Add syncing capabilities for mainnet

2021-02-20 Thread GitBox
atoulme commented on a change in pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#discussion_r579763057 ## File path: eth-client/src/main/kotlin/org/apache/tuweni/ethclient/FromBestBlockSynchronizer.kt ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apac

[GitHub] [incubator-tuweni] atoulme commented on pull request #194: Add syncing capabilities for mainnet

2021-02-20 Thread GitBox
atoulme commented on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-782812624 Thanks for the review. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #194: Add syncing capabilities for mainnet

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-768043642 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/194?src=pr&el=h1) Report > Merging [#194](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #194: Add syncing capabilities for mainnet

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194#issuecomment-768043642 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/194?src=pr&el=h1) Report > Merging [#194](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-20 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme opened a new pull request #196: rename license folder to license-reports

2021-02-20 Thread GitBox
atoulme opened a new pull request #196: URL: https://github.com/apache/incubator-tuweni/pull/196 ## PR description Case insensitive file systems don't like having to deal with a LICENSE file and license folder. Renaming license to license-reports. --

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #196: rename license folder to license-reports

2021-02-21 Thread GitBox
codecov[bot] commented on pull request #196: URL: https://github.com/apache/incubator-tuweni/pull/196#issuecomment-782817547 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/196?src=pr&el=h1) Report > Merging [#196](https://codecov.io/gh/apache/incubator-tuweni/pull/196?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #196: rename license folder to license-reports

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #196: URL: https://github.com/apache/incubator-tuweni/pull/196#issuecomment-782817547 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/196?src=pr&el=h1) Report > Merging [#196](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #196: rename license folder to license-reports

2021-02-21 Thread GitBox
atoulme merged pull request #196: URL: https://github.com/apache/incubator-tuweni/pull/196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #194: Add syncing capabilities for mainnet

2021-02-21 Thread GitBox
atoulme merged pull request #194: URL: https://github.com/apache/incubator-tuweni/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
codecov[bot] edited a comment on pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195#issuecomment-782795420 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/195?src=pr&el=h1) Report > Merging [#195](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #195: Make Bytes more performant by caching hashcode

2021-02-21 Thread GitBox
atoulme merged pull request #195: URL: https://github.com/apache/incubator-tuweni/pull/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] atoulme opened a new pull request #197: Use one docker image for all of Tuweni

2021-02-28 Thread GitBox
atoulme opened a new pull request #197: URL: https://github.com/apache/incubator-tuweni/pull/197 ## PR description We had multiple docker images, but since we're working on having a binary distro with all our executables, we can create a docker image that defaults to the tuw

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #197: Use one docker image for all of Tuweni

2021-02-28 Thread GitBox
codecov[bot] commented on pull request #197: URL: https://github.com/apache/incubator-tuweni/pull/197#issuecomment-787599188 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=h1) Report > Merging [#197](https://codecov.io/gh/apache/incubator-tuweni/pull/197?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #197: Use one docker image for all of Tuweni

2021-02-28 Thread GitBox
codecov[bot] edited a comment on pull request #197: URL: https://github.com/apache/incubator-tuweni/pull/197#issuecomment-787599188 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=h1) Report > Merging [#197](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme merged pull request #197: Use one docker image for all of Tuweni

2021-02-28 Thread GitBox
atoulme merged pull request #197: URL: https://github.com/apache/incubator-tuweni/pull/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tuweni] shemnon opened a new pull request #198: Wire up Delegate Bytes equals and hashCode

2021-03-03 Thread GitBox
shemnon opened a new pull request #198: URL: https://github.com/apache/incubator-tuweni/pull/198 * wire up equals and hashCode directly to the delegate * refactor the delegate classes to reduce code duplication In Besu this lack of delegation accounts for ~20% of bonsai import time

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #198: Wire up Delegate Bytes equals and hashCode

2021-03-03 Thread GitBox
codecov[bot] commented on pull request #198: URL: https://github.com/apache/incubator-tuweni/pull/198#issuecomment-790046162 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/198?src=pr&el=h1) Report > Merging [#198](https://codecov.io/gh/apache/incubator-tuweni/pull/198?s

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #198: Wire up Delegate Bytes equals and hashCode

2021-03-03 Thread GitBox
codecov[bot] edited a comment on pull request #198: URL: https://github.com/apache/incubator-tuweni/pull/198#issuecomment-790046162 # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/198?src=pr&el=h1) Report > Merging [#198](https://codecov.io/gh/apache/incubator-tuweni/pul

[GitHub] [incubator-tuweni] atoulme commented on pull request #198: Wire up Delegate Bytes equals and hashCode

2021-03-03 Thread GitBox
atoulme commented on pull request #198: URL: https://github.com/apache/incubator-tuweni/pull/198#issuecomment-790078819 LGTM. Feel free to merge - the code coverage ratio failure is ok for now. This is an automated message fr

  1   2   3   4   5   6   7   8   9   10   >