[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89042093 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89042464 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94521832 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java --- @@ -273,17 +274,19 @@ private MessageCallback

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94522513 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java --- @@ -273,17 +274,19 @@ private MessageCallback

[GitHub] twill pull request #16: [TWILL-199] Return the offset to read next message i...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r9505 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -33,14 +33,16 @@ /** * Invoked when new

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94522256 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java --- @@ -68,7 +69,7 @@ /** * A {@link

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94558457 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java --- @@ -273,17 +274,19 @@ private MessageCallback

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94558645 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java --- @@ -68,7 +69,7 @@ /** * A {@link

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94559673 --- Diff: twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java --- @@ -170,11 +174,128 @@ public void testKafkaClient() throws Exception

[GitHub] twill pull request #16: [TWILL-199] Return the offset to read next message i...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94914331 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -33,14 +33,16 @@ /** * Invoked when new

[GitHub] twill pull request #16: [TWILL-199] Return the offset to read next message i...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94915705 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -33,14 +33,16 @@ /** * Invoked when new

[GitHub] twill pull request #16: [TWILL-199] Return the offset to read next message i...

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r94913855 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -33,14 +33,16 @@ /** * Invoked when new

[GitHub] twill issue #16: [TWILL-199] Return the offset to read next message in Kafka...

Github user maochf commented on the issue: https://github.com/apache/twill/pull/16 Thank you! Just squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131234842 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,75 @@ public void initialize(EventHandlerContext context

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

GitHub user maochf opened a pull request: https://github.com/apache/twill/pull/58 [TWILL-240] EventHandler Improvement https://issues.apache.org/jira/browse/TWILL-240 Add started, containerLaunched, containerStopped, completed, killed, aborted to EventHandler You can

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132298585 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -193,7 +200,91 @@ private EventHandler

[GitHub] twill issue #58: [TWILL-240] EventHandler Improvement

Github user maochf commented on the issue: https://github.com/apache/twill/pull/58 squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so