[GitHub] twill issue #11: Fix a ClassCastException in YarnUtils.addDelegationTokens.

2016-09-20 Thread poornachandra
Github user poornachandra commented on the issue:

https://github.com/apache/twill/pull/11
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill issue #11: Fix a ClassCastException in YarnUtils.addDelegationTokens.

2016-09-20 Thread anwar6953
Github user anwar6953 commented on the issue:

https://github.com/apache/twill/pull/11
  
I think the failed test cases 
(https://travis-ci.org/apache/twill/builds/161527818) are flaky.
Rerunning to check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill issue #11: Fix a ClassCastException in YarnUtils.addDelegationTokens.

2016-09-20 Thread bdmogal
Github user bdmogal commented on the issue:

https://github.com/apache/twill/pull/11
  
fix lgtm. wondering if this code path is not executed in tests though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---