Re: [PR] Fix: make footer responsive on smaller screens [unomi-site]

2026-02-09 Thread via GitHub


Prakash1185 commented on PR #39:
URL: https://github.com/apache/unomi-site/pull/39#issuecomment-3873611319

   Thanks for the clear explanation and for reviewing the PR, @sergehuber.
   
   Totally okay with holding off on this PR and glad to hear it’s already 
addressed there.
   
   Looking forward to contributing more once the redesign lands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Fix: make footer responsive on smaller screens [unomi-site]

2026-02-09 Thread via GitHub


sergehuber commented on PR #39:
URL: https://github.com/apache/unomi-site/pull/39#issuecomment-3873519819

   Hi @Prakash1185,
   
   Thank you for this contribution and for the clear screenshots showing the 
problem — really helpful!
   
   I wanted to let you know that there's a larger website redesign currently 
under review in [PR#40](https://github.com/apache/unomi-site/pull/40) 
([UNOMI-932](https://issues.apache.org/jira/browse/UNOMI-932)) that touches the 
same area. The new footer already uses `col-6 col-md-3` which is essentially 
the same fix you're proposing here, so your change is effectively included in 
that work.
   
   Would you be ok if we hold off on merging this one to avoid conflicts with 
the redesign branch? I don't want to lose the intent of your contribution — it 
was a good catch.
   
   Once the redesign lands, if you spot any other issues or areas for 
improvement we'd really welcome more PRs!
   
   Thanks,
   Serge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]