[jira] [Commented] (VELTOOLS-186) Review shared VelocityView initialization error handling

2020-03-08 Thread Claude Brisson (Jira)


[ 
https://issues.apache.org/jira/browse/VELTOOLS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054507#comment-17054507
 ] 

Claude Brisson commented on VELTOOLS-186:
-

> If this one is shared, shouldn't a listener rather create this instance and 
> not a servlet?

It's a lazy initialization process, the shared view is built the first time it 
is needed. That's fine this way, since a servlet or a filter relying on the 
view cannot do much without it. We should just ensure there's only one attempt.

> What if someone wants to views differently configured?

That's taken in to account. Servlets use the shared view by default but can use 
their own.



> Review shared VelocityView initialization error handling
> 
>
> Key: VELTOOLS-186
> URL: https://issues.apache.org/jira/browse/VELTOOLS-186
> Project: Velocity Tools
>  Issue Type: Bug
>  Components: VelocityView
>Affects Versions: 3.0
>Reporter: Claude Brisson
>Assignee: Claude Brisson
>Priority: Minor
>
> When VelocityView instanciation fails (aka throws an unrecoverable 
> exception), it is attempted again as many times as there are servlets or 
> filters relying on it, even when the instance is supposed to be shared.
> The proper behavior would be to somehow mark the shared instance attribute as 
> being  invalid (but not null).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELTOOLS-186) Review shared VelocityView initialization error handling

2020-03-08 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/VELTOOLS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054504#comment-17054504
 ] 

Michael Osipov commented on VELTOOLS-186:
-

What if someone wants to views differently configured?

> Review shared VelocityView initialization error handling
> 
>
> Key: VELTOOLS-186
> URL: https://issues.apache.org/jira/browse/VELTOOLS-186
> Project: Velocity Tools
>  Issue Type: Bug
>  Components: VelocityView
>Affects Versions: 3.0
>Reporter: Claude Brisson
>Assignee: Claude Brisson
>Priority: Minor
>
> When VelocityView instanciation fails (aka throws an unrecoverable 
> exception), it is attempted again as many times as there are servlets or 
> filters relying on it, even when the instance is supposed to be shared.
> The proper behavior would be to somehow mark the shared instance attribute as 
> being  invalid (but not null).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELTOOLS-186) Review shared VelocityView initialization error handling

2020-03-08 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/VELTOOLS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054503#comment-17054503
 ] 

Michael Osipov commented on VELTOOLS-186:
-

If this one is shared, shouldn't a listener rather create this instance and not 
a servlet?

> Review shared VelocityView initialization error handling
> 
>
> Key: VELTOOLS-186
> URL: https://issues.apache.org/jira/browse/VELTOOLS-186
> Project: Velocity Tools
>  Issue Type: Bug
>  Components: VelocityView
>Affects Versions: 3.0
>Reporter: Claude Brisson
>Assignee: Claude Brisson
>Priority: Minor
>
> When VelocityView instanciation fails (aka throws an unrecoverable 
> exception), it is attempted again as many times as there are servlets or 
> filters relying on it, even when the instance is supposed to be shared.
> The proper behavior would be to somehow mark the shared instance attribute as 
> being  invalid (but not null).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELTOOLS-186) Review shared VelocityView initialization error handling

2020-03-08 Thread Claude Brisson (Jira)


[ 
https://issues.apache.org/jira/browse/VELTOOLS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054500#comment-17054500
 ] 

Claude Brisson commented on VELTOOLS-186:
-

The would-be-shared instance never gets a chance to be stored as a webapp 
context attribute as it is meant to, so a new instance is allocated (and 
dropped) every time.


> Review shared VelocityView initialization error handling
> 
>
> Key: VELTOOLS-186
> URL: https://issues.apache.org/jira/browse/VELTOOLS-186
> Project: Velocity Tools
>  Issue Type: Bug
>  Components: VelocityView
>Affects Versions: 3.0
>Reporter: Claude Brisson
>Assignee: Claude Brisson
>Priority: Minor
>
> When VelocityView instanciation fails (aka throws an unrecoverable 
> exception), it is attempted again as many times as there are servlets or 
> filters relying on it, even when the instance is supposed to be shared.
> The proper behavior would be to somehow mark the shared instance attribute as 
> being  invalid (but not null).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELTOOLS-186) Review shared VelocityView initialization error handling

2020-03-08 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/VELTOOLS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054426#comment-17054426
 ] 

Michael Osipov commented on VELTOOLS-186:
-

Is that a singleton or a new instance everytime?

> Review shared VelocityView initialization error handling
> 
>
> Key: VELTOOLS-186
> URL: https://issues.apache.org/jira/browse/VELTOOLS-186
> Project: Velocity Tools
>  Issue Type: Bug
>  Components: VelocityView
>Affects Versions: 3.0
>Reporter: Claude Brisson
>Assignee: Claude Brisson
>Priority: Minor
>
> When VelocityView instanciation fails (aka throws an unrecoverable 
> exception), it is attempted again as many times as there are servlets or 
> filters relying on it, even when the instance is supposed to be shared.
> The proper behavior would be to somehow mark the shared instance attribute as 
> being  invalid (but not null).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org