Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/126#discussion_r106684486
--- Diff: html5/frameworks/vanilla/index.js ---
@@ -1,107 +1,334 @@
-const config = {}
-const instanceMap = {}
+const instances
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/126#discussion_r106686382
--- Diff: html5/frameworks/vanilla/index.js ---
@@ -1,107 +1,334 @@
-const config = {}
-const instanceMap = {}
+const instances
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex/pull/126
The `document.addCallback` is no longer supported, those test cases should
be rewritten someday.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/126#discussion_r106826163
--- Diff: html5/frameworks/vanilla/index.js ---
@@ -1,107 +1,334 @@
-const config = {}
-const instanceMap = {}
+const instances
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex/pull/126
That because the node.js environment doesn't have the `callNative` method.
You should mock that method in tests.
1. Import `sinon`, which is already in the `devDependencie
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex/pull/126
@yong-chen04 The code style may also need to change to follow our eslint
rules.
The line 181 and 200 should be:
```js
if () {
}
else
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/2
This PR is already merged into master.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/8
I have already squash merged this PR into master, but its state doesn't
change. Is there something wrong with my operation?
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/8
Sorry for my misoperation, this PR is squash merged into master, but the
apache bot doesn't update the state of this PR. I'll close this PR later. Sorry
again.
---
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/17
[WEEX-86][doc] update tutorial document
Update tutorial document.
+ What is Weex?
+ Overview
+ Native Components
+ Native Modules
+ Write Once, Run
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/18
[WEEX-86][doc] update vuex and vue-router document
Update the **Use Vuex and vue-router** document.
English source:
https://github.com/Hanks10100/incubator-weex-site/blob
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/17#discussion_r153685253
--- Diff: source/guide/index.md ---
@@ -6,99 +6,156 @@ order: 1.1
version: 2.1
---
+
+
## What is Weex
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/17#discussion_r153686549
--- Diff: source/guide/index.md ---
@@ -6,99 +6,156 @@ order: 1.1
version: 2.1
---
+
+
## What is Weex
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/20
[WEEX-86][doc] update the "Weex Variable" documents
Here is the source:
https://github.com/Hanks10100/incubator-weex-site/blob/weex-variable/source/references/weex-variabl
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/21
[WEEX-86][doc] add documents for BroadcastChannel
Add document for `BroadcastChannel`, separate it from the js service
document.
Source:
https://github.com/Hanks10100
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/23
update app name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator-weex-site patch-2
Alternatively you can
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/19#discussion_r159422810
--- Diff: source/references/modules/navigator.md ---
@@ -42,7 +41,8 @@ pop a weex page onto the navigator stack, you can specify
whether
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/26
[WEEX-86][doc] update documents about front-end frameworks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/27
[WEEX-86][doc] add document about how to use Vue in Weex
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/31
[doc] add Chinese document about how to getting started
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/32
[doc] update Chinese documents about front-end frameworks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/42
Thanks for your contribution! I think it's a good idea to use English
commit log. I'll modify it before merge.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/43
As I mentioned in https://github.com/apache/incubator-weex-site/pull/42 .
It's better to use English in the commit log. I'll modify it before merge.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/46
Thanks for your contribution! Please use English in the commit log.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/46
No need to open a new PR, I can squash and modify the commit log before
merging. Moreover, you can also force update your `use-vue-branch` branch to
modify them.
---
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/46#discussion_r163441614
--- Diff: source/cn/guide/use-vue.md ---
@@ -5,7 +5,280 @@ group: Overview
order: 1.6
version: 2.1
---
+
--- End diff
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/46#discussion_r163442514
--- Diff: source/cn/guide/use-vue.md ---
@@ -5,7 +5,280 @@ group: Overview
order: 1.6
version: 2.1
---
+
-Working
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/46#discussion_r163442826
--- Diff: source/cn/guide/use-vue.md ---
@@ -5,7 +5,280 @@ group: Overview
order: 1.6
version: 2.1
---
+
-Working
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/46#discussion_r163444366
--- Diff: source/cn/guide/use-vue.md ---
@@ -5,7 +5,280 @@ group: Overview
order: 1.6
version: 2.1
---
+
-Working
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/46#discussion_r16362
--- Diff: source/cn/guide/use-vue.md ---
@@ -5,7 +5,280 @@ group: Overview
order: 1.6
version: 2.1
---
+
-Working
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/46
I think you should rebase and modify the commit log to English, then force
update the branch. Or I will do it before merge, but your author information
would be lost and this PR will
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/50
Thanks for your contribution! Please use English in the commit log, just
like #51 .
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/61
I just merged #60, it caused a conflict with this pr. By the way, please
use English in the commit log. You can resolve the conflict and change the
commit log by force update (or open
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/44
@1xuanyuan1 Just remind you that, we have already re-designed the [who is
using weex](http://weex.apache.org/who-is-using-weex.html) and deployed it.
This pr has a conflict with the
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/69
Thanks for your contribution, but the commit log should be written in
English.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/71
Thanks for your contribution, please use English to write the commit log.
I'll modify it before merge.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/77
Thanks for your contribution, but the commit log should be written in
English. You can modify the commit log and force update, or I'll modify it
before merge.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/77
@shikechen You can try `git push -f` to force update your master branch. If
I squash and modified your commits, your contribution info would be omitted.
I'm not sure if you care
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/77
Not append commit logs, what I mean is to modify it... Never mind, I merged
it anyway.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/78
Thanks for your contribution, please use English in the commit log.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/86
Thanks for your contribution, please use Engish in the commit log. The
"ä¿®æ¹ææ¡" may not be needed.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/89
The name may be too long. Could we just use "é£å" instead of
"é£å-å½é
æºç¥¨æ¯ä»·"?
---
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/91
Fix bad links in who-is-using-weex page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hanks10100/incubator-weex-site patch-4
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/92#discussion_r173422067
--- Diff: source/contributing.md ---
@@ -7,42 +7,52 @@ version: 2.1
# How to Contribute
-Apache Weex is an open source
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/100
Please use English in the commit log, the description may not necessary.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/100
@zichunping I get it, but the commit log should not contain Chinese words.
You can modify the commits locally and force update it to your `patch-1` branch.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/103
Your icon image contains transparent margins, which will make it looks
smaller than others. I suggest you change it to keep consistent.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/100
@zichunping I don't mean the title of this PR, I mean the commit log. I'll
help you to revise it before merge.
---
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/107#discussion_r176383260
--- Diff: source/cn/wiki/handler-introduction.md ---
@@ -0,0 +1,51 @@
+---
+title: handler
--- End diff --
The title
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/107#discussion_r176383717
--- Diff: source/cn/guide/extend-module-using-swift.md ---
@@ -0,0 +1,110 @@
+---
+title: ä½¿ç¨ swift æ©å± Weex
--- End diff
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/107#discussion_r176384573
--- Diff: source/guide/extend-module-using-swift.md ---
@@ -0,0 +1,114 @@
+---
+title: Extend weex using swift
--- End diff
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/119
I think we should add a brief explanation about why it's deprecated.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/129
Thanks for your contribution, please use English in the commit log. Anyway,
I'll help you to revise it in this pr.
---
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/135
Update document of the weex variable api
Add document for the `isRegisteredModule` and `isRegisteredComponent` api.
You can merge this pull request into a Git repository by running
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/135#discussion_r181969098
--- Diff: source/references/weex-variable.md ---
@@ -160,3 +160,36 @@ weex.supports('module/*') // null
weex.supports(
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/139#discussion_r183214343
--- Diff: source/guide/integrate-to-your-app.md ---
@@ -25,7 +25,7 @@ The keys to intergrating Weex into your Android
application are the
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/142
Thanks for your contribution, please use English in the commit log. I'll
help to modify it if you don't mind.
---
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/144#discussion_r184253992
--- Diff: source/cn/wiki/design-principles.md ---
@@ -7,3 +7,15 @@ version: 2.1
---
+
+# Weex设计ç念
+è¿ç
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/154
The document of native-dom-api.html is removed, we may remove the link in
the "Weex Page Architecture" as well.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/155
Thanks for your contribution, please use English in the commit log. I'll
help you to revise it before merge.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/161
The commit log should not contain Chinese characters. I'll help you to
revise it before merge.
---
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/164
Please check your icon address, make sure it's an image. By the way, please
make sure your app name, should be "å°é¹¿éæ¿" or "çæ¿æ¥è®°".
---
GitHub user Hanks10100 opened a pull request:
https://github.com/apache/incubator-weex-site/pull/166
[WEEX-455] Add examples page to the website
Migrate the examples page (https://hanks10100.github.io/weex-vue-examples/)
to the official website of Weex (http://weex-project.io
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/181
Thanks for your support, we really appreciate it! But please use English
and do not mention "é¿é" in the commit log.
I can help you to revise the commit log if
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex-site/pull/181
Thanks for your cooperate, however, what I really mean is the **commit
log**, not the description of this PR (Using Chinese in the PR is fine).
You can checkout the `patch-1
65 matches
Mail list logo
