[GitHub] incubator-weex-site pull request #92: Updating document for Contributing to ...

2018-03-08 Thread varunsob
GitHub user varunsob opened a pull request: https://github.com/apache/incubator-weex-site/pull/92 Updating document for Contributing to Weex Changes are done to the document for simplifying the language and also providing more details to some of the sections. You can merge this

[GitHub] incubator-weex-site issue #94: Correct some wrong links

2018-03-09 Thread varunsob
Github user varunsob commented on the issue: https://github.com/apache/incubator-weex-site/pull/94 @shikechen I agree completely with the changes you've done. And Yes, we should add another "homepage" item and use it if the visitor clicks on the company logo (outside android/ios icon). ---

[GitHub] incubator-weex-site pull request #92: Updating document for Contributing to ...

2018-03-09 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/92#discussion_r173430846 --- Diff: source/contributing.md --- @@ -7,42 +7,52 @@ version: 2.1 # How to Contribute -Apache Weex is an open source

[GitHub] incubator-weex-site pull request #126: Update css-units.md

2018-03-28 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/126#discussion_r177655427 --- Diff: source/wiki/css-units.md --- @@ -8,4 +8,50 @@ version: 2.1 -Work in progresss. +## CSS `color` units

[GitHub] incubator-weex-site pull request #135: Update document of the weex variable ...

2018-04-16 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/135#discussion_r181968835 --- Diff: source/references/weex-variable.md --- @@ -160,3 +160,36 @@ weex.supports('module/*') // null weex.supports(

[GitHub] incubator-weex-site pull request #135: Update document of the weex variable ...

2018-04-17 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/135#discussion_r181969545 --- Diff: source/references/weex-variable.md --- @@ -160,3 +160,36 @@ weex.supports('module/*') // null weex.supports(

[GitHub] incubator-weex-site pull request #135: Update document of the weex variable ...

2018-04-17 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/135#discussion_r181969706 --- Diff: source/references/weex-variable.md --- @@ -160,3 +160,36 @@ weex.supports('module/*') // null weex.supports(

[GitHub] incubator-weex-site pull request #156: Updating development process document

2018-05-22 Thread varunsob
GitHub user varunsob opened a pull request: https://github.com/apache/incubator-weex-site/pull/156 Updating development process document You can merge this pull request into a Git repository by running: $ git pull https://github.com/varunsob/incubator-weex-site

[GitHub] incubator-weex-site pull request #172: General edits to guide/index.md file

2018-07-04 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/172#discussion_r200234408 --- Diff: source/guide/index.md --- @@ -10,124 +10,125 @@ version: 2.1 ## What is Weex? -> **Weex is a framework

[GitHub] incubator-weex-site pull request #172: General edits to guide/index.md file

2018-07-04 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/172#discussion_r200237523 --- Diff: source/guide/index.md --- @@ -10,124 +10,125 @@ version: 2.1 ## What is Weex? -> **Weex is a framework

[GitHub] incubator-weex-site pull request #172: General edits to guide/index.md file

2018-07-04 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/172#discussion_r200234707 --- Diff: source/guide/index.md --- @@ -10,124 +10,125 @@ version: 2.1 ## What is Weex? -> **Weex is a framework

[GitHub] incubator-weex-site pull request #172: General edits to guide/index.md file

2018-07-04 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/172#discussion_r200235384 --- Diff: source/guide/index.md --- @@ -10,124 +10,125 @@ version: 2.1 ## What is Weex? -> **Weex is a framework

[GitHub] incubator-weex-site pull request #172: General edits to guide/index.md file

2018-07-04 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/172#discussion_r200237176 --- Diff: source/guide/index.md --- @@ -10,124 +10,125 @@ version: 2.1 ## What is Weex? -> **Weex is a framework

[GitHub] incubator-weex-site pull request #172: General edits to guide/index.md file

2018-07-05 Thread varunsob
Github user varunsob commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/172#discussion_r200552082 --- Diff: source/guide/index.md --- @@ -124,11 +124,11 @@ npm install npm start ``` -`npm start` will start a web server on