[jira] [Commented] (WEEX-174) TemplateList Support Lifecycle and statefull component
[ https://issues.apache.org/jira/browse/WEEX-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356672#comment-16356672 ] ASF GitHub Bot commented on WEEX-174: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/1019 > TemplateList Support Lifecycle and statefull component > -- > > Key: WEEX-174 > URL: https://issues.apache.org/jira/browse/WEEX-174 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: Adam Feng >Priority: Major > > TemplateList Support Lifecycle and statefull component -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-174) TemplateList Support Lifecycle and statefull component
[ https://issues.apache.org/jira/browse/WEEX-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356472#comment-16356472 ] ASF GitHub Bot commented on WEEX-174: - GitHub user gubaojian reopened a pull request: https://github.com/apache/incubator-weex/pull/1019 [WEEX-174][android] TemplateList Support Lifecycle and statefull component [WEEX-174][android] TemplateList Support Lifecycle and statefull component You can merge this pull request into a Git repository by running: $ git pull https://github.com/gubaojian/incubator-weex release-0.17-template-list-second Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1019.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1019 commit 20c293f4a9c4c14daa0deee19b9d9b9a4b73693b Author: Zz Date: 2018-01-22T09:43:54Z #import==> #import commit 886d859ab75ef892aad50506dace5818c06b66d2 Author: jianbai.gbj Date: 2017-12-20T07:07:01Z [WEEX-174][android] TemplateList Support Lifecycle and statefull component commit 30ad3f6c0c13c635c0acdeb40a80f3064330248a Author: jianbai.gbj Date: 2018-02-08T04:01:44Z Merge remote-tracking branch 'origin/master_apache' into release-0.17-template-list-second # Conflicts: # android/sdk/src/main/java/com/taobao/weex/dom/action/UpdateAttributeAction.java > TemplateList Support Lifecycle and statefull component > -- > > Key: WEEX-174 > URL: https://issues.apache.org/jira/browse/WEEX-174 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: Adam Feng >Priority: Major > > TemplateList Support Lifecycle and statefull component -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-174) TemplateList Support Lifecycle and statefull component
[ https://issues.apache.org/jira/browse/WEEX-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356471#comment-16356471 ] ASF GitHub Bot commented on WEEX-174: - Github user gubaojian closed the pull request at: https://github.com/apache/incubator-weex/pull/1019 > TemplateList Support Lifecycle and statefull component > -- > > Key: WEEX-174 > URL: https://issues.apache.org/jira/browse/WEEX-174 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: Adam Feng >Priority: Major > > TemplateList Support Lifecycle and statefull component -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-174) TemplateList Support Lifecycle and statefull component
[ https://issues.apache.org/jira/browse/WEEX-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356464#comment-16356464 ] ASF GitHub Bot commented on WEEX-174: - Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1019 Fails :no_entry_sign: Code file android/playground/app/src/main/java/com/alibaba/weex/extend/module/WXWsonTestModule.java does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXCell.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXEvent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS > TemplateList Support Lifecycle and statefull component > -- > > Key: WEEX-174 > URL: https://issues.apache.org/jira/browse/WEEX-174 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: Adam Feng >Priority: Major > > TemplateList Support Lifecycle and statefull component -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-174) TemplateList Support Lifecycle and statefull component
[ https://issues.apache.org/jira/browse/WEEX-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356463#comment-16356463 ] ASF GitHub Bot commented on WEEX-174: - GitHub user gubaojian opened a pull request: https://github.com/apache/incubator-weex/pull/1019 [WEEX-174][android] TemplateList Support Lifecycle and statefull component [WEEX-174][android] TemplateList Support Lifecycle and statefull component You can merge this pull request into a Git repository by running: $ git pull https://github.com/gubaojian/incubator-weex release-0.17-template-list-second Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1019.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1019 commit 20c293f4a9c4c14daa0deee19b9d9b9a4b73693b Author: Zz Date: 2018-01-22T09:43:54Z #import==> #import commit 886d859ab75ef892aad50506dace5818c06b66d2 Author: jianbai.gbj Date: 2017-12-20T07:07:01Z [WEEX-174][android] TemplateList Support Lifecycle and statefull component commit 30ad3f6c0c13c635c0acdeb40a80f3064330248a Author: jianbai.gbj Date: 2018-02-08T04:01:44Z Merge remote-tracking branch 'origin/master_apache' into release-0.17-template-list-second # Conflicts: # android/sdk/src/main/java/com/taobao/weex/dom/action/UpdateAttributeAction.java > TemplateList Support Lifecycle and statefull component > -- > > Key: WEEX-174 > URL: https://issues.apache.org/jira/browse/WEEX-174 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: Adam Feng >Priority: Major > > TemplateList Support Lifecycle and statefull component -- This message was sent by Atlassian JIRA (v7.6.3#76005)
