That should take care of it. Thanks again,
Craig On Feb 12, 2018 04:27, "Sam Ruby" <ru...@intertwingly.net> wrote: > On Sun, Feb 11, 2018 at 8:21 PM, Craig Russell <apache....@gmail.com> > wrote: > > Better but not perfect. > > > > renamed existing icla > > added second icla2/icla.pdf and icla.pdf.asc > > updated iclas.txt with changed email address > > > > failed while updating public name in LDAP. of course there is no LDAP > entry so this step should not be done. Similarly, it should not attempt to > change the LDAP entry for email. > > > > And the ack message should omit: > > You can change your password using https://id.apache.org . > > > > So this icla is processed (manually sent email) but still needs a tweak. > > Tweaked: https://github.com/apache/whimsy/commit/ > 0c01352379c30375c18053b55eac8a1d0d71db3a > > > Thanks for hopping on this, Sam > > > > Craig > > - Sam Ruby > > >> On Feb 11, 2018, at 7:05 AM, Sam Ruby <ru...@intertwingly.net> wrote: > >> > >> On Sun, Feb 11, 2018 at 3:51 AM, Craig Russell <papa...@gmail.com> > wrote: > >>> Filing the second icla for Kamesh I encountered an exception. > >>> > >>> The original icla is a simple <name>.pdf. The second icla is signed > with icla.pdf and icla.pdf.asc. I suspect this is the problem. > >>> > >>> I can do this manually but I don't think there is a big rush. > >>> > >>> Craig > >>> > >>> #<NoMethodError: undefined method `legal_name' for nil:NilClass> > >> > >> The problem is that the ICLA wasn't found, so extracting the > >> legal_name from the ICLA fails. > >> > >> The ICLA wasn't found as it was attempted to be located by id, and > >> this individual is not a committer. > >> > >> I made a fix to match based on original email address too, and > >> improved the error message when it fails: > >> > >> https://github.com/apache/whimsy/commit/ecbacc3fa3e4be15bcf61e0de2d541 > e700f8fbb2 > >> > >> I've verified that this fixes the problem reported, but haven't tested > >> that the actual commit will succeed. > >> > >> - Sam Ruby > > > > Craig L Russell > > Secretary, Apache Software Foundation > > c...@apache.org http://db.apache.org/jdo > > >
