[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...

2017-08-06 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/229#discussion_r131541043 --- Diff: wicket-user-guide/src/main/asciidoc/introduction.adoc --- @@ -27,8 +26,7 @@ Editors: *Joachim Rohde* -*PS*: this guide is

[GitHub] wicket pull request #228: WICKET-6437: Library versions are updated

2017-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] wicket pull request #227: Fixes issue of pushing resources

2017-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] wicket pull request #226: Allow to set the rel attribute with CssHeaderItem

2017-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Using Gitbox

2017-08-06 Thread Maxim Solodovnik
We are using git at https://git-wip-us.apache.org/repos/asf/ and it seems to produce less emails ... On Sun, Aug 6, 2017 at 7:52 PM, Martin Grigorov wrote: > Hi devs, > > As you may have noticed merging PRs from GitHub creates a lot of email and > git history noise. > >

Re: Using Gitbox

2017-08-06 Thread Martin Grigorov
This is what Wicket uses now. It didn't happen to you because you haven't merged PRs from GitHub. See https://gitbox.apache.org. although it is not well documented yet. On Aug 6, 2017 8:33 PM, "Maxim Solodovnik" wrote: > We are using git at

[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...

2017-08-06 Thread ozeray
Github user ozeray commented on the issue: https://github.com/apache/wicket/pull/229 Implemented Martin's diff request. Made some more improvements on 8.x reference documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...

2017-08-06 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/224 The PR has been merged to Wicket 8 (master). @disblader Please close it because we do not own this repo. Thank you! --- If your project is set up for it, you can reply to this email and

[GitHub] wicket issue #227: Fixes issue of pushing resources

2017-08-06 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/227 Thanks again @martin-g 😊 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] wicket issue #226: Allow to set the rel attribute with CssHeaderItem

2017-08-06 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/226 Thanks a lot @martin-g!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: Wicket 8 (M7) release

2017-08-06 Thread Maxim Solodovnik
As far as I can see nothing blocks the release +1 :) On Mon, Aug 7, 2017 at 12:25 AM, Andrea Del Bene wrote: > I guess now we are ready to start the release of M7, right? > > > On 05/08/2017 17:12, Maxim Solodovnik wrote: >> >> https://github.com/apache/wicket/pull/228 >>