Re: FYI

2019-10-08 Thread Andrea Del Bene
Great! Thank you Martin! On Tue, Oct 8, 2019 at 5:10 AM Martin Grigorov wrote: > On Mon, Oct 7, 2019, 16:33 Martin Grigorov wrote: > > > I've found a workaround: execute `mvn clean javadoc:aggregate` as a > > separate step after `mvn deploy` > > > > In r1051190 at > > >

Re: FYI

2019-10-08 Thread Maxim Solodovnik
Great news :) On Tue, 8 Oct 2019 at 14:41, Andrea Del Bene wrote: > Great! Thank you Martin! > > On Tue, Oct 8, 2019 at 5:10 AM Martin Grigorov > wrote: > > > On Mon, Oct 7, 2019, 16:33 Martin Grigorov wrote: > > > > > I've found a workaround: execute `mvn clean javadoc:aggregate` as a > > >

[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#discussion_r332809966 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#discussion_r332809767 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

[GitHub] [wicket] dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM

2019-10-08 Thread GitBox
dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM URL: https://github.com/apache/wicket/pull/386#discussion_r332837909 ## File path:

[GitHub] [wicket] dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM

2019-10-08 Thread GitBox
dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM URL: https://github.com/apache/wicket/pull/386#discussion_r332837909 ## File path:

[GitHub] [wicket] martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM

2019-10-08 Thread GitBox
martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM URL: https://github.com/apache/wicket/pull/386#discussion_r332831622 ## File path:

[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#discussion_r332819559 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

[GitHub] [wicket] martin-g commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
martin-g commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#discussion_r332830868 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-539800079 > If every JS snippet is ending up as a header item anyway, why not remove and from the Ajax response and transport

[GitHub] [wicket] martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM

2019-10-08 Thread GitBox
martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM URL: https://github.com/apache/wicket/pull/386#discussion_r332838963 ## File path:

[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#discussion_r331840246 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#discussion_r332807766 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

[GitHub] [wicket] martin-g commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
martin-g commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-539834141 Sounds good to me! In this case there won't be a need for ``