Looking at the examples, I think the packaging currently is wrong. The
examples package weld (cdi implementation), but rely on a provided
cdi-api. The cdi-api should simply be added as a compile dependency to
the examples.
Emond
On Fri, Mar 13, 2020 at 2:59 AM Maxim Solodovnik wrote:
>
> Maybe
On Fri, Mar 13, 2020 at 10:22 AM Emond Papegaaij
wrote:
> Looking at the examples, I think the packaging currently is wrong. The
> examples package weld (cdi implementation), but rely on a provided
> cdi-api. The cdi-api should simply be added as a compile dependency to
> the examples.
>
I've
Hi Sven,
I've reread the spec a bit more precise last night. I think we can
change the code to only set the header on a RenderPageRequestHandler.
The CSP is taken from the page and applies to all resources loaded by
that page. The only exceptions are child-contexts: iframes, objects
and
Hello Edmond,
It seems you accidentally re-format license header ...
On Fri, 13 Mar 2020 at 15:44, wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> papegaaij pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/wicket.git
>
>
>
Yes, you are right. Martin beat me in fixing it :) The file had some
formatting issues, so I pressed Ctrl-Shift-F, forgot about the
license.
Emond
On Fri, Mar 13, 2020 at 10:03 AM Maxim Solodovnik wrote:
>
> Hello Edmond,
>
> It seems you accidentally re-format license header ...
>
> On Fri, 13
I've changed the code. From what I can see, the header is now only set
once per request. It could be there some exceptions to this, for
example when the request is restarted during rendering. IMHO that's
not a big issue, because the header is still added only once.
I've also added a demo-case to
Just ring the bell when you feel ready for a new build :-)
On 3/12/20 12:13 PM, Sven Meier wrote:
Hi,
I don't care about the method name, so I reverted it to
#getCspSettings().
AFAIKS the documentation stays valid in that case?
Have fun
Sven
On 12.03.20 09:42, Emond Papegaaij wrote:
Hi,
On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov
wrote:
> Hi Sven,
>
>
>
>
>
> /* rule from the application that should be used when the
> element is visible */
> div {
> display: flex;
> margin-bottom: 200px;
> }
Hi Sven,
/* rule from the application that should be used when the
element is visible */
div {
display: flex;
margin-bottom: 200px;
}
/* Rule coming from wicket-core.css */
.wicket--hidden
Additional note:
Bootstrap has following CSS
[hidden] {
display: none !important;
}
which makes life much more diffiicult ...
On Fri, 13 Mar 2020 at 21:17, Martin Grigorov wrote:
>
> On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov
> wrote:
>
> > Hi Sven,
> >
> >
> >
> >
> >
Thanks Martin,
one additional nitpick from me in the commit below.
At least we have this topic off the table ;)
Sven
On 13.03.20 19:44, svenme...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
svenmeier pushed a commit to branch master
in repository
Oh dear - why devs don’t stop using !important - it is so hard to customize it
by use more specific selectors... anyway - as long as the css are clear and
simple to support functions of the backend they are ok. Users can even
customize them. display: none to hide something is simple and clear
Awesome!
Thank you, Sven!
On Fri, Mar 13, 2020 at 8:46 PM Sven Meier wrote:
> Thanks Martin,
>
> one additional nitpick from me in the commit below.
>
> At least we have this topic off the table ;)
>
> Sven
>
> On 13.03.20 19:44, svenme...@apache.org wrote:
> > This is an automated email from
13 matches
Mail list logo
