[GitHub] [wicket] ams-tschoening commented on issue #414: WICKET-6756: Avoid "URL.getFile()" when expecting file system paths.

ams-tschoening commented on issue #414: WICKET-6756: Avoid "URL.getFile()" when expecting file system paths. URL: https://github.com/apache/wicket/pull/414#issuecomment-601578336 This seems to have been merged:

[GitHub] [wicket] ams-tschoening closed pull request #414: WICKET-6756: Avoid "URL.getFile()" when expecting file system paths.

ams-tschoening closed pull request #414: WICKET-6756: Avoid "URL.getFile()" when expecting file system paths. URL: https://github.com/apache/wicket/pull/414 This is an automated message from the Apache Git Service. To

[GitHub] [wicket] ams-tschoening closed pull request #415: WICKET-6757: Avoid URL.getFile during mime type detection.

ams-tschoening closed pull request #415: WICKET-6757: Avoid URL.getFile during mime type detection. URL: https://github.com/apache/wicket/pull/415 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] ams-tschoening commented on issue #415: WICKET-6757: Avoid URL.getFile during mime type detection.

ams-tschoening commented on issue #415: WICKET-6757: Avoid URL.getFile during mime type detection. URL: https://github.com/apache/wicket/pull/415#issuecomment-601578501 This seems to have been merged: https://github.com/apache/wicket/commit/f1bd38690674be5578fc5c5e1c28cc81cdb7ae76

Re: WICKET-6725 styling of hidden elements: no vote yet

Hi Sven, What about wicket--hidden-fields ? We still need wicket-core.css for it. Martin On Wed, Mar 18, 2020 at 11:25 PM Sven Meier wrote: > Hi all, > > I've built an example to better demonstrate my argument: > > a) "hidden" tags work fine out-of-the-box :) > >

[GitHub] [wicket] theigl opened a new pull request #416: WICKET-6759 Support disabling error notification for websockets

theigl opened a new pull request #416: WICKET-6759 Support disabling error notification for websockets URL: https://github.com/apache/wicket/pull/416 This PR adds a function `shouldNotifyOnErrorEvent` to `WebSocketSettings` that allows the user the decide which types of websocket errors

[GitHub] [wicket] martin-g commented on issue #416: WICKET-6759 Support disabling error notification for websockets

martin-g commented on issue #416: WICKET-6759 Support disabling error notification for websockets URL: https://github.com/apache/wicket/pull/416#issuecomment-601684876 Thank you, @theigl ! This is an automated message from

[GitHub] [wicket] martin-g merged pull request #416: WICKET-6759 Support disabling error notification for websockets

martin-g merged pull request #416: WICKET-6759 Support disabling error notification for websockets URL: https://github.com/apache/wicket/pull/416 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] theigl commented on issue #411: WICKET-6751 Page synchronizer strategies

theigl commented on issue #411: WICKET-6751 Page synchronizer strategies URL: https://github.com/apache/wicket/pull/411#issuecomment-601627779 @svenmeier : Hi. Since Martin already approved this, could you please take another look? I'd really like to see this merged at some point.

Re: WICKET-6725 styling of hidden elements: no vote yet

In this case I am fine to go with 'hidden'. We can introduce wicket-core.css later if needed. On Fri, Mar 20, 2020 at 1:44 PM Sven Meier wrote: > Hi Martin, > > these stylings? > > width: 0px; > height: 0px; > position: absolute; > left: -100px; > top: -100px; >

[GitHub] [wicket] theigl opened a new pull request #417: WICKET-6761 Multiple websocket connections from the same session

theigl opened a new pull request #417: WICKET-6761 Multiple websocket connections from the same session URL: https://github.com/apache/wicket/pull/417 This PR adds an optional `resourceToken` to `BaseWebSocketBehavior` to support multiple websocket connections from the same session, i.e.

[GitHub] [wicket] martin-g commented on a change in pull request #417: WICKET-6761 Multiple websocket connections from the same session

martin-g commented on a change in pull request #417: WICKET-6761 Multiple websocket connections from the same session URL: https://github.com/apache/wicket/pull/417#discussion_r395963529 ## File path:

[GitHub] [wicket] martin-g commented on a change in pull request #417: WICKET-6761 Multiple websocket connections from the same session

martin-g commented on a change in pull request #417: WICKET-6761 Multiple websocket connections from the same session URL: https://github.com/apache/wicket/pull/417#discussion_r395963983 ## File path: