Re: Stable behavior ids

2020-05-07 Thread Martin Grigorov
Hi Emond, The behavior id is something internal to Wicket. It is used *by* Wicket to find the requested behavior in a Component. For example if a Component has more than one Ajax behaviors (yes, Ajax behaviors could be stateless too since 7.4.0. Before that there was a project in WicketStuff) it

Re: Stable behavior ids

2020-05-07 Thread Emond Papegaaij
Hi Martin, I know what these id's are for, and this still works as expected. However, your claim about stable id's on stateless pages currently does not work as you describe. The id's of behaviors is stored in the component they are added to, also when the component is stateless. As you said, a

Re: Stable behavior ids

2020-05-07 Thread Sven Meier
Hi, we have a test for stateless behaviors: org.apache.wicket.ajax.markup.html.form.StatelessAjaxSubmitLinkTest We should just make sure it still works. Have fun Sven On 07.05.20 12:13, Andrea Del Bene wrote: On 07/05/20 10:37, Emond Papegaaij wrote: Hi Martin, I know what these id's

Re: Stable behavior ids

2020-05-07 Thread Andrea Del Bene
On 07/05/20 10:37, Emond Papegaaij wrote: Hi Martin, I know what these id's are for, and this still works as expected. However, your claim about stable id's on stateless pages currently does not work as you describe. The id's of behaviors is stored in the component they are added to, also

[GitHub] [wicket] papegaaij commented on pull request #432: WICKET-6774: minor change to contract of Component.getBehaviorId

2020-05-07 Thread GitBox
papegaaij commented on pull request #432: URL: https://github.com/apache/wicket/pull/432#issuecomment-625122298 > Please do not merge this PR until we are clear on the way this is supposed to work. > https://markmail.org/message/p4cnvfypzprrl2qt Agreed, that's why I created a PR

Re: ConcurrentHashSet to be removed from wicket code base

2020-05-07 Thread Maxim Solodovnik
Hello Martijn, On Thu, 7 May 2020 at 19:02, Martijn Dashorst wrote: > IIRC Micromap was created for serialization and memory efficiency. Has that > changed? > >From what I can see using "so to declaration" in JDK11 Map.of(key, value) returns static final class Map1 extends

Re: ConcurrentHashSet to be removed from wicket code base

2020-05-07 Thread Martin Grigorov
On Thu, May 7, 2020 at 3:02 PM Martijn Dashorst wrote: > IIRC Micromap was created for serialization and memory efficiency. Has that > changed? > Java 9+ has Map.of(k, v) method that uses java.util.ImmutableCollections.Map1 and it is quite optimized. I think the replacement is good! > >

Re: Stable behavior ids

2020-05-07 Thread Emond Papegaaij
Hi Sven and Andrea, Sven: All tests still pass, I've also updated the ImmutableBehaviorIdsTest with some additional checks. However, the tests I've seen so far are not very exhaustive on this part. Many of them also pass with a bit of luck :) Andrea: What I mean with 'moved to the front' is that

Re: ConcurrentHashSet to be removed from wicket code base

2020-05-07 Thread Martijn Dashorst
IIRC Micromap was created for serialization and memory efficiency. Has that changed? Martijn On Wed, May 6, 2020 at 2:18 PM Maxim Solodovnik wrote: > MicroMap can easily be replaced with Map.of(key, value) > > I can deprecate it for wicket9 in same PR, should I? > > On Wed, 6 May 2020 at

Re: Stable behavior ids

2020-05-07 Thread Emond Papegaaij
Hi all, I've updated my pull request at https://github.com/apache/wicket/pull/432 . I've added the method I described and changed the current code to use this new method. Also, the documentation is updated and clarified to better reflect the rules a developer has to follow to keep stable ids.

Re: Stable behavior ids

2020-05-07 Thread Sven Meier
Hi Emond, I'm not happy with that method. It's one additional method like many others in Wicket which are not clear what they are good for. I didn't understand the description. What's the reason for this stable id hassle? Why can't the id be stable when a behavior wants it? Is this really

[GitHub] [wicket] solomax commented on pull request #431: [WICKET-6783] ConcurrentHashSet is removed

2020-05-07 Thread GitBox
solomax commented on pull request #431: URL: https://github.com/apache/wicket/pull/431#issuecomment-625590130 @martin-g It seems I don't have permission to edit this page :( This is an automated message from the Apache Git

[GitHub] [wicket] martin-g commented on pull request #431: [WICKET-6783] ConcurrentHashSet is removed

2020-05-07 Thread GitBox
martin-g commented on pull request #431: URL: https://github.com/apache/wicket/pull/431#issuecomment-625638361 Access granted! This is an automated message from the Apache Git Service. To respond to the message, please log