[GitHub] [wicket] theigl opened a new pull request #433: WICKET-6788 Improve performance of markup escaping

2020-05-24 Thread GitBox
theigl opened a new pull request #433: URL: https://github.com/apache/wicket/pull/433 Checks for `Character.UNASSIGNED` instead of looking up non-chars in a set. This solution more than doubles the throughput: ``` escapeMarkupHashSetthrpt5 395348,174 ±

Make ComponentRenderer implement AutoCloseable?

2020-05-24 Thread Thorsten Schöning
Hi all, I'm using Wicket as a template engine to render reports in some backend with various different output formats. Everything is based on "ComponentRenderer", though, and that introduced a large memory leak in my case. Root cause simply was that I forgot to call "destroy". So how about

'base-uri' CSP directive is missing

2020-05-24 Thread Maxim Solodovnik
Hello Edmond, It seems 'base-uri' directive [1] is missing is "enum CSPDirective" Is it on purpose? One of our users check current rules using some validator [2] [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri [2]

[GitHub] [wicket] solomax opened a new pull request #434: [WICKET-6789] 'base-uri' is added to CSPDirective enum

2020-05-24 Thread GitBox
solomax opened a new pull request #434: URL: https://github.com/apache/wicket/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: 'base-uri' CSP directive is missing

2020-05-24 Thread Maxim Solodovnik
Hello Emond, I'll create PR :) Sorry I misspelled your name :( (from mobile, sorry for typos) On Sun, May 24, 2020, 21:31 Maxim Solodovnik wrote: > Hello Edmond, > > It seems 'base-uri' directive [1] is missing is "enum CSPDirective" > Is it on purpose? > > One of our users check current

Re: Make ComponentRenderer implement AutoCloseable?

2020-05-24 Thread Sven Meier
Hi Thorsten, ComponentRender#destroy() destroys the application, there's not much more to it. In most cases you will want to reuse the application for performance reasons. A specific application can even be used as constructor argument, which might be the main web application that you don't