[GitHub] [wicket] martin-g commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433122027 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

[GitHub] [wicket] martin-g commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433122027 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

[GitHub] [wicket] martin-g commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433122027 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

[GitHub] [wicket] theigl commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
theigl commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433136846 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

Re: Questions regarding development workflow

2020-06-01 Thread Martin Grigorov
Hi, On Sun, May 31, 2020 at 2:17 PM Andrea Del Bene wrote: > Hi Thomas! > > On 30/05/20 18:52, Thomas Heigl wrote: > > Hi all, > > > > Do we have any guidelines regarding the development workflow? E.g. > > > > - How many approvals do I need for merging a PR? > PR approvals on GitHub is a

[GitHub] [wicket] martin-g commented on a change in pull request #436: WICKET-6794 Performance improvements for UrlEncoder and UrlDecoder

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #436: URL: https://github.com/apache/wicket/pull/436#discussion_r433114761 ## File path: wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlEncoder.java ## @@ -16,58 +16,140 @@ */ package

[GitHub] [wicket] martin-g commented on a change in pull request #436: WICKET-6794 Performance improvements for UrlEncoder and UrlDecoder

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #436: URL: https://github.com/apache/wicket/pull/436#discussion_r433114445 ## File path: wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java ## @@ -16,25 +16,25 @@ */ package

[GitHub] [wicket] theigl commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
theigl commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433144531 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

[GitHub] [wicket] theigl commented on a change in pull request #436: WICKET-6794 Performance improvements for UrlEncoder and UrlDecoder

2020-06-01 Thread GitBox
theigl commented on a change in pull request #436: URL: https://github.com/apache/wicket/pull/436#discussion_r433134378 ## File path: wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java ## @@ -16,25 +16,25 @@ */ package

[GitHub] [wicket] martin-g commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433322930 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

[GitHub] [wicket] theigl commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
theigl commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433374344 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

[GitHub] [wicket] martin-g commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
martin-g commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433162126 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

Re: Questions regarding development workflow

2020-06-01 Thread Thomas Heigl
> > Now I checked the GitHub Actions docs ( > https://help.github.com/en/actions/reference/events-that-trigger-workflows > ) > and added support for Pull Requests. > Since we have .github/workflows only in master branch it won't trigger any > builds for 8.x, 7.x, ... If we want this then we have

[GitHub] [wicket] theigl commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

2020-06-01 Thread GitBox
theigl commented on a change in pull request #437: URL: https://github.com/apache/wicket/pull/437#discussion_r433166508 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java ## @@ -119,11 +119,16 @@ protected void

Re: Questions regarding development workflow

2020-06-01 Thread Martin Grigorov
On Mon, Jun 1, 2020 at 3:40 PM Thomas Heigl wrote: > > > > Now I checked the GitHub Actions docs ( > > > https://help.github.com/en/actions/reference/events-that-trigger-workflows > > ) > > and added support for Pull Requests. > > Since we have .github/workflows only in master branch it won't

Re: Questions regarding development workflow

2020-06-01 Thread Martin Grigorov
On Mon, Jun 1, 2020 at 1:10 PM Thomas Heigl wrote: > Thanks for the infos Andrea and Martin! I think that answers all my > questions. > > The official CI tool is BuildBot but since recently we also added GitHub > > Actions since it comes for free (i.e. any maintenance from us). > > At the moment

Re: Questions regarding development workflow

2020-06-01 Thread Thomas Heigl
Thanks for the infos Andrea and Martin! I think that answers all my questions. The official CI tool is BuildBot but since recently we also added GitHub > Actions since it comes for free (i.e. any maintenance from us). > At the moment it builds only master branch but we can remove this >