[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-27 Thread GitBox
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-477232378 @mattrpav can you check if `cglib-nodep+latest_asm` will work as expected and update your PR?

[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-27 Thread GitBox
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-477249580 Yep, will do This is an automated message from the Apache Git Service. To

[GitHub] [wicket] martin-g commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
martin-g commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476773719 :+1: if everything still works ! This is an automated message from the Apache

[GitHub] [wicket] mattrpav opened a new pull request #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
mattrpav opened a new pull request #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748823 @mattrpav PR with the link to JIRA is perfectly fine :) You did everything right :)

[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476743542 @mattrpav I got build error with this change: ``` WARNING] Dependency convergence error for org.ow2.asm:asm:7.0 paths to dependency

[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476750648 There is a cglib-nodep that wicket-ioc could depend on, and then inherit the asm dependency (which is used by other wicket modules). Q:

[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476751902 I would say `cglib-nodep` is better option since we have `asm` as separate dependency ... @martin-g, @svenmeier, @bitstorm WDYT?

[GitHub] [wicket] mattrpav opened a new pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x

2019-03-26 Thread GitBox
mattrpav opened a new pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x URL: https://github.com/apache/wicket/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748019 @solomax what is the preferred workflow for patches? This is an automated

[GitHub] [wicket] mattrpav edited a comment on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
mattrpav edited a comment on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748019 @solomax re the wicket-8.x patch-- what is the preferred workflow for patches? Do you merge PR's from here or other?

[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-26 Thread GitBox
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476747443 @solomax apologies for the build warn. I created this PR to see if there was some CI/CD tied to Wicket's PR's. This is a simple fix to exclude

[GitHub] [wicket] solomax opened a new pull request #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax opened a new pull request #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351 This is an automated message from the Apache Git Service. To respond

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479948236 I'll add, should be easy :) This is an automated

[GitHub] [wicket] martin-g commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
martin-g commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479947955 How much effort is to add an example usage with WebSockets to wicket-examples > WebSockets demo ?

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479955654 @martin-g it seems `mvn jetty:run` is not working in `wicket-examples`, how are you running it for quick tests?

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479963931 `mvn jetty:run-exploded` seems to work :) This is an

[GitHub] [wicket] martin-g commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-05 Thread GitBox
martin-g commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-480159091 I use `StartExamples#main()` in the IDE. It is much easier to debug and use HotSwap code replace (no need to restart,

[GitHub] [wicket] solomax commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-05 Thread GitBox
solomax commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#discussion_r272464222 ## File path:

[GitHub] [wicket] martin-g commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-05 Thread GitBox
martin-g commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#discussion_r272461990 ## File path:

[GitHub] [wicket] martin-g opened a new pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-05 Thread GitBox
martin-g opened a new pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352 … Text/BinaryMessage and in IWebSocketConnection Downport of 12b1fb227564c22f4887dea23610be7cb8c5d977 for Wicket 8.x. It

[GitHub] [wicket] reiern70 commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-05 Thread GitBox
reiern70 commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#discussion_r272477274 ## File path:

[GitHub] [wicket] martin-g commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-05 Thread GitBox
martin-g commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#discussion_r272478938 ## File path:

[GitHub] [wicket] reiern70 commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-05 Thread GitBox
reiern70 commented on a change in pull request #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#discussion_r272485506 ## File path:

[GitHub] [wicket] martin-g closed pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x

2019-03-28 Thread GitBox
martin-g closed pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x URL: https://github.com/apache/wicket/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] martin-g commented on issue #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x

2019-03-28 Thread GitBox
martin-g commented on issue #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x URL: https://github.com/apache/wicket/pull/350#issuecomment-477525601 The change will be cherry-picked from `master` branch. No need of this PR. Thank you, @mattrpav !

[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

2019-03-27 Thread GitBox
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-477420384 My local build is hanging on wicket-core with the test below: > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-08 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-480915022 Is it OK to merge this PR? This is an automated

[GitHub] [wicket] bitstorm commented on issue #283: Wicket-6563 page store implementation

2019-03-04 Thread GitBox
bitstorm commented on issue #283: Wicket-6563 page store implementation URL: https://github.com/apache/wicket/pull/283#issuecomment-469206921 Piiing! :-) This is an automated message from the Apache Git Service. To respond to

[GitHub] [wicket] andreikondratev commented on issue #347: Add more modal customizations

2019-03-03 Thread GitBox
andreikondratev commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-469095284 Hi! Is this change got stuck? Should I do anything to proceed? This is an automated

[GitHub] [wicket] martin-g commented on issue #347: Add more modal customizations

2019-03-04 Thread GitBox
martin-g commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-469550169 Thank you, @andruhon ! This is an automated message from the Apache Git Service. To respond

[GitHub] [wicket] martin-g commented on issue #347: Add more modal customizations

2019-03-04 Thread GitBox
martin-g commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-469549730 https://issues.apache.org/jira/browse/WICKET-6640 This is an automated message from the

[GitHub] [wicket] martin-g merged pull request #347: Add more modal customizations

2019-03-04 Thread GitBox
martin-g merged pull request #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [wicket] martin-g commented on issue #347: Add more modal customizations

2019-03-04 Thread GitBox
martin-g commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-469549206 I will create a ticket in JIRA for this PR and merge it. This is an automated message from

[GitHub] [wicket] tiagostn opened a new pull request #348: WICKET-6642 Form.findSubmittingComponent always returns null

2019-03-05 Thread GitBox
tiagostn opened a new pull request #348: WICKET-6642 Form.findSubmittingComponent always returns null URL: https://github.com/apache/wicket/pull/348 Form.findSubmittingComponent expects a request parameter with the wicket id of the submitting component. So I just add that to the

[GitHub] [wicket] andreikondratev commented on issue #347: Add more modal customizations

2019-03-06 Thread GitBox
andreikondratev commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-470299287 Should I next time create a jira ticket for change like this? This is an automated

[GitHub] [wicket] solomax commented on issue #347: Add more modal customizations

2019-03-06 Thread GitBox
solomax commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-470342154 @andreikondratev JIRA tickets helps to create release notes So, I believe, it will speed up things

[GitHub] [wicket] tiagostn closed pull request #348: WICKET-6642 Form.findSubmittingComponent always returns null

2019-03-11 Thread GitBox
tiagostn closed pull request #348: WICKET-6642 Form.findSubmittingComponent always returns null URL: https://github.com/apache/wicket/pull/348 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] martin-g commented on issue #347: Add more modal customizations

2019-03-06 Thread GitBox
martin-g commented on issue #347: Add more modal customizations URL: https://github.com/apache/wicket/pull/347#issuecomment-470397486 Yes, most users don't read the git commit history to see what's new in a release. Wicket distributions (.tar.gz and .zip) contain RELEASE_NOTES file with

[GitHub] [wicket] asfgit closed pull request #283: Wicket-6563 page store implementation

2019-03-19 Thread GitBox
asfgit closed pull request #283: Wicket-6563 page store implementation URL: https://github.com/apache/wicket/pull/283 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] solomax commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
solomax commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482018642 Hello @martin-g, The original request was to simplify message sending to some "subset" of websocket connections

[GitHub] [wicket] martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482020393 I understood the request as: `make the Application, Session and IKey available in TextMessage, BinaryMessage and

[GitHub] [wicket] martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482024698 > As requester of this feature if there is any risk of breaking existing application I would prefer to use some

[GitHub] [wicket] reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482056433 > Hello @martin-g, > The original request was to simplify message sending to some "subset" of websocket

[GitHub] [wicket] martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482016572 Any more opinions ? Should we merge this PR or you think it might break user applications ?

[GitHub] [wicket] reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482020794 @martin-g As requester of this feature if there is any risk of breaking existing application I would

[GitHub] [wicket] reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482020970 > I understood the request as: `make the Application, Session and IKey available in TextMessage, BinaryMessage and

[GitHub] [wicket] martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…

2019-04-11 Thread GitBox
martin-g commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482084027 That's correct! This is an automated message from

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-15 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492684806 Hi Igor, > my only word of caution is that a big reason why the old modal window was such a mess and so hard to maintain is

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-15 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492696234 Regarding the location of the dialog in the DOM - in case of a dialog nested inside a form, a page refresh produces invalid markup with

[GitHub] [wicket] andreikondratev edited a comment on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andreikondratev edited a comment on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493281600 Mi Martin! I think it's redundant to add this support. They failed just because OnChangeAjaxBehavior hasn't been replaced.

[GitHub] [wicket] martin-g commented on issue #363: Convert wicket ajax to typescript

2019-05-16 Thread GitBox
martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493289448 I am +1 but others didn't give their opinion yet. Let's discuss at dev@ first before wasting your time. On Fri, May 17, 2019, 04:43 Andrew

[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript

2019-05-16 Thread GitBox
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493289708 > dev@ @martin-g do you refer to the dev@wicket.apache.org mail list? This is an

[GitHub] [wicket] andreikondratev commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andreikondratev commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493281600 Mi Martin! I think it's redundant to add this support. They failed just because OnChangeAjaxBehavior hasn't been replaced.

[GitHub] [wicket] andruhon commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andruhon commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493267814 I injected this JS into our wicket 7.10 application and send it to our build server to see how Selenium UI tests run. passed: 1915 tests, failed 8. All 8

[GitHub] [wicket] andruhon commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andruhon commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493286672 I think this behaviour was broken before wicket cleanup http://examples8x.wicket.apache.org/ajax/on-change-ajax-behavior Very similar thing is broken

[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript

2019-05-16 Thread GitBox
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493288087 It seems to work pretty well. Should I continue and try adding a WICKET-6667 #359 into this one?

[GitHub] [wicket] andreikondratev commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andreikondratev commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493267682 I injected this JS into our wicket 7.10 application and send it to our build server to see how Selenium UI tests run. passed: 1915 tests, failed

[GitHub] [wicket] andreikondratev removed a comment on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andreikondratev removed a comment on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493267682 I injected this JS into our wicket 7.10 application and send it to our build server to see how Selenium UI tests run. passed: 1915 tests,

[GitHub] [wicket] martin-g commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
martin-g commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493281094 Hi Andrew, You will have to update your tests to trigger "input" event instead of "inputchange" event. Maybe we should provide support for

[GitHub] [wicket] ivaynberg commented on issue #363: Convert wicket ajax to typescript

2019-05-16 Thread GitBox
ivaynberg commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493290593 i am +1 on this as long as it is committed in such a way that git log --follow will stick pick up the history of the old js files..

[GitHub] [wicket] martin-g merged pull request #362: update Dockerfile to point to tomcat:9.0-jre11

2019-05-13 Thread GitBox
martin-g merged pull request #362: update Dockerfile to point to tomcat:9.0-jre11 URL: https://github.com/apache/wicket/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [wicket] andruhon opened a new pull request #362: update Dockerfile to point to tomcat:9.0-jre11

2019-05-12 Thread GitBox
andruhon opened a new pull request #362: update Dockerfile to point to tomcat:9.0-jre11 URL: https://github.com/apache/wicket/pull/362 As it was suggested in #360 by @solomax I tried to point to Tomcat 9 and it worked well.

[GitHub] [wicket] andruhon commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-15 Thread GitBox
andruhon commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492849181 Another concern is a presence of jQuery. It doesn't do much here now. As far as I remember Wicket has dropped support for IE9 and IE10 in

[GitHub] [wicket] svenmeier closed pull request #359: WICKET-6667 Wicket js cleanup

2019-05-15 Thread GitBox
svenmeier closed pull request #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [wicket] svenmeier commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-15 Thread GitBox
svenmeier commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-492829796 Thanks to all! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] solomax commented on a change in pull request #364: Improve OnChangeAjaxBehavior demo

2019-05-16 Thread GitBox
solomax commented on a change in pull request #364: Improve OnChangeAjaxBehavior demo URL: https://github.com/apache/wicket/pull/364#discussion_r284974403 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/OnChangeAjaxBehaviorPage.java ##

[GitHub] [wicket] andruhon commented on issue #359: WICKET-6667 Wicket js cleanup

2019-05-16 Thread GitBox
andruhon commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493314105 Ah, sorry. The demo works, it just a bit misleading without looking at the code. Created a PR to make it more obvious: #364

[GitHub] [wicket] martin-g commented on issue #363: Convert wicket ajax to typescript

2019-05-16 Thread GitBox
martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493321548 > @martin-g do you refer to the [dev@wicket.apache.org](mailto:dev@wicket.apache.org) mail list? Yes.

[GitHub] [wicket] andruhon opened a new pull request #364: Improve OnChangeAjaxBehavior demo

2019-05-16 Thread GitBox
andruhon opened a new pull request #364: Improve OnChangeAjaxBehavior demo URL: https://github.com/apache/wicket/pull/364 The demo was misleading. I thought it will just display what I typed in the label, I typed 555 and though it's broken. Updated the demo to be more obvious.

[GitHub] [wicket] martin-g merged pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-06-03 Thread GitBox
martin-g merged pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/366 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] reiern70 closed pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 closed pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289284232 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxSelfUpdatingTimerBehavior.java

[GitHub] [wicket] solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289291766 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289291339 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289285966 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on issue #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on issue #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#issuecomment-497608376 @solomax Thanks for review. Added deprecated to constructors. Also rebased + squashed commits.

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289292539 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289304509 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289284735 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289292242 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289325049 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] solomax merged pull request #364: Improve OnChangeAjaxBehavior demo

2019-05-30 Thread GitBox
solomax merged pull request #364: Improve OnChangeAjaxBehavior demo URL: https://github.com/apache/wicket/pull/364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [wicket] andruhon commented on issue #364: Improve OnChangeAjaxBehavior demo

2019-05-30 Thread GitBox
andruhon commented on issue #364: Improve OnChangeAjaxBehavior demo URL: https://github.com/apache/wicket/pull/364#issuecomment-497557712 Hi Colleagues! What's up with this one? This is an automated message from the Apache

[GitHub] [wicket] solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-30 Thread GitBox
solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289242314 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxSelfUpdatingTimerBehavior.java

[GitHub] [wicket] solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-30 Thread GitBox
solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289242355 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-30 Thread GitBox
solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289242295 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java

[GitHub] [wicket] reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r28933 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 commented on issue #366: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on issue #366: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/366#issuecomment-497658775 It seems some files have LR and other CRLF. This is an

[GitHub] [wicket] solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
solomax commented on a change in pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365#discussion_r289334597 ## File path: wicket-util/src/main/java/org/apache/wicket/util/time/Duration.java ## @@

[GitHub] [wicket] reiern70 opened a new pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 opened a new pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/366 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] reiern70 commented on issue #366: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-31 Thread GitBox
reiern70 commented on issue #366: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/366#issuecomment-497659549 @solomax Thanks. This is an automated message from

[GitHub] [wicket] reiern70 opened a new pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-05-30 Thread GitBox
reiern70 opened a new pull request #365: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/365 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] kgeis opened a new pull request #369: fix spelling in forms2_9.adoc

2019-06-06 Thread GitBox
kgeis opened a new pull request #369: fix spelling in forms2_9.adoc URL: https://github.com/apache/wicket/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [wicket] svenmeier commented on issue #368: Wicket 6673 priority ordering

2019-06-07 Thread GitBox
svenmeier commented on issue #368: Wicket 6673 priority ordering URL: https://github.com/apache/wicket/pull/368#issuecomment-499952356 Previously both components and behaviors were tracked, to be able to keep PriorityHeaderItems inside each base in their original order. With my proposal

[GitHub] [wicket] martin-g merged pull request #369: fix spelling in forms2_9.adoc

2019-06-07 Thread GitBox
martin-g merged pull request #369: fix spelling in forms2_9.adoc URL: https://github.com/apache/wicket/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [wicket] martin-g commented on issue #369: fix spelling in forms2_9.adoc

2019-06-07 Thread GitBox
martin-g commented on issue #369: fix spelling in forms2_9.adoc URL: https://github.com/apache/wicket/pull/369#issuecomment-500098752 Thank you, @kgeis ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [wicket] jmewes commented on issue #367: Remove usage of deprecated method from test example

2019-06-01 Thread GitBox
jmewes commented on issue #367: Remove usage of deprecated method from test example URL: https://github.com/apache/wicket/pull/367#issuecomment-497956898 @bitstorm Welcome! This is an automated message from the Apache Git

[GitHub] [wicket] martin-g commented on a change in pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-06-01 Thread GitBox
martin-g commented on a change in pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/366#discussion_r289608377 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java

[GitHub] [wicket] martin-g commented on a change in pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer

2019-06-01 Thread GitBox
martin-g commented on a change in pull request #366: WICKET-6672: restore use of wicket Duration for Ajax timer URL: https://github.com/apache/wicket/pull/366#discussion_r289608406 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxSelfUpdatingTimerBehavior.java

  1   2   3   4   5   6   7   8   9   >