[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493794645 Closing this PR because it has been decided to not proceed with these changes. A permalink to mail list discussion as a reference. https://lists.apache.org/thread.html/0b5b1fff59b1a448987c1da7f5a91e8942a6cd4ef2386674e7505df8@%3Cdev.wicket.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493289708 > dev@ @martin-g do you refer to the dev@wicket.apache.org mail list? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493288087 It seems to work pretty well. Should I continue and try adding a WICKET-6667 #359 into this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-492022858 Another important point to discuss is a format. The IIFE is currently configured is good to make it compatible with Wicket 8 stuff. Essentially what I have here _supposed_ to be a drop in replacement of existing wicket-modal-jquery, and could potentially be backported to Wicket 8. I think for future Wicket releases we can consider other options such as AMD, UMD or CommonJS, or make to have a few JS files built in and allow end developers to pick whichever is more convenient for them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
