[GitHub] [wicket] bitstorm commented on a change in pull request #432: WICKET-6774: minor change to contract of Component.getBehaviorId

[GitBox]

bitstorm commented on a change in pull request #432:
URL: https://github.com/apache/wicket/pull/432#discussion_r422006145



##
File path: 
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
##
@@ -83,12 +83,12 @@ protected void onBind()
final Component component = getComponent();

component.setOutputMarkupId(true);
-   
-   if (getStatelessHint(component))
-   {
-   //generate behavior id
-   component.getBehaviorId(this);
-   }
+   }
+   
+   @Override

Review comment:
   ok. thanks for the explanation!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [wicket] bitstorm commented on a change in pull request #432: WICKET-6774: minor change to contract of Component.getBehaviorId

[GitBox]

bitstorm commented on a change in pull request #432:
URL: https://github.com/apache/wicket/pull/432#discussion_r421995149



##
File path: 
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
##
@@ -83,12 +83,12 @@ protected void onBind()
final Component component = getComponent();

component.setOutputMarkupId(true);
-   
-   if (getStatelessHint(component))
-   {
-   //generate behavior id
-   component.getBehaviorId(this);
-   }
+   }
+   
+   @Override

Review comment:
   Hi,
   forcing Ajax behavior to be stateful by default will break the current logic 
for stateless Ajax component. See [user 
guide](https://ci.apache.org/projects/wicket/guide/8.x/single.html#_stateless_ajax_components_behaviors).
 
   I would remove this isStableIdRequired override and just keep things as they 
are now, i.e. behaviors state (stateful/stateless) depends on container 
component.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org