[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-477232378 @mattrpav can you check if `cglib-nodep+latest_asm` will work as expected and update your PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476751902 I would say `cglib-nodep` is better option since we have `asm` as separate dependency ... @martin-g, @svenmeier, @bitstorm WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748823 @mattrpav PR with the link to JIRA is perfectly fine :) You did everything right :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476743542 @mattrpav I got build error with this change: ``` WARNING] Dependency convergence error for org.ow2.asm:asm:7.0 paths to dependency are: +-org.apache.wicket:wicket-ioc:9.0.0-SNAPSHOT +-cglib:cglib:3.2.10 +-org.ow2.asm:asm:7.0 and +-org.apache.wicket:wicket-ioc:9.0.0-SNAPSHOT +-org.ow2.asm:asm-util:7.1 +-org.ow2.asm:asm:7.1 and +-org.apache.wicket:wicket-ioc:9.0.0-SNAPSHOT +-org.ow2.asm:asm-util:7.1 +-org.ow2.asm:asm-tree:7.1 +-org.ow2.asm:asm:7.1 icket-ioc: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed ``` I'm afraid some additional changes are required BTW can you close #350, I'll cherry-pick this one into wicket-8.x This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
