[GitHub] wicket issue #342: Wicket 6616 always render new pages

2018-12-03 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 This needs a thorough discussion of a solution for 9.x. ---

[GitHub] wicket issue #342: Wicket 6616 always render new pages

2018-12-03 Thread bitstorm
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 Sounds good to me ---

[GitHub] wicket issue #342: Wicket 6616 always render new pages

2018-12-03 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 Ok, you're right, that would be an improvement. IMHO this change is to big to introduce in a 8.x release though. I'd say we revert WICKET-6608 (which as is allows even more components

[GitHub] wicket issue #342: Wicket 6616 always render new pages

2018-12-03 Thread bitstorm
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 @svenmeier sorry, what I said wasn't correct. By calling onDetach we don't discard the current page instance but we force configuration phase to be performed again before the actual rendering

[GitHub] wicket issue #342: Wicket 6616 always render new pages

2018-12-02 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 >Components like FeddbackPanel can not work properly anymore. That's not the case - feedbackPanels are explicitly not prepared for render. I'm not sure using a new page instance is

[GitHub] wicket issue #342: Wicket 6616 always render new pages

2018-12-02 Thread bitstorm
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 @svenmeier i agree with the overall goal of accessing to render components only. There is however a huge drawback with this solution as now onConfigure is executed before form validation or event