[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 This needs a thorough discussion of a solution for 9.x. ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 Sounds good to me ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 Ok, you're right, that would be an improvement. IMHO this change is to big to introduce in a 8.x release though. I'd say we revert WICKET-6608 (which as is allows even more components to be accessed unprepared now) and try to find a better solution for 9.x. ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 @svenmeier sorry, what I said wasn't correct. By calling onDetach we don't discard the current page instance but we force configuration phase to be performed again before the actual rendering phase, so no information is lost. I still think this can be an improvement because users expect onConfigure to be called before the actual rendering and after event/submission handling. ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 >Components like FeddbackPanel can not work properly anymore. That's not the case - feedbackPanels are explicitly not prepared for render. I'm not sure using a new page instance is right either: the developer might want to keep some state during a single request. Your commit results int all feedback messages getting lost, doesn't it? ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 @svenmeier i agree with the overall goal of accessing to render components only. There is however a huge drawback with this solution as now onConfigure is executed before form validation or event handling. Components like FeddbackPanel can not work properly anymore. To overcome this limit with stateless pages we can consider to use a brand new page instance for rendering phase. To achieve this result we can for example detach PageComponentProvider after we have invoked the required listener. I will commit this improvement as soon as possible. ---
