Re: Browser console error in case binary message is being sent to WebSocket

2016-10-14 Thread Maxim Solodovnik 
Sorry Martin,

Good to know it is fixed :)

On Fri, Oct 14, 2016 at 7:35 PM, Martin Grigorov 
wrote:

> Hi Maxim,
>
> Old news ;-)
>
> https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef39686
> 4bf0dfad6c
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Fri, Oct 14, 2016 at 1:43 PM, Maxim Solodovnik 
> wrote:
>
> > Hello,
> >
> > I have added WebSocket ping to prevent nginx proxied WebSocket from being
> > closed
> > To implement it I'm sending bunary websocket message:
> >
> > wsConnection.sendMessage(new byte[1], 0, 1);
> >
> > As a result I'm getting
> >
> > Uncaught TypeError: message.indexOf is not a function
> > at WebSocket.self.ws.onmessage (
> > https://antares.unipro.ru/openmeetings/wicket/resource/
> > org.apache.wicket.pr
> > …esourceReference/res/js/wicket-websocket-jquery-ver-
> > 1470143575000.js:78:29)
> >
> > JS code is
> > var message = event.data;
> > if (message && message.indexOf('') > -1) {
> >
> >
> > wicket 7.4.0
> >
> > I guess it need to be fixed, since API allows calls like this
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>



-- 
WBR
Maxim aka solomax

Re: Browser console error in case binary message is being sent to WebSocket

2016-10-14 Thread Martin Grigorov 
Hi Maxim,

Old news ;-)

https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef396864bf0dfad6c

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Oct 14, 2016 at 1:43 PM, Maxim Solodovnik 
wrote:

> Hello,
>
> I have added WebSocket ping to prevent nginx proxied WebSocket from being
> closed
> To implement it I'm sending bunary websocket message:
>
> wsConnection.sendMessage(new byte[1], 0, 1);
>
> As a result I'm getting
>
> Uncaught TypeError: message.indexOf is not a function
> at WebSocket.self.ws.onmessage (
> https://antares.unipro.ru/openmeetings/wicket/resource/
> org.apache.wicket.pr
> …esourceReference/res/js/wicket-websocket-jquery-ver-
> 1470143575000.js:78:29)
>
> JS code is
> var message = event.data;
> if (message && message.indexOf('') > -1) {
>
>
> wicket 7.4.0
>
> I guess it need to be fixed, since API allows calls like this
>
> --
> WBR
> Maxim aka solomax
>

Browser console error in case binary message is being sent to WebSocket

2016-10-14 Thread Maxim Solodovnik 
Hello,

I have added WebSocket ping to prevent nginx proxied WebSocket from being
closed
To implement it I'm sending bunary websocket message:

wsConnection.sendMessage(new byte[1], 0, 1);

As a result I'm getting

Uncaught TypeError: message.indexOf is not a function
at WebSocket.self.ws.onmessage (
https://antares.unipro.ru/openmeetings/wicket/resource/org.apache.wicket.pr
…esourceReference/res/js/wicket-websocket-jquery-ver-1470143575000.js:78:29)

JS code is
var message = event.data;
if (message && message.indexOf('') > -1) {


wicket 7.4.0

I guess it need to be fixed, since API allows calls like this

-- 
WBR
Maxim aka solomax