Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-10 Thread Kishanthan Thangarajah
The changes have been added to those repos. On Wed, Dec 10, 2014 at 12:56 PM, Jeewantha Dharmaparakrama jeewan...@wso2.com wrote: @CarbonTeam. Seems like wss4j version is not update in carbon-utils[1] and carbon-qos[2] repos. Please check [1]

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-09 Thread Jeewantha Dharmaparakrama
@CarbonTeam, please do the needful to merge the Kernal change to master branch. ESB still gets wss4j 1.5.11.wso2v7 bundle from Kernal dependencies. Thanks, Jeewantha On Tue, Dec 9, 2014 at 1:28 PM, Jeewantha Dharmaparakrama jeewan...@wso2.com wrote: Folks, Doesn't look like wss4j new bundle

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-09 Thread Kishanthan Thangarajah
Done. Will be available with the next SNAPSHOT build. On Tue, Dec 9, 2014 at 3:01 PM, Jeewantha Dharmaparakrama jeewan...@wso2.com wrote: @CarbonTeam, please do the needful to merge the Kernal change to master branch. ESB still gets wss4j 1.5.11.wso2v7 bundle from Kernal dependencies.

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-09 Thread Pulasthi Mahawithana
Hi, wss4j was added to security-mgt feature with [1], please review and merge. [1] https://github.com/wso2-dev/carbon-identity/pull/35 On Tue, Dec 9, 2014 at 4:52 PM, Kishanthan Thangarajah kishant...@wso2.com wrote: Done. Will be available with the next SNAPSHOT build. On Tue, Dec 9, 2014

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-09 Thread Jeewantha Dharmaparakrama
@ISTeam, please merge the change to wso2 repo as well to avoid product build failures. On Tue, Dec 9, 2014 at 6:33 PM, Pulasthi Mahawithana pulast...@wso2.com wrote: Hi, wss4j was added to security-mgt feature with [1], please review and merge. [1]

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-09 Thread Supun Malinga
Hi Maheshika, Can we pls check why security mgt jars are not updated in nexus with following build. https://wso2.org/jenkins/job/carbon-identity/ http://maven.wso2.org/nexus/content/repositories/snapshots/org/wso2/carbon/org.wso2.carbon.security.mgt.feature/4.3.0-SNAPSHOT/ thanks, On Tue,

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-08 Thread Kishanthan Thangarajah
This has been merged to master branch. @ESB Team, please test your scenarios with wss4j-1.5.11-wso2v8-SNAPSHOT. On Fri, Dec 5, 2014 at 5:35 PM, Pulasthi Mahawithana pulast...@wso2.com wrote: Created a PR [1] to fix this. Please review and merge. [1]

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-08 Thread Jeewantha Dharmaparakrama
@IS Team, is the bundle added to security-mgt feature ? Do we have do any changes from ESB side? On Monday, December 8, 2014, Kishanthan Thangarajah kishant...@wso2.com wrote: This has been merged to master branch. @ESB Team, please test your scenarios with wss4j-1.5.11-wso2v8-SNAPSHOT. On

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-08 Thread Jeewantha Dharmaparakrama
Folks, Doesn't look like wss4j new bundle is included in security-mgt feature [1]. @IS Team, can you guys check on this ASAP ? [1] https://github.com/wso2-dev/carbon-identity/blob/master/features/security-mgt/org.wso2.carbon.security.mgt.server.feature/pom.xml On Mon, Dec 8, 2014 at 3:42 PM,

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-05 Thread Pulasthi Mahawithana
Created a PR [1] to fix this. Please review and merge. [1] https://github.com/wso2-dev/wso2-wss4j/pull/2 On Fri, Dec 5, 2014 at 12:45 PM, Pulasthi Mahawithana pulast...@wso2.com wrote: Hi Kishanthan, Will do. On Fri, Dec 5, 2014 at 12:22 PM, Kishanthan Thangarajah kishant...@wso2.com

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Kishanthan Thangarajah
The following commit has introduced this change : https://github.com/wso2/wso2-wss4j/commit/3185c3f155df48f6a666cd79873010f62b8c97a9 @Pulasthi/Johann, the above commit has removed the DynamicImport-Package tag in the orbit bundle. This change has no impact on kernel, but since

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Jeewantha Dharmaparakrama
I have already tested with adding Dynamic Imports to the bundle and everything works as expected. We will need to release the bundle again. Thanks, Jeewantha On Thu, Dec 4, 2014 at 7:50 PM, Kishanthan Thangarajah kishant...@wso2.com wrote: The following commit has introduced this change :

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Johann Nallathamby
Looks like this has been mistakenly removed. Its unfortunate that this has gone uncaught until now. Right after this was done we tried running ESB integration tests but some tests were commented out at the time and the ones that were uncommented had other tests failing. @Kernel Team: WSS4J was

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Sameera Jayasoma
Hi Johann, Yes our plan is to remove WSS4J dependency from RC2 build onwards. I've done some basic testing. So far so good. Thanks, Sameera. On Thu, Dec 4, 2014 at 11:37 PM, Johann Nallathamby joh...@wso2.com wrote: Looks like this has been mistakenly removed. Its unfortunate that this has

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Sameera Jayasoma
Btw, what would be the relevant feature which should bundle wss4j. Rampart? On Fri, Dec 5, 2014 at 12:45 AM, Sameera Jayasoma same...@wso2.com wrote: Hi Johann, Yes our plan is to remove WSS4J dependency from RC2 build onwards. I've done some basic testing. So far so good. Thanks,

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Johann Nallathamby
Rampart is bundled in security-mgt feature. So WSS4J also should go there. On Fri, Dec 5, 2014 at 12:54 AM, Sameera Jayasoma same...@wso2.com wrote: Btw, what would be the relevant feature which should bundle wss4j. Rampart? On Fri, Dec 5, 2014 at 12:45 AM, Sameera Jayasoma same...@wso2.com

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Kishanthan Thangarajah
On Thu, Dec 4, 2014 at 9:50 PM, Jeewantha Dharmaparakrama jeewan...@wso2.com wrote: I have already tested with adding Dynamic Imports to the bundle and everything works as expected. We will need to release the bundle again. Can you sent the changes as a PR to master branch? Thanks,

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Kishanthan Thangarajah
@Pulasthi, can you work with ESB team and fix this? We need to fix the issue with orbit bundle and make the changes available in the master branch of wss4j. On Fri, Dec 5, 2014 at 11:24 AM, Kishanthan Thangarajah kishant...@wso2.com wrote: On Thu, Dec 4, 2014 at 9:50 PM, Jeewantha

Re: [Dev] [Important] wss4j 1.5.11.wso2v7 bundle does not contain Dynamic Imports

2014-12-04 Thread Pulasthi Mahawithana
Hi Kishanthan, Will do. On Fri, Dec 5, 2014 at 12:22 PM, Kishanthan Thangarajah kishant...@wso2.com wrote: @Pulasthi, can you work with ESB team and fix this? We need to fix the issue with orbit bundle and make the changes available in the master branch of wss4j. On Fri, Dec 5, 2014 at