Re: [Dev] Why not ship creator and publisher roles pre-built in API-M?

2016-09-19 Thread Malintha Amarasinghe 
Hi Lahiru,

Thanks for the response.

On Mon, Sep 19, 2016 at 11:27 AM, Lahiru Cooray  wrote:

> Hi Malintha,
> Is there a use case to make these internal roles configurable?
> IMHO, since we are using these internal roles in our code level logics, we
> could make it mandatory (role creation + assignment of default permissions)
> without introducing another config parameter.
>
> Actually we are using internally in code are not role names, but
permissions. So we have the flexibility to change any associated roles with
correct permissions. Permissions are not changed or configurable. Yes
majority would not need to change them and it would add another config..
but in case if someone want to change the default names OR does not want to
create those roles at all etc, he would not have an option if we do not
make it configurable..

Thanks!

>
>
> On Thu, Sep 15, 2016 at 2:54 PM, Malintha Amarasinghe 
> wrote:
>
>> Hi,
>>
>> Adding this by default will give lots of benefits for automation testing
>> as well..
>>
>> Shall we have a config in api-manager.xml to specify these roles? If so
>> are we adding it under  element? However  is
>> where Publisher web app specific configurations resides. But publisher and
>> creator roles are not really specific to Publisher web app as they will be
>> used in REST APIs as well. So what would be the best place to add this
>> configuration? Under  or under a new config.. may be
>> ?
>>
>> Thanks!
>> Malintha
>>
>> On Wed, Sep 14, 2016 at 1:18 PM, Samisa Abeysinghe 
>> wrote:
>>
>>>
>>> On Wed, Sep 14, 2016 at 10:24 AM, Uvindra Dias Jayasinha <
>>> uvin...@wso2.com> wrote:
>>>
 Thats a good point Samisa.

 We have the subscriber role by default because we need it to set the
 permissions for users that sign up from the API store. All other user
 creations need to happen through the carbon admin console anyway so I guess
 we havent added those other roles by default.

 But I see no reason why we cannot have these roles already created to
 make it easier for the end user.

>>>
>>> ​+1
>>> ​
>>>


 On 14 September 2016 at 08:57, Samisa Abeysinghe 
 wrote:

> We ship subscriber role with proper permissions set.
>
> https://docs.wso2.com/display/AM200/Adding+User+Roles describes
> creator and publisher roles.
> But the vanilla product does not have them.
>
> Why not create and ship them with proper permissions pre-set? Why only
> subscriber role?
>
> Thanks,
> Samisa...
>
>
> Samisa Abeysinghe
>
> Vice President Delivery
>
> WSO2 Inc.
> http://wso2.com
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


 --
 Regards,
 Uvindra

 Mobile: 33962

>>>
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Malintha Amarasinghe
>> Software Engineer
>> *WSO2, Inc. - lean | enterprise | middleware*
>> http://wso2.com/
>>
>> Mobile : +94 712383306
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Lahiru Cooray*
> Software Engineer
> WSO2, Inc.;http://wso2.com/
> lean.enterprise.middleware
>
> Mobile: +94 715 654154
>



-- 
Malintha Amarasinghe
Software Engineer
*WSO2, Inc. - lean | enterprise | middleware*
http://wso2.com/

Mobile : +94 712383306
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Why not ship creator and publisher roles pre-built in API-M?

2016-09-18 Thread Lahiru Cooray 
Hi Malintha,
Is there a use case to make these internal roles configurable?
IMHO, since we are using these internal roles in our code level logics, we
could make it mandatory (role creation + assignment of default permissions)
without introducing another config parameter.



On Thu, Sep 15, 2016 at 2:54 PM, Malintha Amarasinghe 
wrote:

> Hi,
>
> Adding this by default will give lots of benefits for automation testing
> as well..
>
> Shall we have a config in api-manager.xml to specify these roles? If so
> are we adding it under  element? However  is
> where Publisher web app specific configurations resides. But publisher and
> creator roles are not really specific to Publisher web app as they will be
> used in REST APIs as well. So what would be the best place to add this
> configuration? Under  or under a new config.. may be
> ?
>
> Thanks!
> Malintha
>
> On Wed, Sep 14, 2016 at 1:18 PM, Samisa Abeysinghe 
> wrote:
>
>>
>> On Wed, Sep 14, 2016 at 10:24 AM, Uvindra Dias Jayasinha <
>> uvin...@wso2.com> wrote:
>>
>>> Thats a good point Samisa.
>>>
>>> We have the subscriber role by default because we need it to set the
>>> permissions for users that sign up from the API store. All other user
>>> creations need to happen through the carbon admin console anyway so I guess
>>> we havent added those other roles by default.
>>>
>>> But I see no reason why we cannot have these roles already created to
>>> make it easier for the end user.
>>>
>>
>> ​+1
>> ​
>>
>>>
>>>
>>> On 14 September 2016 at 08:57, Samisa Abeysinghe 
>>> wrote:
>>>
 We ship subscriber role with proper permissions set.

 https://docs.wso2.com/display/AM200/Adding+User+Roles describes
 creator and publisher roles.
 But the vanilla product does not have them.

 Why not create and ship them with proper permissions pre-set? Why only
 subscriber role?

 Thanks,
 Samisa...


 Samisa Abeysinghe

 Vice President Delivery

 WSO2 Inc.
 http://wso2.com


 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>>
>>> --
>>> Regards,
>>> Uvindra
>>>
>>> Mobile: 33962
>>>
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Malintha Amarasinghe
> Software Engineer
> *WSO2, Inc. - lean | enterprise | middleware*
> http://wso2.com/
>
> Mobile : +94 712383306
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Lahiru Cooray*
Software Engineer
WSO2, Inc.;http://wso2.com/
lean.enterprise.middleware

Mobile: +94 715 654154
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Why not ship creator and publisher roles pre-built in API-M?

2016-09-15 Thread Malintha Amarasinghe 
Hi,

Adding this by default will give lots of benefits for automation testing as
well..

Shall we have a config in api-manager.xml to specify these roles? If so are
we adding it under  element? However  is where
Publisher web app specific configurations resides. But publisher and
creator roles are not really specific to Publisher web app as they will be
used in REST APIs as well. So what would be the best place to add this
configuration? Under  or under a new config.. may be
?

Thanks!
Malintha

On Wed, Sep 14, 2016 at 1:18 PM, Samisa Abeysinghe  wrote:

>
> On Wed, Sep 14, 2016 at 10:24 AM, Uvindra Dias Jayasinha  > wrote:
>
>> Thats a good point Samisa.
>>
>> We have the subscriber role by default because we need it to set the
>> permissions for users that sign up from the API store. All other user
>> creations need to happen through the carbon admin console anyway so I guess
>> we havent added those other roles by default.
>>
>> But I see no reason why we cannot have these roles already created to
>> make it easier for the end user.
>>
>
> ​+1
> ​
>
>>
>>
>> On 14 September 2016 at 08:57, Samisa Abeysinghe  wrote:
>>
>>> We ship subscriber role with proper permissions set.
>>>
>>> https://docs.wso2.com/display/AM200/Adding+User+Roles describes creator
>>> and publisher roles.
>>> But the vanilla product does not have them.
>>>
>>> Why not create and ship them with proper permissions pre-set? Why only
>>> subscriber role?
>>>
>>> Thanks,
>>> Samisa...
>>>
>>>
>>> Samisa Abeysinghe
>>>
>>> Vice President Delivery
>>>
>>> WSO2 Inc.
>>> http://wso2.com
>>>
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Regards,
>> Uvindra
>>
>> Mobile: 33962
>>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Malintha Amarasinghe
Software Engineer
*WSO2, Inc. - lean | enterprise | middleware*
http://wso2.com/

Mobile : +94 712383306
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Why not ship creator and publisher roles pre-built in API-M?

2016-09-14 Thread Samisa Abeysinghe 
On Wed, Sep 14, 2016 at 10:24 AM, Uvindra Dias Jayasinha 
wrote:

> Thats a good point Samisa.
>
> We have the subscriber role by default because we need it to set the
> permissions for users that sign up from the API store. All other user
> creations need to happen through the carbon admin console anyway so I guess
> we havent added those other roles by default.
>
> But I see no reason why we cannot have these roles already created to make
> it easier for the end user.
>

​+1
​

>
>
> On 14 September 2016 at 08:57, Samisa Abeysinghe  wrote:
>
>> We ship subscriber role with proper permissions set.
>>
>> https://docs.wso2.com/display/AM200/Adding+User+Roles describes creator
>> and publisher roles.
>> But the vanilla product does not have them.
>>
>> Why not create and ship them with proper permissions pre-set? Why only
>> subscriber role?
>>
>> Thanks,
>> Samisa...
>>
>>
>> Samisa Abeysinghe
>>
>> Vice President Delivery
>>
>> WSO2 Inc.
>> http://wso2.com
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Regards,
> Uvindra
>
> Mobile: 33962
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Why not ship creator and publisher roles pre-built in API-M?

2016-09-13 Thread Uvindra Dias Jayasinha 
Thats a good point Samisa.

We have the subscriber role by default because we need it to set the
permissions for users that sign up from the API store. All other user
creations need to happen through the carbon admin console anyway so I guess
we havent added those other roles by default.

But I see no reason why we cannot have these roles already created to make
it easier for the end user.


On 14 September 2016 at 08:57, Samisa Abeysinghe  wrote:

> We ship subscriber role with proper permissions set.
>
> https://docs.wso2.com/display/AM200/Adding+User+Roles describes creator
> and publisher roles.
> But the vanilla product does not have them.
>
> Why not create and ship them with proper permissions pre-set? Why only
> subscriber role?
>
> Thanks,
> Samisa...
>
>
> Samisa Abeysinghe
>
> Vice President Delivery
>
> WSO2 Inc.
> http://wso2.com
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Regards,
Uvindra

Mobile: 33962
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev