[jira] [Commented] (XALANC-803) MinGW build is broken
[ https://issues.apache.org/jira/browse/XALANC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419864#comment-17419864 ] Roger Leigh commented on XALANC-803: Apologies, I've lost track of that due to lots of other commitments. If everyone is happy with this, then I don't see any blocker to merging it. I'll just re-run the CI to double-check the cygwin build is OK (though it might not be--AppVeyor broke it for Xerces and I'm not sure about Xalan). > MinGW build is broken > - > > Key: XALANC-803 > URL: https://issues.apache.org/jira/browse/XALANC-803 > Project: XalanC > Issue Type: Bug > Components: XalanC >Affects Versions: 1.12 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 1.13 > > Original Estimate: 48h > Remaining Estimate: 48h > > HANDLE and other macros not defined. Likely need to check if it should be > using the Unix or Windows includes and types, and adjust to make MinGW work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
[jira] [Commented] (XALANC-803) MinGW build is broken
[ https://issues.apache.org/jira/browse/XALANC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419785#comment-17419785 ] Patrick Northon commented on XALANC-803: There is a PR: [https://github.com/apache/xalan-c/pull/36]. > MinGW build is broken > - > > Key: XALANC-803 > URL: https://issues.apache.org/jira/browse/XALANC-803 > Project: XalanC > Issue Type: Bug > Components: XalanC >Affects Versions: 1.12 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 1.13 > > Original Estimate: 48h > Remaining Estimate: 48h > > HANDLE and other macros not defined. Likely need to check if it should be > using the Unix or Windows includes and types, and adjust to make MinGW work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
[jira] [Commented] (XALANC-803) MinGW build is broken
[ https://issues.apache.org/jira/browse/XALANC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419676#comment-17419676 ] Roger Leigh commented on XALANC-803: If you want to put this change into a patch or github PR, that would be most appreciated. > MinGW build is broken > - > > Key: XALANC-803 > URL: https://issues.apache.org/jira/browse/XALANC-803 > Project: XalanC > Issue Type: Bug > Components: XalanC >Affects Versions: 1.12 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 1.13 > > Original Estimate: 48h > Remaining Estimate: 48h > > HANDLE and other macros not defined. Likely need to check if it should be > using the Unix or Windows includes and types, and adjust to make MinGW work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
[jira] [Commented] (XALANC-803) MinGW build is broken
[ https://issues.apache.org/jira/browse/XALANC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419673#comment-17419673 ] Bence Blázsovics commented on XALANC-803: - ^^fixed the issue, thank you! ||=== Build finished: 0 error(s), 120 warning(s) (0 minute(s), 44 second(s)) ===| > MinGW build is broken > - > > Key: XALANC-803 > URL: https://issues.apache.org/jira/browse/XALANC-803 > Project: XalanC > Issue Type: Bug > Components: XalanC >Affects Versions: 1.12 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 1.13 > > Original Estimate: 48h > Remaining Estimate: 48h > > HANDLE and other macros not defined. Likely need to check if it should be > using the Unix or Windows includes and types, and adjust to make MinGW work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
[jira] [Commented] (XALANC-803) MinGW build is broken
[ https://issues.apache.org/jira/browse/XALANC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127679#comment-17127679 ] Patrick Northon commented on XALANC-803: The fix would be to change `_MSC_VER` to `_WIN32` in src/xalanc/XalanExe/XalanExe.cpp. > MinGW build is broken > - > > Key: XALANC-803 > URL: https://issues.apache.org/jira/browse/XALANC-803 > Project: XalanC > Issue Type: Bug > Components: XalanC >Affects Versions: 1.12 >Reporter: Roger Leigh >Assignee: Gary D. Gregory >Priority: Major > Fix For: 1.13 > > Original Estimate: 48h > Remaining Estimate: 48h > > HANDLE and other macros not defined. Likely need to check if it should be > using the Unix or Windows includes and types, and adjust to make MinGW work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
