[GitHub] avnerl commented on issue #3258: fix beam-runners-flink and zeppelin-scio scala version to 2.10

2018-12-29 Thread GitBox
avnerl commented on issue #3258: fix beam-runners-flink and zeppelin-scio scala version to 2.10 URL: https://github.com/apache/zeppelin/pull/3258#issuecomment-450502557 closing this for lack of time. i'll use this for my own testing: `mvn clean package -Pbuild-distr -DskipTests

[GitHub] avnerl closed pull request #3258: fix beam-runners-flink and zeppelin-scio scala version to 2.10

2018-12-29 Thread GitBox
avnerl closed pull request #3258: fix beam-runners-flink and zeppelin-scio scala version to 2.10 URL: https://github.com/apache/zeppelin/pull/3258 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] liuxunorg commented on issue #3273: [ZEPPELIN-3920] Paragraph support custom menu display with multiple URL link

2018-12-31 Thread GitBox
liuxunorg commented on issue #3273: [ZEPPELIN-3920] Paragraph support custom menu display with multiple URL link URL: https://github.com/apache/zeppelin/pull/3273#issuecomment-450653279 ## Instructions In the interpreter ```    Public InterpreterResult interpret(String script,

[GitHub] liuxunorg opened a new pull request #3278: [ZEPPELIN-3931] Redisplay angularObjectBind when the note is reopened

2018-12-31 Thread GitBox
liuxunorg opened a new pull request #3278: [ZEPPELIN-3931] Redisplay angularObjectBind when the note is reopened URL: https://github.com/apache/zeppelin/pull/3278 ### What is this PR for? At present, Bind's angularObject in note is only valid in the current operation web page. When

[GitHub] tiboun commented on issue #3277: [ZEPPELIN-2881] Fix OIDC logout

2018-12-31 Thread GitBox
tiboun commented on issue #3277: [ZEPPELIN-2881] Fix OIDC logout URL: https://github.com/apache/zeppelin/pull/3277#issuecomment-450643468 Description and title has been changed This is an automated message from the Apache Git

[GitHub] felixcheung commented on issue #3277: [ZEPPELIN-2881] Fix OIDC logout

2018-12-31 Thread GitBox
felixcheung commented on issue #3277: [ZEPPELIN-2881] Fix OIDC logout URL: https://github.com/apache/zeppelin/pull/3277#issuecomment-450703881 please setup CI: ``` Looks like travis-ci is not configured for your fork. Please setup by swich on 'zeppelin' repository at

[GitHub] felixcheung closed pull request #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

2018-12-31 Thread GitBox
felixcheung closed pull request #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0 URL: https://github.com/apache/zeppelin/pull/3266 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] liuxunorg commented on issue #3278: [ZEPPELIN-3931] Redisplay angularObjectBind when the note is reopened

2018-12-31 Thread GitBox
liuxunorg commented on issue #3278: [ZEPPELIN-3931] Redisplay angularObjectBind when the note is reopened URL: https://github.com/apache/zeppelin/pull/3278#issuecomment-450706382 CI Pass, https://travis-ci.org/liuxunorg/zeppelin/builds/473897099

[GitHub] felixcheung commented on a change in pull request #3273: [ZEPPELIN-3920] Paragraph support custom menu display with multiple URL link

2018-12-27 Thread GitBox
felixcheung commented on a change in pull request #3273: [ZEPPELIN-3920] Paragraph support custom menu display with multiple URL link URL: https://github.com/apache/zeppelin/pull/3273#discussion_r244277372 ## File path: zeppelin-web/src/app/notebook/paragraph/paragraph-control.html

[GitHub] keineahnung2345 commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-01 Thread GitBox
keineahnung2345 commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-450778395 @felixcheung Thanks for your timely response! Updating other Dockerfiles is in my plan.

[GitHub] keineahnung2345 edited a comment on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-01 Thread GitBox
keineahnung2345 edited a comment on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-450778395 @felixcheung Thanks for your timely response! I will create other PRs to update other Dockerfiles.

[GitHub] felixcheung commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-01 Thread GitBox
felixcheung commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-450778079 merging if no more comment This is an automated message

[GitHub] keineahnung2345 opened a new pull request #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-01 Thread GitBox
keineahnung2345 opened a new pull request #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279 ### What is this PR for? In the [spark_mesos example -

[GitHub] liuxunorg commented on a change in pull request #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException

2018-12-30 Thread GitBox
liuxunorg commented on a change in pull request #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException URL: https://github.com/apache/zeppelin/pull/3276#discussion_r244526697 ## File path:

[GitHub] tiboun commented on issue #3277: [ZEPPELIN-2881] Fix OIDC logout

2019-01-02 Thread GitBox
tiboun commented on issue #3277: [ZEPPELIN-2881] Fix OIDC logout URL: https://github.com/apache/zeppelin/pull/3277#issuecomment-450808900 Thanks, I've switched zeppelin on and 'build branch updates' was on already. Maybe it was renamed to 'Build pushed branches'. 'Build pushed pull

[GitHub] tiboun commented on a change in pull request #3277: [ZEPPELIN-2881] Fix OIDC logout

2019-01-02 Thread GitBox
tiboun commented on a change in pull request #3277: [ZEPPELIN-2881] Fix OIDC logout URL: https://github.com/apache/zeppelin/pull/3277#discussion_r244869176 ## File path: zeppelin-distribution/pom.xml ## @@ -113,6 +113,32 @@ + + oidc + + +

[GitHub] felixcheung closed pull request #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-04 Thread GitBox
felixcheung closed pull request #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] felixcheung commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-04 Thread GitBox
felixcheung commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-451629013 @keineahnung2345 hi - didn't see the message above. I think travis has changed the UI since we had that instruction, but

[GitHub] HyukjinKwon commented on issue #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12

2019-01-04 Thread GitBox
HyukjinKwon commented on issue #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3253#issuecomment-451630869 Yup.. let me take a look This is an automated message from the Apache

[GitHub] liuxunorg commented on issue #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException

2019-01-05 Thread GitBox
liuxunorg commented on issue #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException URL: https://github.com/apache/zeppelin/pull/3276#issuecomment-451638457 @felixcheung , I revert `Optimize the execution efficiency of the NotebookServer::onUpdate(...) function.` And

[GitHub] felixcheung commented on issue #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12

2019-01-04 Thread GitBox
felixcheung commented on issue #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3253#issuecomment-451628403 hmm, not sure why, this is the error, but I don't see recent changes that might have broken it ``` 09:52:10,841 INFO

[GitHub] felixcheung commented on a change in pull request #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException

2019-01-04 Thread GitBox
felixcheung commented on a change in pull request #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException URL: https://github.com/apache/zeppelin/pull/3276#discussion_r245467352 ## File path:

[GitHub] liuxunorg commented on a change in pull request #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException

2019-01-04 Thread GitBox
liuxunorg commented on a change in pull request #3276: [ZEPPELIN-3928] Fix bugs AngularBind operation NullPointerException URL: https://github.com/apache/zeppelin/pull/3276#discussion_r245468170 ## File path:

[GitHub] felixcheung edited a comment on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-04 Thread GitBox
felixcheung edited a comment on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-451629013 @keineahnung2345 hi - didn't see the message above. I think travis has changed the UI since we had that

[GitHub] keineahnung2345 commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-02 Thread GitBox
keineahnung2345 commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-451044535 @felixcheung I am new to travis and I cannot find the option 'Build branch updates' in my repo's settings.

[GitHub] tiboun commented on a change in pull request #3277: [ZEPPELIN-2881] Fix OIDC logout

2019-01-02 Thread GitBox
tiboun commented on a change in pull request #3277: [ZEPPELIN-2881] Fix OIDC logout URL: https://github.com/apache/zeppelin/pull/3277#discussion_r244870738 ## File path: docs/setup/security/shiro_authentication.md ## @@ -247,6 +247,92 @@ knoxJwtRealm.principalMapping =

[GitHub] felixcheung closed pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12

2019-01-02 Thread GitBox
felixcheung closed pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3253 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] felixcheung closed pull request #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can run by itself

2019-01-02 Thread GitBox
felixcheung closed pull request #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can run by itself URL: https://github.com/apache/zeppelin/pull/3249 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] OrDTesters opened a new pull request #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can run by itself

2019-01-02 Thread GitBox
OrDTesters opened a new pull request #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can run by itself URL: https://github.com/apache/zeppelin/pull/3249 ### What is this PR for? Test DependencyResolverTest.testDelRepo fails when run on its own. The test needs a repo to

[GitHub] felixcheung commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated

2019-01-02 Thread GitBox
felixcheung commented on issue #3279: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated URL: https://github.com/apache/zeppelin/pull/3279#issuecomment-451009805 FYI, I don't think we build docker, for future PR: ``` Looks like travis-ci is not configured for your fork.

[GitHub] HyukjinKwon opened a new pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12

2019-01-02 Thread GitBox
HyukjinKwon opened a new pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3253 ### What is this PR for? This is just to update scala to 2.11.12 which to be consistent with spark (SPARK-24418). This PR takes over and

[GitHub] HyukjinKwon opened a new pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12

2019-01-03 Thread GitBox
HyukjinKwon opened a new pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3253 ### What is this PR for? This is just to update scala to 2.11.12 which to be consistent with spark (SPARK-24418). This PR takes over and

[GitHub] HyukjinKwon closed pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12

2019-01-03 Thread GitBox
HyukjinKwon closed pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3253 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] D01B commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-16 Thread GitBox
D01B commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution" URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248267618 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ## @@

[GitHub] D01B commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox
D01B commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-454770146 @felixcheung could you merge changes or give some feedback?? This is

[GitHub] mcapuccini opened a new pull request #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-15 Thread GitBox
mcapuccini opened a new pull request #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin URL: https://github.com/apache/zeppelin/pull/3283 ### What is this PR for? Add `HADOOP_CLASSPATH` to `ZEPPELIN_CLASSPATH` when starting Zeppelin. This adds some

[GitHub] Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-15 Thread GitBox
Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution" URL: https://github.com/apache/zeppelin/pull/3281#discussion_r247873359 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java

[GitHub] Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-16 Thread GitBox
Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution" URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248331260 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ## @@

[GitHub] felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox
felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r248539269 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html

[GitHub] felixcheung edited a comment on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox
felixcheung edited a comment on issue #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-455042779 hey sorry about missing this. I'm going to check this PR now if you'd like to see my comment (here

[GitHub] felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox
felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-455042779 hey sorry about missing this. I'm going to check this PR now if you'd like to see my comment.

[GitHub] zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-16 Thread GitBox
zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution" URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248515673 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java

[GitHub] fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue

2019-01-16 Thread GitBox
fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue URL: https://github.com/apache/zeppelin/pull/3264#issuecomment-455042924 > is there js test we could add? I agree, just will take more time to write the test framework for this bug.

[GitHub] felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-16 Thread GitBox
felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table URL: https://github.com/apache/zeppelin/pull/3254#discussion_r248538413 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table.js

[GitHub] felixcheung commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-16 Thread GitBox
felixcheung commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table URL: https://github.com/apache/zeppelin/pull/3254#issuecomment-455041822 @fred521 please consider contributing ;)

[GitHub] felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox
felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-455043397 could you also update the images in the PR description to reflect the final visual (these gets linked to in the commit later)

[GitHub] Leemoonsoo commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-17 Thread GitBox
Leemoonsoo commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248734349 ## File path:

[GitHub] D01B edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-17 Thread GitBox
D01B edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-455056224 I think you should try to use ZEPPELIN_CLASSPATH_OVERRIDES instead of ZEPPELIN_CLASSPATH(on your

[GitHub] D01B commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox
D01B commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-455056224 I think you should try to use ZEPPELIN_CLASSPATH_OVERRIDES instead of ZEPPELIN_CLASSPATH(on your own

[GitHub] mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-17 Thread GitBox
mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-455083698 Ok! I'll try and I'll let you know. It would be nice though to to have it set automatically by

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-16 Thread GitBox
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248565818 ## File path:

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-16 Thread GitBox
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248567845 ## File path:

[GitHub] egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-17 Thread GitBox
egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r248643084 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html ##

[GitHub] maziyarpanahi edited a comment on issue #3206: [ZEPPELIN-3810] Support Spark 2.4

2019-01-18 Thread GitBox
maziyarpanahi edited a comment on issue #3206: [ZEPPELIN-3810] Support Spark 2.4 URL: https://github.com/apache/zeppelin/pull/3206#issuecomment-455617293 @HyukjinKwon @zjffdu @Leemoonsoo is it possible to shade Spark and Hadoop related dependencies when there is already Spark and Hadoop

[GitHub] asfgit closed pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-18 Thread GitBox
asfgit closed pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] maziyarpanahi commented on issue #3206: [ZEPPELIN-3810] Support Spark 2.4

2019-01-18 Thread GitBox
maziyarpanahi commented on issue #3206: [ZEPPELIN-3810] Support Spark 2.4 URL: https://github.com/apache/zeppelin/pull/3206#issuecomment-455617293 @HyukjinKwon @zjffdu is it possible to shade Spark and Hadoop related dependencies when there is already Spark and Hadoop exist? I was thinking

[GitHub] Leemoonsoo commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-18 Thread GitBox
Leemoonsoo commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249117176 ## File path:

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-18 Thread GitBox
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249025462 ## File path:

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-18 Thread GitBox
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249025462 ## File path:

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-18 Thread GitBox
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249025339 ## File path:

[GitHub] felixcheung merged pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-19 Thread GitBox
felixcheung merged pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table URL: https://github.com/apache/zeppelin/pull/3254 This is an automated message from the Apache Git Service. To

[GitHub] yx91490 edited a comment on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream

2019-01-19 Thread GitBox
yx91490 edited a comment on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream URL: https://github.com/apache/zeppelin/pull/3265#issuecomment-455831861 > @yx91490 This PR is mixed with other commits. sorry, It's hard to revert, should I close this and make a new

[GitHub] yx91490 commented on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream

2019-01-19 Thread GitBox
yx91490 commented on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream URL: https://github.com/apache/zeppelin/pull/3265#issuecomment-455831861 > @yx91490 This PR is mixed with other commits. sorry, I try to revert it

[GitHub] zjffdu commented on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream

2019-01-19 Thread GitBox
zjffdu commented on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream URL: https://github.com/apache/zeppelin/pull/3265#issuecomment-455780920 @yx91490 This PR is mixed with other commits. This is an

[GitHub] felixcheung commented on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream

2019-01-20 Thread GitBox
felixcheung commented on issue #3265: [ZEPPELIN-3910] IPython delete temp file and close stream URL: https://github.com/apache/zeppelin/pull/3265#issuecomment-455901052 you can rewrite log and force push - or it might be easier to open a new PR

[GitHub] conker84 opened a new pull request #3284: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

2019-01-20 Thread GitBox
conker84 opened a new pull request #3284: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types URL: https://github.com/apache/zeppelin/pull/3284 ### What is this PR for? Add the support for Point and Date data types introduced since Neo4j 3.4 ### What type of PR is it?

[GitHub] conker84 commented on issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

2019-01-20 Thread GitBox
conker84 commented on issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types URL: https://github.com/apache/zeppelin/pull/3244#issuecomment-455906123 @felixcheung I created the #3284. Let me know if I have to do something else

[GitHub] felixcheung commented on issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

2019-01-20 Thread GitBox
felixcheung commented on issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types URL: https://github.com/apache/zeppelin/pull/3244#issuecomment-455906270 thanks! This is an automated message from the

[GitHub] yx91490 closed pull request #3265: [ZEPPELIN-3910] IPython delete temp file and close stream

2019-01-20 Thread GitBox
yx91490 closed pull request #3265: [ZEPPELIN-3910] IPython delete temp file and close stream URL: https://github.com/apache/zeppelin/pull/3265 This is an automated message from the Apache Git Service. To respond to the

[GitHub] egorklimov commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-15 Thread GitBox
egorklimov commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table URL: https://github.com/apache/zeppelin/pull/3254#issuecomment-454518403 @felixcheung What about merge?) This is an

[GitHub] Leemoonsoo commented on issue #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-15 Thread GitBox
Leemoonsoo commented on issue #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#issuecomment-454588173 Sorry for responding late. Thanks @whai2kay for testing it out and confirming configure spark using "spark.master" interpreter conf.

[GitHub] felixcheung commented on issue #3282: [ZEPPELIN-3944] Update Dockerfiles of spark_standalone and spark_yarn_cluster

2019-01-14 Thread GitBox
felixcheung commented on issue #3282: [ZEPPELIN-3944] Update Dockerfiles of spark_standalone and spark_yarn_cluster URL: https://github.com/apache/zeppelin/pull/3282#issuecomment-454291540 merging if no more comment This is

[GitHub] D01B commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
D01B commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#issuecomment-456046170 @felixcheung, could you review, please?

[GitHub] D01B commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-21 Thread GitBox
D01B commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table URL: https://github.com/apache/zeppelin/pull/3254#issuecomment-456018216 @felixcheung thank you:) This is an automated

[GitHub] D01B opened a new pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
D01B opened a new pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285 ### What is this PR for? Fix Travis profiles and tests to archive build time under 50 minutes. ### What type

[GitHub] egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-21 Thread GitBox
egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r249395775 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html ##

[GitHub] zjffdu commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
zjffdu commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#issuecomment-456087530 Thanks @D01B +1 This is an

[GitHub] D01B opened a new pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
D01B opened a new pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286 ### What is this PR for? Removing Message class usage from NotebookService. Using DTO object in services broke abstraction.

[GitHub] Savalek commented on issue #3179: [ZEPPELIN-3773] - add check permission on write.

2019-01-21 Thread GitBox
Savalek commented on issue #3179: [ZEPPELIN-3773] - add check permission on write. URL: https://github.com/apache/zeppelin/pull/3179#issuecomment-456088985 @felixcheung, could you review, please? This is an automated message

[GitHub] felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#discussion_r249563274 ## File path:

[GitHub] felixcheung commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
felixcheung commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#issuecomment-456182522 merging if no more comment This

[GitHub] D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249568549 ## File path:

[GitHub] D01B commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
D01B commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#discussion_r249565449 ## File path: .travis.yml ## @@ -92,11 +92,17 @@ matrix:

[GitHub] egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-21 Thread GitBox
egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r249574486 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html ##

[GitHub] D01B commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
D01B commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#discussion_r249568152 ## File path: .travis.yml ## @@ -92,11 +92,17 @@ matrix:

[GitHub] felixcheung merged pull request #3284: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

2019-01-21 Thread GitBox
felixcheung merged pull request #3284: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types URL: https://github.com/apache/zeppelin/pull/3284 This is an automated message from the Apache Git Service. To respond

[GitHub] felixcheung commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249566680 ## File path:

[GitHub] felixcheung commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249566766 ## File path:

[GitHub] D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249572502 ## File path:

[GitHub] egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-21 Thread GitBox
egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r249574410 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html ##

[GitHub] egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-21 Thread GitBox
egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r249574410 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html ##

[GitHub] felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#discussion_r249563081 ## File path:

[GitHub] felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#discussion_r249562848 ## File path: .travis.yml ## @@ -92,11 +92,17 @@ matrix:

[GitHub] D01B commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
D01B commented on issue #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#issuecomment-456186473 @felixcheung I think in the next couple months we may upgrade the spark version, in this month we don't

[GitHub] felixcheung commented on issue #3179: [ZEPPELIN-3773] - add check permission on write.

2019-01-21 Thread GitBox
felixcheung commented on issue #3179: [ZEPPELIN-3773] - add check permission on write. URL: https://github.com/apache/zeppelin/pull/3179#issuecomment-456186707 this is a bit tricky, could @prabhjyotsingh review? This is an

[GitHub] felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3285: [ZEPPELIN-3957] Divide SparkIntegrationTest into parts for build under 50 minutes URL: https://github.com/apache/zeppelin/pull/3285#discussion_r249567250 ## File path: .travis.yml ## @@ -92,11 +92,17 @@ matrix:

[GitHub] D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249569055 ## File path:

[GitHub] felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-21 Thread GitBox
felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r249562539 ## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html

[GitHub] maziyarpanahi commented on issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift

2019-01-21 Thread GitBox
maziyarpanahi commented on issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift URL: https://github.com/apache/zeppelin/pull/2975#issuecomment-456213193 I am facing the same problem in CDH 6.1 even though I have built from 0.8.2 that still has Thrift 0.9.2. is this part of

[GitHub] D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

2019-01-21 Thread GitBox
D01B commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService. URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249572502 ## File path:

  1   2   3   4   5   6   7   8   9   >