[GitHub] felixcheung commented on a change in pull request #3307: ZEPPELIN-4005. SparkRInterpreter is broken for spark 2.1.3 and 2.2.2

2019-03-01 Thread GitBox
felixcheung commented on a change in pull request #3307: ZEPPELIN-4005. 
SparkRInterpreter is broken for spark 2.1.3 and 2.2.2
URL: https://github.com/apache/zeppelin/pull/3307#discussion_r261814613
 
 

 ##
 File path: 
zeppelin-interpreter-integration/src/test/java/org/apache/zeppelin/integration/ZeppelinSparkClusterTest21.java
 ##
 @@ -34,7 +34,7 @@ public ZeppelinSparkClusterTest21(String sparkVersion) 
throws Exception {
   @Parameterized.Parameters
   public static List data() {
 return Arrays.asList(new Object[][]{
-{"2.1.2"}
+{"2.1.3"}
 
 Review comment:
   ok for livy is there new version support 
https://github.com/apache/zeppelin/blob/master/.travis.yml#L142?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] felixcheung commented on a change in pull request #3307: ZEPPELIN-4005. SparkRInterpreter is broken for spark 2.1.3 and 2.2.2

2019-02-15 Thread GitBox
felixcheung commented on a change in pull request #3307: ZEPPELIN-4005. 
SparkRInterpreter is broken for spark 2.1.3 and 2.2.2
URL: https://github.com/apache/zeppelin/pull/3307#discussion_r257450587
 
 

 ##
 File path: 
spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkVersion.java
 ##
 @@ -86,7 +86,11 @@ public boolean isSpark2() {
   }
 
   public boolean isSecretSocketSupported() {
-return this.newerThanEquals(SPARK_2_3_1);
+return this.newerThanEquals(SPARK_2_3_1) ||
+(this.newerThanEquals(SparkVersion.fromVersionString("2.2.2")) &&
+this.olderThan(SparkVersion.fromVersionString("2.3.0"))) ||
+(this.newerThanEquals(SparkVersion.fromVersionString("2.1.3")) &&
+this.olderThan(SparkVersion.fromVersionString("2.2.0")));
 
 Review comment:
   I think this works, but if and only if they are evaluated in the given 
order, which is a bit error prone. might be worthwhile to add a 
`newerThanEqualsPatchVersion` for `2.2.[2+]` type of check


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] felixcheung commented on a change in pull request #3307: ZEPPELIN-4005. SparkRInterpreter is broken for spark 2.1.3 and 2.2.2

2019-02-15 Thread GitBox
felixcheung commented on a change in pull request #3307: ZEPPELIN-4005. 
SparkRInterpreter is broken for spark 2.1.3 and 2.2.2
URL: https://github.com/apache/zeppelin/pull/3307#discussion_r257450631
 
 

 ##
 File path: 
zeppelin-interpreter-integration/src/test/java/org/apache/zeppelin/integration/ZeppelinSparkClusterTest21.java
 ##
 @@ -34,7 +34,7 @@ public ZeppelinSparkClusterTest21(String sparkVersion) 
throws Exception {
   @Parameterized.Parameters
   public static List data() {
 return Arrays.asList(new Object[][]{
-{"2.1.2"}
+{"2.1.3"}
 
 Review comment:
   can this be passed in thru travis? 
   
   and should these be updated 
https://github.com/apache/zeppelin/blob/master/.travis.yml#L136 "2.1.0"
   
   https://github.com/apache/zeppelin/blob/master/.travis.yml#L142 "2.2.0"
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services