[GitHub] [zeppelin] liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492696041 # The function is exactly the same as the terminal emulator ## curl + tar ScreenRecord

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
felixcheung commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284328179 ## File path:

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

2019-05-15 Thread GitBox
felixcheung commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show URL: https://github.com/apache/zeppelin/pull/3365#discussion_r284327576 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -237,7

[GitHub] [zeppelin] Leemoonsoo commented on issue #3363: [ZEPPELIN-4144] After refresh the revision tools are sometimes hidden

2019-05-15 Thread GitBox
Leemoonsoo commented on issue #3363: [ZEPPELIN-4144] After refresh the revision tools are sometimes hidden URL: https://github.com/apache/zeppelin/pull/3363#issuecomment-492770214 Thanks @florpor for the contribution! Could you check message from Jenkins and try setup travis, and make

[GitHub] [zeppelin] liuxunorg opened a new pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

2019-05-15 Thread GitBox
liuxunorg opened a new pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show URL: https://github.com/apache/zeppelin/pull/3365 ### What is this PR for? when the note moved to trash, the note should show 'Remove this note permanently', it does not work

[GitHub] [zeppelin] liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

2019-05-15 Thread GitBox
liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show URL: https://github.com/apache/zeppelin/pull/3365#issuecomment-492710080 @zjffdu , Please help me review code. Thanks! This

[GitHub] [zeppelin] liuxunorg commented on issue #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
liuxunorg commented on issue #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#issuecomment-492710247 @zjffdu , Please help me review code. Thanks!

[GitHub] [zeppelin] Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
Tagar commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492824721 As part of Zeppelin notes we have static %sh paragraphs (non-interactive) with or without variable embeddings (variable interpolations

[GitHub] [zeppelin] liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

2019-05-15 Thread GitBox
liuxunorg commented on issue #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show URL: https://github.com/apache/zeppelin/pull/3365#issuecomment-492884302 > can you explain the change from `[0]` to `[1]`? @felixcheung , This is because of the problem caused by this

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852 ## File path:

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852 ## File path:

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852 ## File path:

[GitHub] [zeppelin] liuxunorg commented on issue #3203: [ZEPPELIN-3626] Cluster server and client module

2019-05-15 Thread GitBox
liuxunorg commented on issue #3203: [ZEPPELIN-3626] Cluster server and client module URL: https://github.com/apache/zeppelin/pull/3203#issuecomment-492885349 This feature has been running in our company for 2 years and there is no problem. Will merge if no more comments.

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show

2019-05-15 Thread GitBox
liuxunorg commented on a change in pull request #3365: [ZEPPELIN-4160] Fixed Move this note to trash icon always show URL: https://github.com/apache/zeppelin/pull/3365#discussion_r284510848 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -237,7

[GitHub] [zeppelin] liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
liuxunorg commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492882297 @Tagar , this new shell interpreter support `Kerberos auto refresh`, but not support `interpolations`. I think either use this

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523456 ## File path:

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment

2019-05-15 Thread GitBox
zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get available HostAddress in multi-NIC environment URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523426 ## File path:

I have refactored the shell interpreter, welcome comments

2019-05-15 Thread Xun Liu
Hi Folks, The current shell interpreter functionality is simple. Execute a command, Session does not record the status after executing the command, You can only enter all the commands in one paragraph. There is no way to explore on a command-by-command basis. Now the shell interpreter can't

[jira] [Created] (ZEPPELIN-4161) Add travis job for default build

2019-05-15 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-4161: Summary: Add travis job for default build Key: ZEPPELIN-4161 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4161 Project: Zeppelin Issue Type:

[GitHub] [zeppelin] Leemoonsoo commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
Leemoonsoo commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492652747 I can think a use case, such as ``` %sh # download some data curl -O http:// # extract tar -xzf

[GitHub] [zeppelin] zjffdu commented on issue #3360: [ZEPPELIN-4152]. Use spark 2.2 as the default profile

2019-05-15 Thread GitBox
zjffdu commented on issue #3360: [ZEPPELIN-4152]. Use spark 2.2 as the default profile URL: https://github.com/apache/zeppelin/pull/3360#issuecomment-492656521 Unfortunately, spark 2.3 doesn't support scala 2.10 which is default profile.

[GitHub] [zeppelin] FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492659189 We are using %sh pretty much exactly like @Leemoonsoo described it above. I think this is a really cool feature, but I don't think it