[GitHub] [zeppelin] zjffdu commented on a change in pull request #4310: [ZEPPELIN-5670] Frontend CI fails

zjffdu commented on a change in pull request #4310: URL: https://github.com/apache/zeppelin/pull/4310#discussion_r827627948 ## File path: .github/workflows/frontend.yml ## @@ -105,17 +105,21 @@ jobs: activate-environment: python_3_with_R environment-file:

[GitHub] [zeppelin] zjffdu commented on pull request #4313: [ZEPPELIN-5678] Remove the wordcount init job in Flink yarn-application mode

zjffdu commented on pull request #4313: URL: https://github.com/apache/zeppelin/pull/4313#issuecomment-1068646655 Thanks for the review @jongyoul , will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (ZEPPELIN-5680) Remove spark-dependencies module

Jeff Zhang created ZEPPELIN-5680: Summary: Remove spark-dependencies module Key: ZEPPELIN-5680 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5680 Project: Zeppelin Issue Type:

[GitHub] [zeppelin] zjffdu commented on pull request #4311: [ZEPPELIN-5671] Split spark-integration-test to hadoop2 and hadoop3

zjffdu commented on pull request #4311: URL: https://github.com/apache/zeppelin/pull/4311#issuecomment-1068658648 Thanks for review, @Reamer Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] jongyoul commented on pull request #4302: [ZEPPELIN-5665] rework xml factory

jongyoul commented on pull request #4302: URL: https://github.com/apache/zeppelin/pull/4302#issuecomment-1067596289 I've missed it. Thank you for merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zeppelin] iiiusky commented on a change in pull request #4282: [ZEPPELIN-5624] Check if the path directory is compliant.

iiiusky commented on a change in pull request #4282: URL: https://github.com/apache/zeppelin/pull/4282#discussion_r826607894 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java ## @@ -1038,8 +1038,10 @@ private boolean

[GitHub] [zeppelin] zjffdu opened a new pull request #4312: [ZEPPELIN-5616] Exception message is repeated when failed to launch interpreter process

zjffdu opened a new pull request #4312: URL: https://github.com/apache/zeppelin/pull/4312 ### What is this PR for? Wrap the cause exception to InterpreterException ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

zjffdu commented on a change in pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294#discussion_r826650446 ## File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java ## @@ -17,6 +17,7 @@ package

[GitHub] [zeppelin] saLeox commented on pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

saLeox commented on pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294#issuecomment-1067650086 @zjffdu Hi, any further feedback or concern regarding this PR? The integrated test seems running well after the rebase. -- This is an automated message from the Apache Git

[jira] [Created] (ZEPPELIN-5678) Remove the wordcount init job in Flink yarn-application mode

Jeff Zhang created ZEPPELIN-5678: Summary: Remove the wordcount init job in Flink yarn-application mode Key: ZEPPELIN-5678 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5678 Project: Zeppelin

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4282: [ZEPPELIN-5624] Check if the path directory is compliant.

zjffdu commented on a change in pull request #4282: URL: https://github.com/apache/zeppelin/pull/4282#discussion_r826639227 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java ## @@ -1038,8 +1038,10 @@ private boolean

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

zjffdu commented on a change in pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294#discussion_r826648694 ## File path: spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java ## @@ -68,6 +68,7 @@ private static AtomicInteger

[GitHub] [zeppelin] zjffdu opened a new pull request #4313: [ZEPPELIN-5678] Remove the wordcount init job in Flink yarn-application mode

zjffdu opened a new pull request #4313: URL: https://github.com/apache/zeppelin/pull/4313 ### What is this PR for? The cause is that in the yarn-application, StreamExecutionEnvironment#execute(StreamGrpah) is invoked when calling TableEnvironment#execute. But we didn't

[GitHub] [zeppelin] zjffdu opened a new pull request #4311: [ZEPPELIN-5671] Split spark-integration-test to hadoop2 and hadoop3

zjffdu opened a new pull request #4311: URL: https://github.com/apache/zeppelin/pull/4311 ### What is this PR for? Trivial PR to split spark-integration-test to hadoop2 and hadoop3 ### What type of PR is it? [Improvement ] ### Todos * [ ] - Task ### What is

[GitHub] [zeppelin] Reamer commented on pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

Reamer commented on pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294#issuecomment-1067658762 > @Reamer Hi, do you have time to have another round of review? I'm afraid I can't do a code review here, as I'm not familiar with this part of the code. -- This is

[GitHub] [zeppelin] saLeox commented on pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

saLeox commented on pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294#issuecomment-1067690614 @zjffdu Thanks for the comments, I will commit and rebase again accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] Reamer commented on a change in pull request #4310: [ZEPPELIN-5670] Frontend CI fails

Reamer commented on a change in pull request #4310: URL: https://github.com/apache/zeppelin/pull/4310#discussion_r826784211 ## File path: .github/workflows/frontend.yml ## @@ -105,17 +105,21 @@ jobs: activate-environment: python_3_with_R environment-file:

[GitHub] [zeppelin] zjffdu commented on pull request #4310: [ZEPPELIN-5670] Frontend CI fails

zjffdu commented on pull request #4310: URL: https://github.com/apache/zeppelin/pull/4310#issuecomment-1067646137 @Reamer Could you help review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zeppelin] zjffdu closed pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

zjffdu closed pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zjffdu commented on pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

zjffdu commented on pull request #4294: URL: https://github.com/apache/zeppelin/pull/4294#issuecomment-1067656146 @saLeox Sorry for late response, just a few minor comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] pjfanning opened a new pull request #4314: [ZEPPELIN-5679] don't remove dir in some cases

pjfanning opened a new pull request #4314: URL: https://github.com/apache/zeppelin/pull/4314 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide -

[jira] [Created] (ZEPPELIN-5679) tidy up inlineRemove in InterpreterSettingManager

PJ Fanning created ZEPPELIN-5679: Summary: tidy up inlineRemove in InterpreterSettingManager Key: ZEPPELIN-5679 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5679 Project: Zeppelin

[GitHub] [zeppelin] Reamer commented on pull request #4314: [ZEPPELIN-5679] don't remove dir in some cases

Reamer commented on pull request #4314: URL: https://github.com/apache/zeppelin/pull/4314#issuecomment-1068069920 Relates with #4282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] pjfanning closed pull request #4314: [ZEPPELIN-5679] don't remove dir in some cases

pjfanning closed pull request #4314: URL: https://github.com/apache/zeppelin/pull/4314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] pjfanning commented on pull request #4314: [ZEPPELIN-5679] don't remove dir in some cases

pjfanning commented on pull request #4314: URL: https://github.com/apache/zeppelin/pull/4314#issuecomment-1068075344 Thanks @Reamer - I'll close this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] Reamer commented on pull request #4305: [ZEPPELIN-5648] log4j.properties is not configured properly for spark interpreter

Reamer commented on pull request #4305: URL: https://github.com/apache/zeppelin/pull/4305#issuecomment-1068093786 Thanks for the screenshots. I think that the line number `:57` is very confusing. We should remove the line number of `Logging.scala` as well. In addition, it seems that

[GitHub] [zeppelin] Reamer edited a comment on pull request #4314: [ZEPPELIN-5679] don't remove dir in some cases

Reamer edited a comment on pull request #4314: URL: https://github.com/apache/zeppelin/pull/4314#issuecomment-1068069920 Relates with #4282 As you can read in PR #4282 another solution is preferred. -- This is an automated message from the Apache Git Service. To respond to the