[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

jongyoul commented on code in PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244500227 ## zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java: ## @@ -1497,4 +1530,78 @@ private boolean checkPermission(String noteId,

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

jongyoul commented on code in PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244498036 ## zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java: ## @@ -1192,24 +1203,38 @@ public void moveFolderToTrash(String folderPath,

[GitHub] [zeppelin] jongyoul commented on pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

jongyoul commented on PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1610385548 BTW, there are no tests for the features. Could you please add tests for your feature? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] Reamer commented on pull request #4621: [ZEPPELIN-5933] Polish jetty

Reamer commented on PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#issuecomment-1608925309 > is `web.xml` needed? I think so. I don't think the context is currently being used anywhere. ``` configuration deployment ``` but the

[GitHub] [zeppelin] Reamer merged pull request #4621: [ZEPPELIN-5933] Polish jetty

Reamer merged PR #4621: URL: https://github.com/apache/zeppelin/pull/4621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] idzikovsky commented on pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

idzikovsky commented on PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1609093390 Issues in my last comment were resolved in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use