[GitHub] zeppelin pull request #2038: ZEPPELIN-1999 get interpreter property with rep...

2017-02-20 Thread masyan
GitHub user masyan opened a pull request: https://github.com/apache/zeppelin/pull/2038 ZEPPELIN-1999 get interpreter property with replaced context parameters ### What is this PR for? Adds posibility to use context parameters into property of interpreter. ### What type

[GitHub] zeppelin pull request #2038: ZEPPELIN-1999 get interpreter property with rep...

2017-02-20 Thread masyan
Github user masyan closed the pull request at: https://github.com/apache/zeppelin/pull/2038 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2046: [ZEPPELIN-1999] get interpreter property with r...

2017-02-20 Thread masyan
GitHub user masyan opened a pull request: https://github.com/apache/zeppelin/pull/2046 [ZEPPELIN-1999] get interpreter property with replaced context parameters ### What is this PR for? Adds posibility to use context parameters (types: String.class, Double.class, Float.class

[GitHub] zeppelin pull request #2046: [ZEPPELIN-1999] get interpreter property with r...

2017-02-20 Thread masyan
Github user masyan closed the pull request at: https://github.com/apache/zeppelin/pull/2046 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2047: [ZEPPELIN-1999] get interpreter property with r...

2017-02-20 Thread masyan
GitHub user masyan opened a pull request: https://github.com/apache/zeppelin/pull/2047 [ZEPPELIN-1999] get interpreter property with replaced context parameters ### What is this PR for? Adds posibility to use context parameters (types: String.class, Double.class, Float.class

[GitHub] zeppelin pull request #2047: [ZEPPELIN-1999] get interpreter property with r...

2017-02-20 Thread masyan
Github user masyan closed the pull request at: https://github.com/apache/zeppelin/pull/2047 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2078: [ZEPPELIN-1988] add property "precode" to JDBCInterpre...

2017-03-03 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2078 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2096 I think this is a good idea. I'm trying to implement this and test task [#2085](https://github.com/apache/zeppelin/pull/2085) --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2096 @Leemoonsoo Although probably implement hooks to do this properly. This may confuse the user. If he is going to register these hooks in their paragraphs, and they will not work (because they

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2096 @Leemoonsoo so not working as I expected, method open not runs (in RemoteInterpreterServer). need to better understand the circuit how it works --- If your project is set up for it, you can

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2096 close works, but open not. I don't understad why. Maybe run in if (!lazy.isOpen()) { lazy.open(); interpreter.interpret(interpetator.getProperty(propert

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2096 and InterpreterContext is unavailable in method close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2158: [ZEPPELIN-2279] excluded comments from SQL

2017-03-22 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2158 @felixcheung falls because ";" is delimiter query and after split generated two queries ("/* ", "*/ select ...") I relied on the standards for SQL89,

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-03-23 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2134 @AhyoungRyu if you configure the note and working only in report mode then you will not see when the report is incomplete.I can add the close button --- If your project is set up for it, you

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-29 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2428 we already have a check to limit. setMaxRows duplicate it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2731: [ZEPPELIN-3169] Fix maven version set

2018-01-17 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2731 LGTM ---

[GitHub] zeppelin issue #2761: [HOTFIX] Fix spark version mismatch

2018-02-02 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2761 another interpreters have a version 0.9.0-SNAPSHOT, what problem to update? ---

[GitHub] zeppelin issue #2761: [HOTFIX] Fix spark version mismatch

2018-02-02 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2761 For some reason I thought to the master. LGTM ---

[GitHub] zeppelin issue #2760: [WIP] ZEPPELIN-3196. Plugin framework for Zeppelin Eng...

2018-02-03 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2760 @zjffdu a strange description of PR ) ---

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-02-03 Thread masyan
GitHub user masyan opened a pull request: https://github.com/apache/zeppelin/pull/2763 [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpreter ### What is this PR for? New interpreter, SAP BusinessObjects (Universes). See [documentation](https://github.com/masyan/zeppelin

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-04 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @felixcheung there are unit tests for convert queries (from Zeppelin format to SAP format) and unit tests for auto completeion. ---

[GitHub] zeppelin issue #2768: ZEPPELIN-3142. Fixed Checkstyle errors and warnings in...

2018-02-06 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2768 you can reopen PR (for update jenkins status) ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-08 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 Ready to review ---

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-02-09 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2782 there is Title of paragraph for that ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-12 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @zjffdu @felixcheung do you have any other questions? ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-15 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @Leemoonsoo @felixcheung @zjffdu if no more questions maybe merge it? ---

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-02-16 Thread masyan
Github user masyan closed the pull request at: https://github.com/apache/zeppelin/pull/2763 ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-16 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 need to specify the format of the "Combined filters (and/or)" ---

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-02-19 Thread masyan
GitHub user masyan reopened a pull request: https://github.com/apache/zeppelin/pull/2763 [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpreter ### What is this PR for? New interpreter, SAP BusinessObjects (Universes). See [documentation](https://github.com/masyan/zeppelin

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-19 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @Leemoonsoo okay, I had one question in support of SAP, but they don't answer ---

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-02-19 Thread masyan
GitHub user masyan reopened a pull request: https://github.com/apache/zeppelin/pull/2763 [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpreter ### What is this PR for? New interpreter, SAP BusinessObjects (Universes). See [documentation](https://github.com/masyan/zeppelin

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-02-19 Thread masyan
Github user masyan closed the pull request at: https://github.com/apache/zeppelin/pull/2763 ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-19 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 CI green https://travis-ci.org/masyan/zeppelin/builds/342323724 ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-20 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @Leemoonsoo found bug of parser ---

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-02-20 Thread masyan
Github user masyan closed the pull request at: https://github.com/apache/zeppelin/pull/2763 ---

[GitHub] zeppelin pull request #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe i...

2018-03-01 Thread masyan
GitHub user masyan reopened a pull request: https://github.com/apache/zeppelin/pull/2763 [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpreter ### What is this PR for? New interpreter, SAP BusinessObjects (Universes). See [documentation](https://github.com/masyan/zeppelin

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-03-01 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @Leemoonsoo I fixed the parser. CI red because of unrelated code. Ready to merge ---

[GitHub] zeppelin issue #2830: [HOTFIX] Fix branch-0.8 build

2018-03-03 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2830 LGTM ---

[GitHub] zeppelin issue #2828: [ZEPPELIN-3283] Remove redundant method InterpreterOut...

2018-03-03 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2828 LGTM ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-03-04 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2763 @Leemoonsoo https://issues.apache.org/jira/secure/ViewProfile.jspa?name=masyan ---

[GitHub] zeppelin issue #2845: ZEPPELIN-3304. Move sap module before zeppelin-distrib...

2018-03-06 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2845 thx. LGTM ---

[GitHub] zeppelin issue #2879: [HOTFIX] Codestyle fix for branch-0.8

2018-03-18 Thread masyan
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2879 LGTM ---