[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-31 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 I can have a go at creating/updating the documentation if someone can help me with any guideance on where/how to begin. My familiarity with Jupyter is very limited, so while I

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Please let me know if there are any further comments or concerns @felixcheung. I have addressed the suggestion on structure of the code in the documentation ([here](https://github.com

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-11 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 @felixcheung I have added a couple of paragraphs of documentation including an example showing interaction between the Scala and SQL interpreters to _spark.md_ (at the end of the text

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

2017-08-17 Thread sanjaydasgupta
Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

2017-08-17 Thread sanjaydasgupta
GitHub user sanjaydasgupta reopened a pull request: https://github.com/apache/zeppelin/pull/2502 [ZEPPELIN-2807] Passing Z variables to SQL Interpreter (One part of ZEPPELIN-1967) ### What is this PR for? This feature allows embedding/interpolating Z variables into SQL

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-17 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Thanks for the catch # @Leemoonsoo I have fixed and committed the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 I would like your views @felixcheung @zjffdu @Tagar on the following approach to escaping and regex errors etc: I wish to suggest that no escaping is needed, as the substitution

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-28 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Agreed, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Thank you for the observations @felixcheung. Will review these points and make suitable changes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 The choice of {...} for identifying parameter/variable names comes from the parent issue [ZEPPELIN-1967](https://issues.apache.org/jira/browse/ZEPPELIN-1967). Though #{...} seems more

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

2017-07-24 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2502 [ZEPPELIN-2807] Passing Z variables to SQL Interpreter (One part of ZEPPELIN-1967) ### What is this PR for? This feature allows embedding/interpolating Z variables into SQL

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-30 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Digging a little deeper to clarify the conflict ... The class `BaseZeppelinContext` uses two different key-value repositories for two different needs: 1. **Storage of user

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-29 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Hello @felixcheung @Tagar @zjffdu, this is for any further comments and suggestions. Here are the features implemented: 1. - The substitution pattern is `{ ... }` as suggested

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-27 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Thank you for the insight. Do you think we may retain variable substitution within literal strings as in the following contrived example? `%sql select * from spares where part_no

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Allow me to take your suggestions from last to first @felixcheung I have tested a variant of the function [interpolateVariable(...)](https://github.com/apache/zeppelin/pull/2502

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-20 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Thanks for the suggestions @felixcheung I was not able to find more documentation on Jupyter's feature, but tried it with many different variants. There are some behaviors

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 I had not thought about that @Leemoonsoo, thanks for alerting me to it. As the code now stands (in relation to [Interpreter.java](https://github.com/apache/zeppelin/blob/master

[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...

2017-09-04 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2521 This implementation has a harmful side effect that can break existing notebooks. The problem with this fix is that it changes the meaning of all relative path-names used in any

[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...

2017-09-05 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2521 I have not looked at the code in detail, so will refrain from making suggestions about the code :-) ---

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

2017-09-25 Thread sanjaydasgupta
Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2502 ---

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-25 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Would like to hear about any further improvements required on this feature @felixcheung, @Leemoonsoo Thanks for your thoughts @Tagar --- If your project is set up for it, you

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-28 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 @felixcheung - We've exchanged many ideas back and forth on this PR to the point where it has become more of a discussion document than a software submission :-) I'm in favor

[GitHub] zeppelin pull request #2960: [Zeppelin 3388] Correcting documentation link t...

2018-05-04 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2960 [Zeppelin 3388] Correcting documentation link to zeppelin-context documentation ### What is this PR for? A small change was needed in the documentation of the JDBC interpreter also

[GitHub] zeppelin issue #2960: [Zeppelin 3388] Correcting documentation link to zeppe...

2018-05-05 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2960 Yes @felixcheung the other links are ok. ---

[GitHub] zeppelin pull request #2967: [ZEPPELIN-3438] Passing Z variables to BigQuery...

2018-05-13 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2967 [ZEPPELIN-3438] Passing Z variables to BigQuery interpreter ### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-27 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Hi @felixcheung is it possible to release this into 0.8.0? Thanks ---

[GitHub] zeppelin issue #2960: [Zeppelin 3388] Correcting documentation link to zeppe...

2018-05-10 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2960 Hi @felixcheung could you release this into the next RC for 0.8.0? Thanks. ---

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-22 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 Done. Also used more formal way of creating the temporary file. I've tested the integrated code on Ubuntu 16.04 - success case only :-) but am not sure how things will work

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-23 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 Added code to delete the temp file if the write fails. Re-throwing the exception serves two purposes: 1) Ensure that the caller sees the same exception when the write fails

[GitHub] zeppelin pull request #2978: [ZEPPELIN-3467] two-step, atomic configuration ...

2018-05-22 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2978 [ZEPPELIN-3467] two-step, atomic configuration file writes ### What is this PR for? This PR prevents the total loss of configuration information that happens when zeppelin attempts

[GitHub] zeppelin pull request #3013: [ZEPPELIN-3511] remove old button "Download Dat...

2018-06-09 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/3013 [ZEPPELIN-3511] remove old button "Download Data as CSV/TSV" ### What is this PR for? This PR removes the legacy method (button and dropdown near the top left of each

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 Please see my suggestion (described above) implemented in the image below. The legacy method's button (with the very familiar download icon) has been retained with a different tool-tip

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 Thanks for the input @prabhjyotsingh. Allow me to list the advantages of both methods, and to suggest a possible way forward for your consideration. 1) **The legacy

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-06-17 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 ping @felixcheung ---

[GitHub] zeppelin pull request #3027: [ZEPPELIN-2605] Import notebook has 1MB size li...

2018-06-18 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/3027 [ZEPPELIN-2605] Import notebook has 1MB size limit but bigger notebooks can be saved without error or warning ### What is this PR for? Notebooks of any size can be exported and saved

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 Thanks @prabhjyotsingh. I will wait for a clear common view before making any further changes. ---

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-06-07 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 @Tagar thanks for your comments. The thought here was to make the best of a bad situation. If and when the `delete()` fails, no recovery action is possible at the user level. So

[GitHub] zeppelin issue #2992: [HOTFIX] change string true to boolean true

2018-05-31 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2992 @zjffdu, there are a few other interpreters that have `interpreter-setting.json` files with such boolean values in strings. Is it useful to open a JIRA for those others interpreter-setting

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-31 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 Hi @zjffdu, can you please confirm if anything more remains to be done in [FileSystemStorage.writeFile](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-27 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 @felixcheung have made the suggested changes. But am not sure how to add tests for this. Any hints will be useful. @zjffdu, @Tagar do you recommend similar treatment

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-29 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 Hi @zjffdu While reading the code of `FileSystemConfigStorage.java`, I noticed that the method `save(...)` delegates its work to `FileSystemStorage.writeFile(...)`. Interestingly

[GitHub] zeppelin pull request #2978: [ZEPPELIN-3467] two-step, atomic configuration ...

2018-06-01 Thread sanjaydasgupta
Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2978 ---

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-06-01 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 There is a problem in my repo that needs correction. I am closing this PR now, and will reopen it later if possible, or return with a new PR. ---

[GitHub] zeppelin issue #2967: [ZEPPELIN-3438] Passing Z variables to BigQuery interp...

2018-06-01 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2967 Need to make corrections in my repo, so am closing this PR now. Will be back with a new PR later. ---

[GitHub] zeppelin pull request #2967: [ZEPPELIN-3438] Passing Z variables to BigQuery...

2018-06-01 Thread sanjaydasgupta
Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2967 ---

[GitHub] zeppelin pull request #2998: [ZEPPELIN-3522] String "defaultValue" instead o...

2018-06-01 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2998 [ZEPPELIN-3522] String "defaultValue" instead of boolean in some "interpreter-settings.json" files ### What is this PR for? The _interpreter-settings.json_ file

[GitHub] zeppelin issue #2992: [HOTFIX] change string true to boolean true

2018-06-01 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2992 Done, please check: https://issues.apache.org/jira/browse/ZEPPELIN-3522 and https://github.com/apache/zeppelin/pull/2998 ---

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-06-07 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 Agreed @zjffdu. I also made two other (similar) changes. If the `tempFile.delete()` fails, then `tempFile.deleteOnExit()` is invoked to request the system to handle it if possible

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-31 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2978 Hi @felixcheung, @Tagar Any suggestions on how to push this forward from here? Thanks ---

[GitHub] zeppelin issue #2998: [ZEPPELIN-3522] String "defaultValue" instead of boole...

2018-06-01 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2998 I had to recycle my fork, and had forgotten to link up Travis again. It's been done now. The errors appear unrelated to the changes in this PR. Thanks. ---

[GitHub] zeppelin pull request #3000: [ZEPPELIN-3467] two-step, atomic configuration ...

2018-06-01 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/3000 [ZEPPELIN-3467] two-step, atomic configuration file ### What is this PR for? This PR continues the discussion and implementation in [PR-2978](https://github.com/apache/zeppelin/pull

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-07-02 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 @jongyoul I agree. Will return to this in a day or two. ---

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-27 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 @jongyoul, @Tagar, could you please confirm my understanding of your suggestions below: 1) The old button should **not** be removed. It should retain its visual form and function

[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...

2018-06-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3027 Hi Jeff, The window is popped up only when the user tries to export a notebook that would be more than 1Mb in size. The problem with such a notebook (greater than 1Mb

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-20 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 Thanks for the ideas @Tagar If we focus on long term advantages and stability, then continuing to maintain the old button will be a disadvantage. If the old button is retained

[GitHub] zeppelin issue #2953: [Zeppelin 3388] Refactor documentation for ZeppelinCon...

2018-05-01 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2953 This is how it looks when squeezed into a really narrow space: ![image](https://user-images.githubusercontent.com/477015/39469290-1a0e6f5e-4d55-11e8-984f-77814ee034b4.png

[GitHub] zeppelin pull request #2953: [Zeppelin 3388] Refactor documentation for Zepp...

2018-04-29 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2953 [Zeppelin 3388] Refactor documentation for ZeppelinContext ### What is this PR for? This PR is a refactoring of the `ZepplinContext` documentation. The description

[GitHub] zeppelin issue #2953: [Zeppelin 3388] Refactor documentation for ZeppelinCon...

2018-04-30 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2953 Hi @felixcheung, have addressed your comments above. Documentation written by a worldwide team of contributors can be notoriously ambiguous, and am happy to get a thorough review

[GitHub] zeppelin issue #3108: ZEPPELIN-3678. Change SparkZeppelinContext to scala im...

2018-08-02 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3108 Hi @zjffdu I have added a couple of simple suggestions to the Scala code. ---

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 Thanks for pointing out the issue @felixcheung I've corrected the link as well as some of the preceding words as the ZeppelinContext documentation is now in its own page

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 The two failed tests on travis - apparently unrelated to the code from this PR - are really stubborn and wont go away no matter what I do! ---

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 This is a great idea @zjffdu. There are also a few other things to think of - like automatically generating the name of the enabler parameter on a per-interpreter basis

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 Thanks for the suggestion @zjffdu. The same idea was given earlier by Leemoonsoo [here](https://github.com/apache/zeppelin/pull/2502#issuecomment-323272122), and I had

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-07-08 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 I have been a little busy @jongyoul, but have not forgotten it ;-) Will be done today. Thanks. ---

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-07-10 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 Hi @jongyoul one test is still red. I have restarted it 3 times, but it has failed with the same result each time. Please let me know if there is anything else to try. ---

[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...

2018-07-10 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3027 ping @jongyoul ---

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-07-10 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 Cleaning the cache helped. Thanks for the hint @zjffdu All green now @jongyoul ---

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-07-06 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 I've fixed the style issues pointed out. One test still fails on travis--despite a rebase and restart. But the failure seems unrelated to the changes made in this PR. ---

[GitHub] zeppelin pull request #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery...

2018-07-13 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/3068 [ZEPPELIN-3438] Passing Z variables to BigQuery ### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of BigQuery cells

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

2018-07-12 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3065 This will also make it possible to access paragraph results easily using the z-variable interpolation feature of various interpreters. So a simple command like `%sh echo {population-table

[GitHub] zeppelin issue #3064: [ZEPPELIN-3596] Saving resources from pool to SQL

2018-07-12 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3064 There are similarities between the two features that all users will notice, and think about for some time. There needs to be good documentation to avoid any confusion. The substitution

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-07-09 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 @jongyoul the merge occurred by mistake, and I am not being able to revert it using the `git revert -m 1 ` command. I've tried looking up all help on the net, but am not getting

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-07-09 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3000 @jongyoul please ignore my previous comments (now deleted) The rebase has been done. ---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-12 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 Hi @felixcheung @Tagar @zjffdu @Leemoonsoo I have taken care of all the ideas and concerns expressed earlier (in the closed [PR-2502](https://github.com/apache/zeppelin/pull/2502

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-06 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 @felixcheung Please note [my response](https://github.com/apache/zeppelin/pull/2903#discussion_r178733031) to your earlier question about the unrelated documentation change

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-08 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 @felixcheung I've fixed the 4 issues in the documentation file jdbc.md, thanks for the very careful review. I have also added a unit test [JDBCInterpreterInterpolationTest.java

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-11 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Oops! I must have messed up somewhere! I've corrected the style issues now @felixcheung, and the one remaining failure appears to be a build script problem unrelated to my code

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-08 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Apologies for missing the check style errors @felixcheung The style issues in _JDBCInterpreterInterpolationTest.java_ have been removed, and all the tests now pass. The other

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-10 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Hi @felixcheung, can these changes be merged now? ---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-22 Thread sanjaydasgupta
Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2903 ---

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-22 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Closing and reopening to trigger tests. ---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-22 Thread sanjaydasgupta
GitHub user sanjaydasgupta reopened a pull request: https://github.com/apache/zeppelin/pull/2903 [ZEPPELIN-3377] Passing Z variables to JDBC interpreter ### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 ping @felixcheung ---

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

2018-04-22 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Hi @felixcheung please let me know if any additional changes or adjustments are needed. The two failing tests are unrelated to the code in in this PR Thanks. ---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 @felixcheung following [the earlier discussion](https://github.com/apache/zeppelin/pull/2834#discussion_r176976263), the _propertyName_ field in both _interpreter-setting.json_ files have

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-25 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 Hello reviewers, this PR has accumulated many ideas from the wisdom of its past and present reviewers (@zjffdu @felixcheung @Tagar @Leemoonsoo ), and it would be interesting to see how

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-25 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 @zjffdu Thanks for your review - that was very helpful. Have fixed all the issues - please see [details added after your comment](https://github.com/apache/zeppelin/pull/2834/files

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-02 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2903 [ZEPPELIN-3377] Passing Z variables to JDBC interpreter ### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 Here is one approach: define two new [zeppelin configurable properties](http://zeppelin.apache.org/docs/latest/install/configuration.html) as follows: 1) A boolean property named

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 I have added code, documentation, and configuration-template files for a single environment-variable named `ZEPPELIN_INTERPRETER_INTERPOLATION` (and a corresponding java-property

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 Thanks for your review @felixcheung The 3 points have been addressed as described individually above. ---

[GitHub] zeppelin pull request #2834: [ZEPPELIN-1967] Passing Z variables to Shell an...

2018-03-04 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2834 [ZEPPELIN-1967] Passing Z variables to Shell and SQL Interpreters ### What is this PR for? The code in this PR enables embedding/interpolating Z variables into command strings

[GitHub] zeppelin pull request #2825: [ZEPPELIN-1967]: New pull request

2018-03-02 Thread sanjaydasgupta
Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2825 ---

[GitHub] zeppelin issue #2825: [ZEPPELIN-1967]: New pull request

2018-03-02 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2825 Created from wrong branch in source repo. Need to correct branch and reissue. ---

[GitHub] zeppelin pull request #2825: [ZEPPELIN-1967]: New pull request

2018-03-01 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request: https://github.com/apache/zeppelin/pull/2825 [ZEPPELIN-1967]: New pull request ### What is this PR for? The code in this PR enables embedding/interpolating Z variables into command strings passed to Spark's SQL and Shell

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-10-14 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 As suggested by @jongyoul earlier, a mail was sent out to the dev list on 9th July 2018 with this subject: Should we remove "Download Data as CSV/TSV" button from ver

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-10-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3013 Allow me to remind you of the history of this PR: 1) There was an [initial commit](https://github.com/apache/zeppelin/pull/3013/commits/cabb83e82a2e77326e214a6e506e53f6fb00ff07