[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-08-29 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1381 [ZEPPELIN-1390] SparkInterpreter does not work for Spark2 version of HDP 2.5 ### What is this PR for? Spark2 version of HDP 2.5 is "2.0.0.2.5.0.0-1245". Currently, Zeppelin p

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-08-29 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1381 I upgraded HDP to 2.5 from 2.4 today. sc.version printed 1.6.1 when HDP 2.4 and now HDP 2.5 spark.version prints 2.0.0.2.5.0.0-1245 --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-08-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1381 @Leemoonsoo Thanks for comment! I made some changes. How does it look? Thanks again. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-09-01 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1381 [ZEPPELIN-1390] SparkInterpreter does not work for Spark2 version of HDP 2.5 ### What is this PR for? Spark2 version of HDP 2.5 is "2.0.0.2.5.0.0-1245". Currently, Zeppelin p

[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-09-01 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-09-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1381 @Leemoonsoo Yep, I did it :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-09-03 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1381 [ZEPPELIN-1390] SparkInterpreter does not work for Spark2 version of HDP 2.5 ### What is this PR for? Spark2 version of HDP 2.5 is "2.0.0.2.5.0.0-1245". Currently, Zeppelin p

[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-09-03 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-09-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1381 @Leemoonsoo Hi, thanks for your guide. I merged master branch, but it failed again. And I tried to build again via reopening, but it fails again as you see. However, it

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-09-04 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1381 Ok thanks Let me know when it is done. I will reopen PR :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-09-08 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1381: [ZEPPELIN-1390] SparkInterpreter does not work ...

2016-09-08 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1381 [ZEPPELIN-1390] SparkInterpreter does not work for Spark2 version of HDP 2.5 ### What is this PR for? Spark2 version of HDP 2.5 is "2.0.0.2.5.0.0-1245". Currently, Zeppelin p

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-09-09 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1381 Thanks everyone! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1525: [ZEPPELIN-1552] Search button goes to next line when d...

2016-10-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1525 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1523: [ZEPPELIN-1550] fixed 'add from URL' button

2016-10-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1523 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1522: [ ZEPPELIN-1461 ] Doesn't display "description" value ...

2016-10-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1522 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1525: [ZEPPELIN-1552] Search button goes to next line when d...

2016-10-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1525 CI is green light! Merge please @AhyoungRyu ! 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1540: [ZEPPELIN-1566] Make paragraph editable with double cl...

2016-10-28 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1540 Wow, this is a really cool feature for me. Thanks! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin pull request #1570: [MINOR] High definition build status badge

2016-10-30 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1570 [MINOR] High definition build status badge ### What is this PR for? CI badge has low definition now. This change will use .svg image as badge (instead of .png!) before: ![image

[GitHub] zeppelin issue #1570: [MINOR] High definition build status badge

2016-10-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1570 Thanks for comment @AhyoungRyu ! I guess CI is in a bad mood today 😄 Do I have to re-trigger CI? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1570: [MINOR] High definition build status badge

2016-10-31 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1570 Thanks @AhyoungRyu ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-10-31 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 Hi @minahlee :) This is a cool feature! I have an experience that deleted output through editing note.json because of huge output stopping Zeppelin web. By the way, I've wanted a ren

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 Thanks @minahlee! I appreciate your kind comment 😄 I created a ticket on JIRA: [ZEPPELIN-1598](https://issues.apache.org/jira/browse/ZEPPELIN-1598) But, I don't know h

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 @minahlee Awesome! I just changed status to `IN PROGRESS` now. Thanks 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 I also tested and was able to reproduce screenshot above. When I was another user, it returned `403` status code with message: ```json {"status":"FORB

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 @anthonycorbacho Nice! I agree with you :) I will open the issue on JIRA. But since I don't know much about the code structure, I may need some help 😃 --- If your project is s

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 @anthonycorbacho Thanks :-) Don't worry! I do this because I want to do 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-02 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 I guess it's same CI error with #1518. There is a log which is: ```bash gzip: stdin: unexpected end of file tar: Unexpected EOF in archive tar: Unexpected EOF in ar

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1578 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 @minahlee I have a question about REST API style. Is there any purpose that you used `PUT` method? In my opinion, `DELETE` method is more proper since it does not `PUT` `clear` under a

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 @minahlee Oh, in that context, it makes sense. LGTM. But, after looking all around Notebook REST API, it works well now but it doesn't seem RESTful. I summarized current list of RES

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 @anthonycorbacho @khalidhuseynov Thanks for the comment! I agree with you guys. This is a breaking change, so yeah we must be careful. So, if we proceed this, new API URL's prefix

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

2016-11-07 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1606 So cl! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1609: [ZEPPELIN-1628] Enable renaming note from the m...

2016-11-07 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1609 [ZEPPELIN-1628] Enable renaming note from the main page ### What is this PR for? Now users can rename a note from the main page! This new feature will improve UX. I divided

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

2016-11-07 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 @AhyoungRyu Thanks for the quick review! You are right! I will fix it. Please wait 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

2016-11-08 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 @AhyoungRyu I fixed it! It took some time to improve UX 😄 Now when an input text is not valid, users can't click the button and the modal shows error me

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2016-11-09 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1339 Tested and worked as expected 😄 Fantastic work! But, there are other benefits caused by this change. Before this change, users couldn't use `SPARK_SUBMIT_OPTIONS` env var

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

2016-11-09 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 CI is green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1609: [ZEPPELIN-1628] Enable renaming note from the main pag...

2016-11-09 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 @AhyoungRyu Thanks for the review! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1615: [ZEPPELIN-1644] make document easier to follow key ins...

2016-11-09 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1615 @Leemoonsoo Nice! When I was at Zeppelin meetup, every beginner tried to build Zeppelin. Because they didn't know about existence of Zeppelin binary :-) So I suggest adding a link to

[GitHub] zeppelin issue #1627: [ZEPPELIN-1658] Big download button and display packag...

2016-11-13 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1627 LGTM! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-14 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin issue #1634: [MINOR] Add markdown escaping to find missing parts

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1634 LGTM! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 Fixed error and CI is green! Ready for review! 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1639: [ZEPPELIN-1667] add support for es6

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1639 Nice move! 😄 I've always wanted to use ES6. I tested and everything worked as expected. But it seems like you turned off opening a browser when livereload serve

[GitHub] zeppelin issue #1639: [ZEPPELIN-1667] add support for es6

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1639 @1ambda +1 for webpack --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1639: [ZEPPELIN-1667] add support for es6

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1639 @felizbear That makes sense! Then it's ok with me :) I tested three commands (`serve` `test` `build`) and also worked with me. I had removed `bower_components` and `node_mo

[GitHub] zeppelin issue #1639: [ZEPPELIN-1667] add support for es6

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1639 @felizbear Of course! But I do not completely understand about Zeppelin's Travis CI, so we gonna need some help from committers 😄 Oh, it just failed again with the same error. Bu

[GitHub] zeppelin issue #1645: [ZEPPELIN-1671] Conda interpreter

2016-11-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1645 @Leemoonsoo Awesome! I will test it after updating the doc. By the way, can I list installed packages of conda? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...

2016-11-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1649 @1ambda Nice catch! Does that happen in IE? Because my Zeppelin didn't happen that way :) I use Macbook Pro and tested on Chrome, Safari, and Firefox. --- If your proje

[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...

2016-11-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1649 @1ambda I just built Zeppelin from master branch and took screenshots :) ### Chrome secret tab: ![image](https://cloud.githubusercontent.com/assets/8201019/20390773/ab0ea1b0-ad13-11e6

[GitHub] zeppelin issue #1651: [ZEPPELIN-1681] - Fix note permission settings order

2016-11-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1651 This makes sense 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...

2016-11-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1649 ### OS: ![image](https://cloud.githubusercontent.com/assets/8201019/20391115/52a00ba2-ad15-11e6-849e-17170f0cd893.png) ### Chrome: 54.0.2840.98 (64-bit) Maybe because of

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Thanks for review 😄 Don't need to hurry! I will check and ping you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-18 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu ping ping~ I tested! ![rename_folder_for_rootdir](https://cloud.githubusercontent.com/assets/8201019/20429568/d3cde876-add2-11e6-8638-5ae0ed1357a7.gif) But it just

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2016-11-18 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1339 @AhyoungRyu Thanks for taking care of my feedback 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-19 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Thanks for your kind review. I appreciate it. Actually, I didn't test with Shiro ^^; and didn't know what `op` parameter means. So thanks very much.

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-19 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-19 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-20 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Thanks! I also think `notebook` is a little bit weird :) I merged your PR thanks. This change will affect other insufficient privileges error messages as well

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-20 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu I fixed what you mentioned 😄 Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-20 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 I guess CI fails because it only recompiles changed files. (since build time is too short) ![image](https://cloud.githubusercontent.com/assets/8201019/20465314/5fbd31d6-af9d-11e6-9d55

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

2016-11-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1606 @giaosudau Hi! Thanks for sharing the issue :) Could you please share your building command line and error log? I don't know why, but I guess MathJax library wasn't

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

2016-11-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1606 @giaosudau Thanks for the prompt response! So you mean it doesn't happen without ZEPPELIN_SERVER_CONTEXT_PATH? I've never used that option so I might not be helpful ^^;

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

2016-11-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1606 @giaosudau You clarified the issue! Would you like to create a [JIRA](https://issues.apache.org/jira/browse/ZEPPELIN) ticket for that? :-) Then other developers will see the issue. Since this PR

[GitHub] zeppelin issue #1639: [ZEPPELIN-1667] add support for es6

2016-11-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1639 You guys rock! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1671: Clean unnecessary codes

2016-11-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1671 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-23 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-23 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Yeah!!! Finally!!! CI is green!!! It was my fault! I didn't import `Folder` at `zeppelin-server`. (Why was it green before...?) Please take a look! -

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-24 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Fixed what you mentioned :) Always thanks for the review 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1676: [ZEPPELIN-1705] Exclude unnecessary source file...

2016-11-24 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1676 [ZEPPELIN-1705] Exclude unnecessary source file when check style on scio ### What is this PR for? When building Zeppelin with `mvn clean package install -DskipTests -DskipRat`, it fails on

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-24 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-24 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

2016-11-24 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1676 @AhyoungRyu Thanks for the review again! 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

2016-11-24 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1676 @prabhjyotsingh Thanks! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-28 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Sorry for my late response! But it's due to tests :) I reproduced the error you mentioned and you were right! Furthermore, chasing a reason of the error, I notice

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-28 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 CI failure is because of me. I will fix it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

2016-11-28 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1606 @giaosudau Thanks! 👍 I appreciate it 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-29 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Yeah! CI is green 😄 Please review! Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

2016-11-29 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1676 @Nabajyoti001 Thanks for sharing your issue! But it seems irrelevant with this PR. However, of course, that issue should be resolved! Since I could build current master branch

[GitHub] zeppelin pull request #1706: [HOTFIX] Exclude org/apache/zeppelin/scio/avro/...

2016-11-29 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1706 [HOTFIX] Exclude org/apache/zeppelin/scio/avro/* once at pom.xml ### What is this PR for? Previously on #1676, I excluded path **twice**. It's my mistake! @khalidhuseynov pointed tha

[GitHub] zeppelin issue #1706: [HOTFIX] Exclude org/apache/zeppelin/scio/avro/* once ...

2016-11-29 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1706 @zjffdu @khalidhuseynov Thanks! 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1706: [HOTFIX] Exclude org/apache/zeppelin/scio/avro/* once ...

2016-11-29 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1706 @astroshim @Leemoonsoo Thanks for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @soralee Thanks for the review! 😄 That's a great idea! I will give some effect on the front-end and ping you again. Thanks :) --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @soralee Hi! I added the feature you suggested. What do you think? Is title or content of warning message appropriate? Thanks for the cool suggestion! ![rename_folder_merging_warning

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu Always thanks for the review 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1630 [ZEPPELIN-1629] Enable renaming folder from the main page ### What is this PR for? This PR will enable renaming folder from the main page. I wrote some codes. Hope this PR is the

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

2016-11-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu @soralee Yeah! CI is green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

2016-12-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1715 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-02 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 Thanks @Leemoonsoo! I appreciate your review 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

2016-12-02 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1692 @cloverhearts Nice! Hope the new version will be released soon :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-02 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 I've tested more and it was fine most times. But occasionally it doesn't work well. I think it should be tested more! I don't know why for now but I will figure it out and ping

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 I found out bugs by adding loggers and fixed them! CI is green and it seems to work perfectly. I think it's good to go now 😄 Please when you have some time. Thanks! -

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

2016-12-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1723 I tested on Firefox and the error is gone. LGTM 👍 ![image](https://cloud.githubusercontent.com/assets/8201019/20860307/4507f57c-b9b8-11e6-9b15-fd6944ede2d5.png) And I guess

  1   2   3   >