[GitHub] [zeppelin-site] dependabot[bot] opened a new pull request, #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web

2023-09-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/zeppelin-site/pull/1 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from

[GitHub] [zeppelin-site] dependabot[bot] opened a new pull request, #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web

2023-09-10 Thread via GitHub
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/zeppelin-site/pull/2 Bumps [jszip](https://github.com/Stuk/jszip) from 3.1.5 to 3.10.1. Changelog Sourced from https://github.com/Stuk/jszip/blob/main/CHANGES.md;>jszip's changelog. v3.10.1

[GitHub] [zeppelin-site] jongyoul closed pull request #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web

2023-09-10 Thread via GitHub
jongyoul closed pull request #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web URL: https://github.com/apache/zeppelin-site/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin-site] jongyoul closed pull request #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web

2023-09-10 Thread via GitHub
jongyoul closed pull request #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web URL: https://github.com/apache/zeppelin-site/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-01-24 Thread via GitHub
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1402059634 @halfvector @zenozeng @PrabhuJoseph @vineethNaroju I have updated this PR and CI is passed now. Feel free to try it to see whether it solves your problems. -- This is an automated

[GitHub] [zeppelin] Reamer commented on pull request #4545: [ZEPPELIN-5861] Correct shading Prefix

2023-01-23 Thread via GitHub
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1400269014 Can someone do a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-01-23 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400410386 > @huage1994 I think we can proceed with this change. Please rebase your branch to the current master. Thanks @Reamer for reminding!  -- This is an automated message from

[GitHub] [zeppelin] Reamer commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-01-23 Thread via GitHub
Reamer commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400278340 @huage1994 I think we can proceed with this change. Please rebase your branch to the current master. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] jongyoul merged pull request #4545: [ZEPPELIN-5861] Correct shading Prefix

2023-01-23 Thread via GitHub
jongyoul merged PR #4545: URL: https://github.com/apache/zeppelin/pull/4545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #805: ZEPPELIN-580 Add support for multi select in form select box

2023-01-24 Thread via GitHub
jongyoul commented on PR #805: URL: https://github.com/apache/zeppelin/pull/805#issuecomment-1403144355 @ustas4 Thank you for the feedback. BTW, could you please make an issue and share it with user@, dev@, or slack channel? I would be helpful for others to understand the problem. --

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-01-25 Thread via GitHub
zjffdu commented on code in PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#discussion_r1086503324 ## .github/workflows/core.yml: ## @@ -277,10 +277,10 @@ jobs: auto-activate-base: false use-mamba: true - name: run tests for flink before

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

2023-01-26 Thread via GitHub
jongyoul commented on code in PR #4519: URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087820276 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java: ## @@ -242,18 +233,22 @@ public void

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

2023-01-26 Thread via GitHub
jongyoul commented on code in PR #4519: URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087820276 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java: ## @@ -242,18 +233,22 @@ public void

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

2023-01-26 Thread via GitHub
Reamer commented on code in PR #4519: URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087924889 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java: ## @@ -242,18 +233,22 @@ public void

[GitHub] [zeppelin] Reamer commented on pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

2023-01-26 Thread via GitHub
Reamer commented on PR #4519: URL: https://github.com/apache/zeppelin/pull/4519#issuecomment-1404800082 I need a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-01-25 Thread via GitHub
Reamer commented on code in PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#discussion_r1086434414 ## .github/workflows/core.yml: ## @@ -277,10 +277,10 @@ jobs: auto-activate-base: false use-mamba: true - name: run tests for flink before

[GitHub] [zeppelin] zjffdu merged pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-01-31 Thread via GitHub
zjffdu merged PR #4506: URL: https://github.com/apache/zeppelin/pull/4506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-01-31 Thread via GitHub
Reamer commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1410210938 I think we can merge this change and move forward with #4558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] jongyoul commented on pull request #4567: [ZEPPELIN-5882] Upgrade Kotlin interpreter to 1.8.10

2023-03-08 Thread via GitHub
jongyoul commented on PR #4567: URL: https://github.com/apache/zeppelin/pull/4567#issuecomment-1459737471 Is it still in progress? I'm asking because it's still draft pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] jongyoul commented on pull request #4525: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web

2023-03-08 Thread via GitHub
jongyoul commented on PR #4525: URL: https://github.com/apache/zeppelin/pull/4525#issuecomment-1459740582 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] akishichinibu opened a new pull request, #4573: [ZEPPELIN-5888] Upgrade sparql version to 3.17.0

2023-03-06 Thread via GitHub
akishichinibu opened a new pull request, #4573: URL: https://github.com/apache/zeppelin/pull/4573 ### What is this PR for? Zeppelin Interpreter Support SPARQL From 3.12.0 To 3.17.0 ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the

[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4573: [ZEPPELIN-5888] Upgrade sparql version to 3.17.0

2023-03-06 Thread via GitHub
akishichinibu commented on code in PR #4573: URL: https://github.com/apache/zeppelin/pull/4573#discussion_r1127450230 ## sparql/pom.xml: ## @@ -33,7 +33,7 @@ sparql -3.12.0 +3.17.0 Review Comment: The Java 11 is [required since Jena

[GitHub] [zeppelin] Reamer merged pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

2023-03-07 Thread via GitHub
Reamer merged PR #4559: URL: https://github.com/apache/zeppelin/pull/4559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] michaelSaid closed pull request #4574: feat [INC-58754] Incorta notebook base imp

2023-03-12 Thread via GitHub
michaelSaid closed pull request #4574: feat [INC-58754] Incorta notebook base imp URL: https://github.com/apache/zeppelin/pull/4574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4575: Bump jettison from 1.5.2 to 1.5.4

2023-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #4575: URL: https://github.com/apache/zeppelin/pull/4575 Bumps [jettison](https://github.com/jettison-json/jettison) from 1.5.2 to 1.5.4. Release notes Sourced from https://github.com/jettison-json/jettison/releases;>jettison's releases.

[GitHub] [zeppelin] huage1994 merged pull request #4575: Bump jettison from 1.5.2 to 1.5.4

2023-03-24 Thread via GitHub
huage1994 merged PR #4575: URL: https://github.com/apache/zeppelin/pull/4575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4573: [ZEPPELIN-5888] Upgrade sparql version to 3.17.0

2023-03-07 Thread via GitHub
jongyoul commented on PR #4573: URL: https://github.com/apache/zeppelin/pull/4573#issuecomment-1458109071 BTW, is it necessary to keep this interpreter? I don't know about the detail but sometimes I feel like we should think we could maintain this interpreter continuously or not. WDYT?

[GitHub] [zeppelin] Reamer merged pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-03-22 Thread via GitHub
Reamer merged PR #4563: URL: https://github.com/apache/zeppelin/pull/4563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] akishichinibu opened a new pull request, #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-02-22 Thread via GitHub
akishichinibu opened a new pull request, #4568: URL: https://github.com/apache/zeppelin/pull/4568 ### What is this PR for? Zeppelin Interpreter Support InfluxDB From 1.7.0 To 2.3.0 ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the

[GitHub] [zeppelin] phongnt opened a new pull request, #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-26 Thread via GitHub
phongnt opened a new pull request, #4570: URL: https://github.com/apache/zeppelin/pull/4570 ### What is this PR for? Fixed maven build failed on module `zeppelin-server` with profile `hadoop3`. ### What type of PR is it? Bug Fix ### Todos * [ ] Run maven build after

[GitHub] [zeppelin] Reamer commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-27 Thread via GitHub
Reamer commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1446266520 If no further comments are received, I will merge the PullRequest on Wednesday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-27 Thread via GitHub
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1446277819 i able to compile the master branch after your patching, but when i start python notebook example, run below cell ``` %python.ipython import sys sys? ``` i get

[GitHub] [zeppelin] zjffdu merged pull request #4566: [MINOR] Use flink-113 as default profile

2023-02-17 Thread via GitHub
zjffdu merged PR #4566: URL: https://github.com/apache/zeppelin/pull/4566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] canhtran opened a new pull request, #4572: [MINOR] Update doc for flink 1.16

2023-03-02 Thread via GitHub
canhtran opened a new pull request, #4572: URL: https://github.com/apache/zeppelin/pull/4572 ### What is this PR for? Update the Flink interpreter documentation to adapt with Flink 1.16 and above ### What type of PR is it? Documentation ### Todos * [ ] - Task

[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-02-27 Thread via GitHub
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment:

[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-02-27 Thread via GitHub
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment:

[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-02-27 Thread via GitHub
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment:

[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-02-27 Thread via GitHub
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment:

[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-02-27 Thread via GitHub
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment:

[GitHub] [zeppelin] phongnt commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-27 Thread via GitHub
phongnt commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447567707 @cometta I think Maven command in Dockerfile is not official for distribute docker image. I tried to start Zeppelin in docker by `docker run -p 8080:8080 --rm --name zeppelin

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

2023-03-03 Thread via GitHub
huage1994 commented on code in PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#discussion_r1122608228 ## zeppelin-plugins/notebookrepo/s3/pom.xml: ## @@ -109,15 +131,11 @@ javax.xml.bind jaxb-api -

[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

2023-02-16 Thread via GitHub
jongyoul commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433126434 Long time no see. I think you'd better rebase this branch, not mering current master :-) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] proceane commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

2023-02-16 Thread via GitHub
proceane commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433197598 oh... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-16 Thread via GitHub
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432962218 Thanks @canhtran for the feedback, https://github.com/apache/zeppelin/pull/4558 indeed cause this issue. The workaround is using `mvn clean package -DskipTests -Pflink-113` -- This is

[GitHub] [zeppelin] zjffdu opened a new pull request, #4566: [MINOR] Use flink-113 as default profile

2023-02-16 Thread via GitHub
zjffdu opened a new pull request, #4566: URL: https://github.com/apache/zeppelin/pull/4566 ### What is this PR for? A trivial PR to use flink-113 as default profile, so that user don't need to specify profile to build flink-interpreter modules. Otherwise the following command won't

[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-16 Thread via GitHub
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432832112 It seems like the issue starting from #4558 I built the zeppelin at commit `f30ea77accc921db3f06aadd5675f71140bc6da2` and it's fine

[GitHub] [zeppelin] ottok92 commented on pull request #4565: Reflect ZEPPELIN-5352 changes in docs

2023-02-18 Thread via GitHub
ottok92 commented on PR #4565: URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1435643769 @zjffdu it seems this [zeppelin-server.yaml](https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml) is particularly setup for Spark. I tried defining

[GitHub] [zeppelin] Reamer commented on pull request #4569: [ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter

2023-02-24 Thread via GitHub
Reamer commented on PR #4569: URL: https://github.com/apache/zeppelin/pull/4569#issuecomment-1443236925 The tests run through, but without log output. In my opinion, this can be omitted at the moment. How do you see it? ``` 2023-02-24T08:53:44.5652238Z [INFO]

[GitHub] [zeppelin] Reamer commented on pull request #4563: Solve the concurrency clone note

2023-02-23 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1441617178 Please open a JIRA ticket. A stack trace of the error would be good in the ticket. It would also be good if you use the pull request template. -- This is an automated message from the

[GitHub] [zeppelin] tranvanthai opened a new pull request, #4569: [ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter

2023-02-22 Thread via GitHub
tranvanthai opened a new pull request, #4569: URL: https://github.com/apache/zeppelin/pull/4569 ### What is this PR for? Currently, the path of the test folder in the Java Interpreter module was wrong. I open this PR to correct it. ### What type of PR is it? Improvement

[GitHub] [zeppelin] Reamer merged pull request #4569: [ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter

2023-02-24 Thread via GitHub
Reamer merged PR #4569: URL: https://github.com/apache/zeppelin/pull/4569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-28 Thread via GitHub
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1448202540 i use the master branch to build the docker image. below is python interpreter setting, it is the default one

[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-28 Thread via GitHub
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447899439 @phongnt , sorry you confused with number of questions i asked. for this issue, only happen in master branch of the repo, not older version of Zeppelin. To see this issue, you need to

[GitHub] [zeppelin] phongnt commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-28 Thread via GitHub
phongnt commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447926387 @cometta Base on your error message, I think your Python Interpreter have problem as your installed Python package on your server (k8s). Could you please share your Python Interpreter

[GitHub] [zeppelin] Reamer commented on pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

2023-03-01 Thread via GitHub
Reamer commented on PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449891496 > I just have a very small question about this: I noticed that you removed the `public` modifier from the `@Test` method but retain the `public` modifier for methods that are decorated

[GitHub] [zeppelin] Reamer merged pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-03-01 Thread via GitHub
Reamer merged PR #4570: URL: https://github.com/apache/zeppelin/pull/4570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-03-01 Thread via GitHub
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451342014 Thanks @PrabhuJoseph. It works by copying the `flink-sql-client-1.16.jar` to `lib` folder. The documentation missed this step, I will raise a PR for it. Thanks again -- This is an

[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-03-01 Thread via GitHub
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451248958 I'm also facing the below issue while testing the zeppelin with flink 1.16. I guess we need to modify/copy the libraries in flink to resolve it but haven't figured it out. ```

[GitHub] [zeppelin] PrabhuJoseph commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-03-01 Thread via GitHub
PrabhuJoseph commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451314800 > I'm also facing the below issue while testing the zeppelin with flink 1.16. I guess we need to modify/copy the libraries in flink to resolve it but haven't figured it out.

[GitHub] [zeppelin] bigjar commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-03-01 Thread via GitHub
bigjar commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451139614 Hi, @zjffdu. when I use flink.udf.jars, I found two problems. One is it can not find the org.apache.zeppelin.shaded.com.google.common.io.Files, because the #4545 had change the shaded

[GitHub] [zeppelin] huage1994 commented on pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

2023-02-28 Thread via GitHub
huage1994 commented on PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449293326 Hi @Reamer , this PR is a great job. It all looks good to me. I just have a very small question about this: I noticed that you removed the `public` modifier from the `@Test`

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4571: Bump minimist, mkdirp, karma, handlebars and protractor in /zeppelin-web-angular

2023-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #4571: URL: https://github.com/apache/zeppelin/pull/4571 Bumps [minimist](https://github.com/minimistjs/minimist) to 1.2.8 and updates ancestor dependencies [minimist](https://github.com/minimistjs/minimist),

[GitHub] [zeppelin] kkalyan commented on a diff in pull request #3496: [ZEPPELIN-4407] Add the ability to copy/paste result table

2023-02-24 Thread via GitHub
kkalyan commented on code in PR #3496: URL: https://github.com/apache/zeppelin/pull/3496#discussion_r1117828333 ## zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html: ## @@ -88,8 +88,10 @@ Toggle Dropdown -CSV -TSV +Copy as TSV +

[GitHub] [zeppelin] qinbo12 commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-02-28 Thread via GitHub
qinbo12 commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1449392398 > Please open a JIRA ticket. A stack trace of the error would be good in the ticket. It would also be good if you use the pull request template. Hello, I have JIRA sheet and

[GitHub] [zeppelin] akishichinibu commented on pull request #4567: [ZEPPELIN-5882] Upgrade Kotlin interpreter to 1.8.10

2023-02-28 Thread via GitHub
akishichinibu commented on PR #4567: URL: https://github.com/apache/zeppelin/pull/4567#issuecomment-1449427666 Hi @dkaznacheev, I’m trying to upgrade the Kotlin version to 1.8.10 in the Kotlin interpreter, but I found that there’s a great change in the compiler API since 1.4. Could you

[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module

2023-02-28 Thread via GitHub
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1449479976 i retest again, the python error no longer occurs after i clear the browser cache. issue resolved. just take note that to use spark 3.3, on pom.xml , change the line 3.3.2 when

[GitHub] [zeppelin] akishichinibu opened a new pull request, #4567: [ZEPPELIN-5882] Upgrade Kotlin interpreter to 1.8.10

2023-02-20 Thread via GitHub
akishichinibu opened a new pull request, #4567: URL: https://github.com/apache/zeppelin/pull/4567 ### What is this PR for? Zeppelin Interpreter Support Kotlin From 1.3.50 To 1.8.10 ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-12 Thread via GitHub
jongyoul commented on code in PR #4580: URL: https://github.com/apache/zeppelin/pull/4580#discussion_r1164411099 ## zeppelin-server/src/test/java/org/apache/zeppelin/service/shiro/AbstractShiroTest.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-12 Thread via GitHub
jongyoul commented on code in PR #4580: URL: https://github.com/apache/zeppelin/pull/4580#discussion_r1164412779 ## zeppelin-server/src/test/java/org/apache/zeppelin/service/shiro/AbstractShiroTest.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [zeppelin] Reamer merged pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5

2023-04-13 Thread via GitHub
Reamer merged PR #4580: URL: https://github.com/apache/zeppelin/pull/4580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] grizzly-monkey opened a new pull request, #4581: Sanitize user labels for k8s

2023-04-20 Thread via GitHub
grizzly-monkey opened a new pull request, #4581: URL: https://github.com/apache/zeppelin/pull/4581 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. K8S labels has specific requirement to name labels which can be found here

[GitHub] [zeppelin] Reamer commented on pull request #4581: Sanitize user labels for k8s

2023-04-21 Thread via GitHub
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1517384284 Hello @grizzly-monkey, thanks for your Pull Request. We already have a sanitize method. Have a look at `K8sUtils:generateK8sName`. Please use this method or adapt the method to your

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173957427 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -133,21 +134,14 @@ protected void runJob(Job runningJob) {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173974707 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -82,10 +88,11 @@ public void runJobInScheduler(Job job) { * RUNNING

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173962995 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -34,14 +36,14 @@ public class RemoteScheduler extends AbstractScheduler {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173959970 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java: ## @@ -70,6 +70,14 @@ public boolean isPending() { public boolean isCompleted() {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173980444 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,11 +89,14 @@ public void run() { runningJob =

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1518056388 As this PR changes a very important component of Zeppelin, I need an accurate review. If you want me to describe the changes in more detail, please let me know. -- This is an

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,6 +89,7 @@ public void run() { runningJob =

[GitHub] [zeppelin] Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter

2023-04-21 Thread via GitHub
Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter URL: https://github.com/apache/zeppelin/pull/4584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,6 +89,7 @@ public void run() { runningJob =

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173972774 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -53,22 +55,26 @@ public void runJobInScheduler(Job job) {

[GitHub] [zeppelin] Samrat002 opened a new pull request, #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter

2023-04-21 Thread via GitHub
Samrat002 opened a new pull request, #4584: URL: https://github.com/apache/zeppelin/pull/4584 ### What is this PR for? - It introduces new flink 1.17.0 interpreter support in zeppelin. - Flink-1.17 is

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173961893 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] zjffdu commented on pull request #4579: [ZEPPELIN-5893] Dev zeppelin client bug

2023-04-21 Thread via GitHub
zjffdu commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1518472971 @xiaomin0322 Could you update the jira title to be more specific? `Dev zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when getting progress from

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4585: Bump spark-core_2.12 from 3.1.2 to 3.4.0 in /spark/interpreter

2023-04-21 Thread via GitHub
dependabot[bot] opened a new pull request, #4585: URL: https://github.com/apache/zeppelin/pull/4585 Bumps spark-core_2.12 from 3.1.2 to 3.4.0. [![Dependabot compatibility

[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-24 Thread via GitHub
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1520648767 when does it get merged ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4587: Bump xlsx from 0.14.5 to 0.18.5 in /zeppelin-web-angular

2023-04-24 Thread via GitHub
dependabot[bot] opened a new pull request, #4587: URL: https://github.com/apache/zeppelin/pull/4587 Bumps [xlsx](https://github.com/SheetJS/sheetjs) from 0.14.5 to 0.18.5. Changelog Sourced from https://github.com/SheetJS/sheetjs/blob/github/CHANGELOG.md;>xlsx's changelog.

[GitHub] [zeppelin] Reamer commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-25 Thread via GitHub
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1521210881 > when does it get merged ? When all tests have been successfully completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1521223455 > BTW it's weird that the `RemoteSchedulerTest` used to runs fine on Junit 4, Do you know why? Unfortunately no. However, since only the timing matters due to the six threads

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1524855876 Still > Thanks for the contribution @zhugezifang , could you update the PR description? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-27 Thread via GitHub
Reamer commented on code in PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178681796 ## zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java: ## @@ -123,7 +123,7 @@ void

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-27 Thread via GitHub
Reamer commented on code in PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178683279 ## zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java: ## @@ -123,7 +123,7 @@ void

[GitHub] [zeppelin] Reamer opened a new pull request, #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-25 Thread via GitHub
Reamer opened a new pull request, #4590: URL: https://github.com/apache/zeppelin/pull/4590 ### What is this PR for? This pull request adds a cache cleanup method that attempts to remove an item from the cache that is not the eldest item and also does not have a read flag. ###

[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-26 Thread via GitHub
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1523879863 Fixed the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1525302501 > Still > > > Thanks for the contribution @zhugezifang , could you update the PR description? ok,updated it -- This is an automated message from the Apache Git

[GitHub] [zeppelin] realknorke commented on pull request #4586: [ZEPPELIN-5902] Support Spark 3.4

2023-04-27 Thread via GitHub
realknorke commented on PR #4586: URL: https://github.com/apache/zeppelin/pull/4586#issuecomment-1525682236 Thanks for the pull request. Its possible to connect to a 3.4.0 Spark cluster. BUT Spark Connect is not working. ``` %spark-connect spark.read.option("basePath",

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1525674173 I do not understand the fix. Could you please explain it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-27 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1525923732 If no further comments are received till Tuesday 02.05, I will merge this PullRequest. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] Reamer commented on pull request #4562: [ZEPPELIN-5880] Credentials roles

2023-04-27 Thread via GitHub
Reamer commented on PR #4562: URL: https://github.com/apache/zeppelin/pull/4562#issuecomment-1525944565 Added some Screenshots :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   4   >