[GitHub] zeppelin issue #1215: ZEPPELIN-1225. Errors before the last shell command ar...

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1215 @Leemoonsoo, mind to take look at it ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1189 @Leemoonsoo I pushed another commit to add migration section in upgrade.md, please help review. Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1228: ZEPPELIN-1175. AM log is not available for yarn...

2016-07-25 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1228 ZEPPELIN-1175. AM log is not available for yarn-client mode ### What is this PR for? For now, we share the same class path for zeppelin server and remote interpreter process. The cause

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1189 BTW, I will do the windows related change after we make consensus on this approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1189 Thanks @AhyoungRyu , I have updated the doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1228: ZEPPELIN-1175. AM log is not available for yarn-client...

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1228 @Leemoonsoo * `$ZEPPELIN_HOME/interpreter/` is not in the classpath, actually the jars under this folder are in the classpath. Although I can put all the files under this folder

[GitHub] zeppelin issue #1221: [MINOR] Change url in pom.xml files

2016-07-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1221 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1228: ZEPPELIN-1175. AM log is not available for yarn-client...

2016-07-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1228 Build fails due to some network issue. ``` [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:npm (npm install) on project zeppelin-web: Failed to run task

[GitHub] zeppelin pull request #1232: ZEPPELIN-1197. Should print output directly wit...

2016-07-26 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1232 ZEPPELIN-1197. Should print output directly without invoking function print in pyspark interpreter ### What is this PR for? For now, user need to invoke print to make the output displayed

[GitHub] zeppelin issue #1206: ZEPPELIN-1199. Need to login using keytab and principa...

2016-07-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1206 @prabhjyotsingh Conflicts resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1237: ZEPPELIN-1242. Should set property SPARK_YARN_M...

2016-07-28 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1237 ZEPPELIN-1242. Should set property SPARK_YARN_MODE and do login befor… ### What is this PR for? We run zeppelin on spark when spark authentication is turned on, but got the following

[GitHub] zeppelin issue #1237: ZEPPELIN-1242. Should set property SPARK_YARN_MODE and...

2016-07-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1237 @prabhjyotsingh I close #1206, and merge it here. Please help review, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1206: ZEPPELIN-1199. Need to login using keytab and principa...

2016-07-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1206 Close it and merge it to #1237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1237: ZEPPELIN-1242. Should set property SPARK_YARN_MODE and...

2016-07-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1237 Build fails due to network issue. ``` [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven

[GitHub] zeppelin issue #1163: [ZEPPELIN-1149] %sh interpreter kerberos support

2016-07-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1163 agree with @felixcheung, use the zeppelin service keytab/principal might bring some other potential security problems. I think user A would expect to run shell script as himself, but actually

[GitHub] zeppelin issue #1163: [ZEPPELIN-1149] %sh interpreter kerberos support

2016-07-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1163 Sorry, I mistake it as hdfs interpreter. For shell interpreter, do we must have kerberos support ? I think here kinit is just for the hadoop command, so actually it is for running hdfs command

[GitHub] zeppelin issue #1163: [ZEPPELIN-1149] %sh interpreter kerberos support

2016-07-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1163 @prabhjyotsingh Thanks for clarification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1215: ZEPPELIN-1225. Errors before the last shell command ar...

2016-07-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1215 Travis build fails due to network issue I think, ``` [INFO] bower@1.7.2 node_modules/bower [INFO] └── semver-utils@1.1.1 [ERROR] npm ERR! Linux 3.13.0-40-generic [ERROR

[GitHub] zeppelin issue #1215: ZEPPELIN-1225. Errors before the last shell command ar...

2016-07-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1215 After checking ShellInterpreter.java, I found other 2 issues. * Should remove entry from executors after the shell execution is done otherwise it would accumulate more and more

[GitHub] zeppelin pull request #1215: ZEPPELIN-1225. Errors before the last shell com...

2016-07-22 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1215 ZEPPELIN-1225. Errors before the last shell command are ignored ### What is this PR for? The problem is that command "bash -c " will always return 0 as long as the last line of sh

[GitHub] zeppelin issue #1232: ZEPPELIN-1197. Should print output directly without in...

2016-07-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1232 @Leemoonsoo Thanks for the careful checking. I compare it with jupyter, only the second case is different. Let me investigate how to fix it. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1232: ZEPPELIN-1197. Should print output directly without in...

2016-07-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1232 I also compare it with native python repl, the second case is consistent. So I think this behvior is fine, although it is different from jyputer. ![2016-07-29_0746](https

[GitHub] zeppelin pull request #1245: ZEPPELIN-1225. Errors before the last shell com...

2016-07-29 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1245 ZEPPELIN-1225. Errors before the last shell command are ignored What is this PR for? The problem is that command "bash -c " will always return 0 as long as the last line of sh

[GitHub] zeppelin issue #1245: ZEPPELIN-1225. Errors before the last shell command ar...

2016-07-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1245 @Leemoonsoo this is for branch-0.6, the test fail seems irrelevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...

2016-07-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1241 yes, I run it under `ZEPPELIN_HOME/docs` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...

2016-07-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1241 @AhyoungRyu I follow the instruction here to build the doc https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation, but fails. Here's the error after `bundle install

[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...

2016-07-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1241 Thanks @AhyoungRyu , the new UI lgtm. BTW, this link helps me in case someone else need this, http://pragmaticstudio.com/blog/2010/9/23/install-rails-ruby-mac --- If your project is set up

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-07-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1255 I would not recommend user to do that to add extra library. Because most of time zeppelin user don't know the cluster details like which extra library are located in the cluster machines. I would

[GitHub] zeppelin pull request #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work ...

2016-08-02 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1260 ZEPPELIN-1267. PySparkInterpreter doesn't work in spark 2.0 ### What is this PR for? PySparkInterpreter doesn't work in spark 2.0 because pyspark and py4j is not distributed to executors

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1255 You can use --conf spark.jars= and --conf spark.jars.packages= instead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1268: minor doc fix for r.md

2016-08-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1268 @AhyoungRyu Please help review. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1269: ZEPPELIN-1270. Remove getting SQLContext from SparkSes...

2016-08-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1269 \cc @Leemoonsoo Please help review, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1269: ZEPPELIN-1270. Remove getting SQLContext from S...

2016-08-02 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1269 ZEPPELIN-1270. Remove getting SQLContext from SparkSession.wrapped() ### What is this PR for? SparkSession.wrapped is only for spark 2.0 preview, it is not supported in spark 2.0 release. So

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1255 @jimdowling Right, there's no ZeppelinContext in livy right now. Would allowing user to specify jars/packages when creating livy session more general ? (like --jars/--packages in spark-submit

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

2016-08-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Does that mean the login user is the process owner ? Because it matters for security reason. e.g. * For spark interpreter, it would be better to launch the yarn app

[GitHub] zeppelin issue #1316: [ZEPPELIN-1118] Migrate Zeppelin Live Demo feature fro...

2016-08-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1316 One suggestion is asking the 3rd party to specify their zeppelin version for this demo. If they update the demo, they should also update the version accordingly. --- If your project is set up

[GitHub] zeppelin issue #1278: ZEPPELIN-1287. No need to call print to display output...

2016-08-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1278 +1 for merging this into branch-0.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1278: ZEPPELIN-1287. No need to call print to display...

2016-08-04 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1278 ZEPPELIN-1287. No need to call print to display output in PythonInter… ### What is this PR for? It is not necessary to call print to display output in PythonInterpreter. 2 main changes

[GitHub] zeppelin issue #1278: ZEPPELIN-1287. No need to call print to display output...

2016-08-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1278 \\cc @bzz @Leemoonsoo ready for review, not sure whether the test fail is relevant. CI is very unstable recently, we might need to fix it asap :smiley:. --- If your project is set up

[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...

2016-08-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1260 I also use the latest master and build zeppelin with this command: ```mvn clean package -Pspark-2.0 -Ppyspark -Psparkr -DskipTests ```, and then export `SPARK_HOME` to where spark-2.0

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

2016-08-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1189 \\cc @Leemoonsoo Ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1320: [ZEPPELIN-1287][branch-0.6] No need to call print to d...

2016-08-12 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1320 Just one minor code style issue, rest LGTM, Thanks @minahlee for taking over this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1301: [MINOR] Removed unused profiles from spark/pom.xml

2016-08-12 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1301 Definitely should remove profile yarn. I got classpath issue when enabling yarn profile. And we need to update the docs accordingly. --- If your project is set up for it, you can reply

[GitHub] zeppelin pull request #1175: use static field logger instead of function

2016-07-13 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1175 use static field logger instead of function ### What is this PR for? Create static field logger in Paragraph instead of function to make the code style consistent. This is a trivial

[GitHub] zeppelin pull request #1212: ZEPPELIN-1222. ClassNotFoundException of SparkJ...

2016-07-20 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1212 ZEPPELIN-1222. ClassNotFoundException of SparkJLineCompletion in Spark Interpreter ### What is this PR for? ClassNotFoundException happens because not fully qualified class name

[GitHub] zeppelin issue #1212: ZEPPELIN-1222. ClassNotFoundException of SparkJLineCom...

2016-07-20 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1212 @Leemoonsoo Could you help take a look at it ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1206: ZEPPELIN-1215. Need to login using keytab and p...

2016-07-19 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1206 ZEPPELIN-1215. Need to login using keytab and principal before creating SparkContext in secured cluster ### What is this PR for? Need to login using keytab and principal before creating

[GitHub] zeppelin issue #1206: ZEPPELIN-1199. Need to login using keytab and principa...

2016-07-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1206 pyspark and sprakr both create SparkContext, so this fix also works in pyspark & sparkr --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] zeppelin issue #1206: ZEPPELIN-1215. Need to login using keytab and principa...

2016-07-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1206 Might need to check whether it works in pyspark/sparkr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1184: [ZEPPELIN-1159] Livy interpreter gets "404 not found" ...

2016-07-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1184 @prabhjyotsingh ```this is result in proper error message.``` What does this mean ? Is the behavior livy interpreter give proper error message to client or just recreate a new session

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-07-15 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1189 ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS ### What is this PR for? Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS

[GitHub] zeppelin pull request #1190: ZEPPELIN-1187. Redirect output of the process r...

2016-07-15 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1190 ZEPPELIN-1187. Redirect output of the process running interpreter.sh to log4j ### What is this PR for? For now the output of process running interpter.sh is lost, it would be nice

[GitHub] zeppelin issue #1190: ZEPPELIN-1187. Redirect output of the process running ...

2016-07-15 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1190 \cc @Leemoonsoo Could you help take look at this PR ? Since you are the original author of this file. Thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1116: minor doc fix

2016-07-05 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1116 right, I miss the newbie label. Add it in the next commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-08-07 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1189 ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS ### What is this PR for? Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS

[GitHub] zeppelin issue #1269: ZEPPELIN-1270. Remove getting SQLContext from SparkSes...

2016-08-07 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1269 @Leemoonsoo PR rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-08-07 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1300: ZEPPELIN-1305. Fix bug of ZEPPELIN-1215

2016-08-07 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1300 ZEPPELIN-1305. Fix bug of ZEPPELIN-1215 ### What is this PR for? It is my bad, Before commit ZEPPELIN-1215, I change `getProperty().getProperty(key) != null` to `getProperty().contains(key

[GitHub] zeppelin issue #1300: ZEPPELIN-1305. Fix bug of ZEPPELIN-1215

2016-08-07 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1300 \cc @prabhjyotsingh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

2016-08-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1307 \cc @Leemoonsoo @minahlee Is it possible to merge it into 0.6.1 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

2016-08-09 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1307 ZEPPELIN-1311. Typo in ZEPPELIN-1197 ### What is this PR for? My bad, it should be `Exception` rather than `Execution` ![2016-08-09_1528](https://cloud.githubusercontent.com/assets

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

2016-08-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1307 Thanks @minahlee, the CI fail should be irrelevant, it is due to network issue. ``` [INFO] └── semver-utils@1.1.1 [ERROR] npm ERR! Linux 3.13.0-40-generic [ERROR] npm ERR

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

2016-08-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1307 @minahlee Please hold the commit, I will have another improvement soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

2016-08-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1307 oh, sorry, I didn't realize `ZEPPELIN-1197` is not in 0.6. Then let's merge this to master only. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-08-07 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-08-07 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1189 ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS ### What is this PR for? Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS

[GitHub] zeppelin pull request #1278: ZEPPELIN-1287. No need to call print to display...

2016-08-07 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1278 ZEPPELIN-1287. No need to call print to display output in PythonInterpreter ### What is this PR for? It is not necessary to call print to display output in PythonInterpreter. 2 main changes

[GitHub] zeppelin pull request #1278: ZEPPELIN-1287. No need to call print to display...

2016-08-07 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-08-07 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1189 ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS ### What is this PR for? Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS

[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...

2016-08-07 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #673: [Zeppelin-630] Introduce new way of dependency loading ...

2016-08-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/673 Thanks @minahlee, it works. But any reason to make it hidden by default ? But it is not intuitive for me that I can click the gear button to display it. --- If your project is set up for it, you

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1255 No, I mean add interpreter property to allow user to specify jars/packages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1245: ZEPPELIN-1225. Errors before the last shell com...

2016-08-03 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1232: ZEPPELIN-1197. Should print output directly without in...

2016-08-03 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1232 Sure, let me do it for python interpreter as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1333: [ZEPPELIN-1334] Environment variable defined in...

2016-08-16 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1333 [ZEPPELIN-1334] Environment variable defined in interpreter setting doesn't take effect ### What is this PR for? I define SPAKR_HOME in interpreter setting, but it doesn't take effect

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

2016-08-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1189 ping @Leemoonsoo in case you miss it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

2016-08-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @sourav-mazumder 's suggestion is about another point of multiple user support, this is might not be a trivial task to implement in this PR. I think we have a discussion about the multiple-user

[GitHub] zeppelin issue #1318: [ZEPPELIN-1280][Spark on Yarn] Documents for running z...

2016-08-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1318 @astroshim I can use spark 2.0 and hadoop 2.7 successfully. I hit this issue when building zeppelin with profile yarn enabled. So please don't enable yarn profile otherwise you will get hadoop

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

2016-08-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 Create umbrella ticket for multiple user support. https://issues.apache.org/jira/browse/ZEPPELIN-1337 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-02-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 Yes, the PR is ready. CI failure is not relevant. Please help include it in 0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1970: ZEPPELIN-2045. Pass interpreter properties with "spark...

2017-02-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1970 @Leemoonsoo @felixcheung Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-01-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 I suspect it is caused by other issues rather than `Output exceeds...`. Because message `Output exceeds...` should be generated after the method `parseSQLOutput` --- If your project is set up

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-01-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 @del680202 Can you try this on `%spark.sql` as well ? I guess `Output exceeds...` may also cause issues in displaying table format data in `%spark.sql` --- If your project is set up for it, you

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-01-30 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 @del680202 Can you paste the full stacktrace ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-01-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 I am not sure whether that would help, because `Output exceeds ...` is generated by zeppelin, not by livy or spark. https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-01-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 hmm, right. `LivySparkSQLInterpreter` delegate interpret to `LivySparkInterpreter`. So it is possible to get `Output exceeds...` in `LivySparkSQLInterpreter`. Thanks @del680202 --- If your

[GitHub] zeppelin issue #1960: [ZEPPELIN-2030] Select statement doesn't work in LivyS...

2017-01-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1960 @del680202 Thanks for checking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1981: [ZEPPELIN-2067] SparkInterpreter prints unnecessary ne...

2017-02-07 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1981 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2017-02-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1574 Thanks @wesm , I updated this PR yesterday, but didn't use `git merge`. I use `git rebase` and `git commit --amend`, does these also the issue as well ? --- If your project is set up for it, you

[GitHub] zeppelin pull request #1970: ZEPPELIN-2045. Pass interpreter properties with...

2017-02-02 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1970 ZEPPELIN-2045. Pass interpreter properties with "spark." as prefix to SparkConf ### What is this PR for? Minor change to only pass interpreter properties with "spark." as

[GitHub] zeppelin issue #1970: ZEPPELIN-2045. Pass interpreter properties with "spark...

2017-02-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1970 This doesn't conform with spark. Spark don't allow property that doesn't start with `spark.` [1] If user want to use any properties in driver side, they should use properties of Interpreter

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-05 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1975 @Leemoonsoo I still on extra blank between outputs which is inconsistent with zeppelin 0.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2017-02-05 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1574 @Leemoonsoo @felixcheung I update this PR, please help help review that. My purpose is to make ZeppelinContext extensible is in 2 perspective. * All the interpreter can has its own

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-05 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1975 @Leemoonsoo I don't think the blank line is caused by scala. Here's what I see in zeppelin 0.6.2 and zeppelin 0.7, both use spark 1.6.2 Zeppelin 0.7 ![image](https

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-06 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1975 Thanks @Leemoonsoo , it make sense to fix it in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #1933: HOTFIX: Add the missing quotes for livy cancel

2017-01-22 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1933 HOTFIX: Add the missing quotes for livy cancel ### What is this PR for? Seems I miss the quote when rebase. ### What type of PR is it? [Hot Fix |] ### Todos

[GitHub] zeppelin issue #1933: HOTFIX: Add the missing quotes for livy cancel

2017-01-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1933 @minahlee Could you merge it into 0.7 if you plan for another RC ? Very appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #1938: ZEPPELIN-2006. Livy interpreter doesn't work in...

2017-01-24 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1938 ZEPPELIN-2006. Livy interpreter doesn't work in anonymous mode ### What is this PR for? We should not pass proxy-user to livy server in anonymous mode, otherwise the livy session

[GitHub] zeppelin issue #1938: ZEPPELIN-2006. Livy interpreter doesn't work in anonym...

2017-01-24 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1938 @prabhjyotsingh Please help review. CI failure is not relevant. I have created https://issues.apache.org/jira/browse/ZEPPELIN-2007 for it --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1942: [ZEPPELIN-1982] When using the 'Select * ...' statemen...

2017-01-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1942 This PR works for me. But I feel it is kind of hacking using ``. I think the better approach is to using multiple `InterpreterResult`. But we could do that in a following up PR. --- If your

  1   2   3   4   5   6   7   8   9   10   >