[GitHub] [zeppelin] RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match expression to determine SparkR Security

[GitBox]

RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match 
expression to determine SparkR Security
URL: https://github.com/apache/zeppelin/pull/3357#issuecomment-487690798
 
 
   I'm really not liking what i'm doing here. I think i'm going to try to just 
push the version number in our distribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match expression to determine SparkR Security

[GitBox]

RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match 
expression to determine SparkR Security
URL: https://github.com/apache/zeppelin/pull/3357#issuecomment-487671905
 
 
   @felixcheung I read the code wrong, to avoid the version check for Python I 
have it check whether py4j supports the auth token method.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match expression to determine SparkR Security

[GitBox]

RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match 
expression to determine SparkR Security
URL: https://github.com/apache/zeppelin/pull/3357#issuecomment-487648939
 
 
   Not sure why i'm having such pain with this type matching :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match expression to determine SparkR Security

[GitBox]

RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match 
expression to determine SparkR Security
URL: https://github.com/apache/zeppelin/pull/3357#issuecomment-487645040
 
 
   @felixcheung From what I can tell, pyspark just assumes that the secret is 
always passed 
https://github.com/apache/zeppelin/blob/8fa534343beccb797f9f1850ec43673ac830b73e/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L121


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match expression to determine SparkR Security

[GitBox]

RussellSpitzer commented on issue #3357: [ZEPPELIN-4136] -Use a match 
expression to determine SparkR Security
URL: https://github.com/apache/zeppelin/pull/3357#issuecomment-487625794
 
 
   Of course
   
   On Mon, Apr 29, 2019 at 10:25 AM Jeff Zhang 
   wrote:
   
   > Thanks for the contribution @RussellSpitzer
   >  , could you remove
   > SparkVersion#isSecretSocketSupported ?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or 
mute
   > the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services