[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin
on Kubernetes
URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249025462
##
File path:
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.interpreter.launcher;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.gson.Gson;
+import java.util.ArrayList;
+import java.util.Arrays;
+
+import org.apache.commons.exec.*;
+import org.apache.commons.io.IOUtils;
+
+import java.io.*;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Kubectl {
+ private final Logger LOGGER = LoggerFactory.getLogger(Kubectl.class);
+ private final String kubectlCmd;
+ private final Gson gson = new Gson();
+ private String namespace;
+
+ public Kubectl(String kubectlCmd) {
+this.kubectlCmd = kubectlCmd;
+ }
+
+ /**
+ * Override namespace. Otherwise use namespace provided in schema
+ * @param namespace
+ */
+ public void setNamespace(String namespace) {
+this.namespace = namespace;
+ }
+
+ public String getNamespace() {
+return namespace;
+ }
+
+ public String apply(String spec) throws IOException {
+return execAndGet(new String[]{"apply", "-f", "-"}, spec);
Review comment:
Okay
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin
on Kubernetes
URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249025462
##
File path:
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.interpreter.launcher;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.gson.Gson;
+import java.util.ArrayList;
+import java.util.Arrays;
+
+import org.apache.commons.exec.*;
+import org.apache.commons.io.IOUtils;
+
+import java.io.*;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Kubectl {
+ private final Logger LOGGER = LoggerFactory.getLogger(Kubectl.class);
+ private final String kubectlCmd;
+ private final Gson gson = new Gson();
+ private String namespace;
+
+ public Kubectl(String kubectlCmd) {
+this.kubectlCmd = kubectlCmd;
+ }
+
+ /**
+ * Override namespace. Otherwise use namespace provided in schema
+ * @param namespace
+ */
+ public void setNamespace(String namespace) {
+this.namespace = namespace;
+ }
+
+ public String getNamespace() {
+return namespace;
+ }
+
+ public String apply(String spec) throws IOException {
+return execAndGet(new String[]{"apply", "-f", "-"}, spec);
Review comment:
Okay... Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r249025339 ## File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java ## @@ -0,0 +1,157 @@ +/* Review comment: Okay. Sure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin
on Kubernetes
URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248567845
##
File path:
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.interpreter.launcher;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.gson.Gson;
+import java.util.ArrayList;
+import java.util.Arrays;
+
+import org.apache.commons.exec.*;
+import org.apache.commons.io.IOUtils;
+
+import java.io.*;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Kubectl {
+ private final Logger LOGGER = LoggerFactory.getLogger(Kubectl.class);
+ private final String kubectlCmd;
+ private final Gson gson = new Gson();
+ private String namespace;
+
+ public Kubectl(String kubectlCmd) {
+this.kubectlCmd = kubectlCmd;
+ }
+
+ /**
+ * Override namespace. Otherwise use namespace provided in schema
+ * @param namespace
+ */
+ public void setNamespace(String namespace) {
+this.namespace = namespace;
+ }
+
+ public String getNamespace() {
+return namespace;
+ }
+
+ public String apply(String spec) throws IOException {
+return execAndGet(new String[]{"apply", "-f", "-"}, spec);
Review comment:
`kubectl apply -f` does not work if there is a `generateName` in the
interpreter spec yaml. Its better to use `kubectl create -f` if resources are
being created. Please find the discussion
[here](https://github.com/kubernetes/kubernetes/issues/44501#issuecomment-294255660).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes
ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248565818 ## File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java ## @@ -0,0 +1,157 @@ +/* Review comment: The Issue with fabric8 library related to kubectl apply or delete of resources using a single API is working with [#1300](https://github.com/fabric8io/kubernetes-client/pull/1300) which is merged to master branch. When it is available in the next release of fabric8io/kubernetes-client we can integrate the same. Using the above fix from fabric8 the change has been validated in the master branch of [zep-k8sctl](https://github.com/ajaygk95/zep-k8sctl). Can you please let us know if we create new JIRA issues so that we follow up or we will follow some different procedure. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
