[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 CI become green and @cloverhearts tested allmost cases. Merging if there's no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @cloverhearts Thank you!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul I still have the issue, not sure why I would hit this weird issue. I can see the perUser/perNote checkbox, but just could not select it. ![image](https://cloud.githubusercontent.

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul my mistake, it works now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1265 Tested. I was tested for spark, jdbc, markdown, file and other interpreters. It's working well. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1265 Thank you @jongyoul ui - screenshot. shiro off (anonymous user) ![shiro-off](https://cloud.githubusercontent.com/assets/10525473/19460838/6c78cca2-951a-11e6-9f15-69

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 Thank you @cloverhearts for the UI work. Can you share your screenshot for this feature? It can help everyone understand your awesome work!! --- If your project is set up for it, you can reply t

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @zjffdu I have no idea in your case. Are you still suffering from it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @khalidhuseynov Thanks for testing it. I'll change it to get user information from fromMessage. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul I can see the perUser on interpreter setting page and shiro is enabled, but there's no response when I click it, do I miss anything ? --- If your project is set up for it, you can

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul I've checked now and `SecurityUtils` didn't have correct information, and normally `message` should be having the correct information since routine for authorization based on `pri

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @khalidhuseynov Actually, I'm not sure that Shiro figure out the user information from SecurityUtils. Are you sure that `fromMessage->principal` has correct information? --- If your project is

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @corneadoug Done. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @corneadoug I'm fixing some conflicts during rebasing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Could you try rebasing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Yes I think hiding "per user" make sense, and it can be a fair assumption if user == "anonymous" then shiro is not enabled. --- If your project is set up for it, you can reply t

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @corneadoug I summarize all of unique combination. I think 'Per user' is the first criteria and 'Per note' is the second priority. And I also have a question. Can front-end know if shiro is enabl

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 Agree on we should make PR keep small for review. Otherwise we should make subtask. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 This is because small changes are easy to review and intuitive, thus I always try to make my PR as small as I can. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 Thus my idea to handle issues about multi-tenancy is dealt with separately and then will combine them together after finishing them. How about it? --- If your project is set up for it, you can r

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @zjffdu Thanks for sharing your idea and cases. I agree with you what you told about common case. But the main reason to make a config complicated is for keeping backward compatibility which is t

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 * First, I just feel this expression is a kind of thinking of zeppelin developer (The interpreter will be in instantiated ... ) rather than at the standpoint of users. I think what user care about

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1265 @Leemoonsoo this brings a lot of possible configurations, and there will need to be some limitations because they don't all make sense. Would the server be able to handle them correctly and man

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1265 How about  1) When "globally" is selected, "shared" mode is prese

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1265 @Leemoonsoo Agree I will commit the changes to the UI with backward compatibility: Previous [shared] -> [globally][shared] Previous [scoped] -> [per note][scoped] Previous [isolat

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1265 If i add more after @corneadoug 's suggestion, when "globally" is selected from the first dropdown, only possible selection in the second dropdown is "shared". when one of "per

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @corneadoug 's suggestion seems more intuitive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @corneadoug Yes, I agree that it's quite confusing. I like your suggestion. Let me try it. And 'Connection...' is not related to this setting. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1265 Since I don't know much about how the interpreter part works, Its still quite confusing. And I think that having both checkbox and a dropdown might not be helping. First of all, is

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 Concerning those modes, AFAIK, before Zeppelin 0.6.0, Zeppelin has only `shared` mode, but most of users want to run a interpreter with their own, Zeppelin add two modes called `scoped` and `isol

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 Thanks @jongyoul , change it to `isolated` works. Regarding the option complexity, I still have concern on that. So now there's 2 dimensions for interpreter (user/note) IIUC. Before 0.6, zeppe

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Can you make a quick recap on the difference between all of those options? (perUser, perNote, shared, scopes, isolated) --- If your project is set up for it, you can reply to thi

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 About the first comment you should set `scoped` or `isolated`, not `shared`. And growth of complexity is to remain backward compatibility. I also agree that interpreter setting become too m

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 Besides I have other 2 concerns. * I am a little confused about the combination of the interpreter options. There's so many combinations (2*2*3=12), I am not sure whether users are comfortable

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 Thanks @jongyoul after clean cache, I can see the `per user`. But unfortunately, two users still share the same interpreter. Here's what I see. I use yarn-client mode and only see one yarn app is

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 It looks looks like a browser cache issue. Can you clean cache and try it again? On Friday, 2 September 2016, Jeff Zhang wrote: > @jongyoul I do

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul I don't see the `per user` in the interpreter page. Do I miss anything ? 

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @Leemoonsoo I've fixed it. Check it please. This is because remoteProcess doesn't destroy correctly. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @Leemoonsoo Thanks for the review. I'll check that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Thanks for the great work. I tested this PR a bit and it works as expected. However, when i remove a Note, (with "perNote" checked), i think removal of Interpreter Process (isolated m

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 Merging if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 Create umbrella ticket for multiple user support. https://issues.apache.org/jira/browse/ZEPPELIN-1337 --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @sourav-mazumder 's suggestion is about another point of multiple user support, this is might not be a trivial task to implement in this PR. I think we have a discussion about the multiple-user su

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user sourav-mazumder commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul I suggest while we enable this feature we also enable that user can access only the data what he/she is authorized to. For example if there is a folder/table in HDFS

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @zjffdu This is a first step for resolving security issues. For the next step, I'll pass some properties for identifying user. BTW, InterpreterContext includes user information, actually, thus it

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @bzz If different users run a same interpreter with 'isolated', Zeppelin runs multiple process for that interpreters, and with 'scoped', Zeppelin runs a single process for it but the users feel l

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Does that mean the login user is the process owner ? Because it matters for security reason. e.g. * For spark interpreter, it would be better to launch the yarn app as the user

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul this looks very interesting! Could you plz help me to understand - does this changes mean for Zeepelin to run a new separate interpreter process for every user and schedulle only his jobs to

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 https://travis-ci.org/apache/zeppelin/builds/150661771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1265 @echarles For now, Zeppelin supports `per note` option but doesn't do `per user`. If two different users log in Zeppelin and want to use same spark interpreter with same note, they cannot run a p

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1265 Quickly went through the changes, but not sure to get it. In which way is this related to the various intepreter modes we already have? In which way is this related to ZEPPELIN-1000 (Multi