[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/1302 The bug that "auto-restart interpreter on cron execution" restarts all interpreters will be fixed by https://github.com/apache/zeppelin/pull/2681. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1302 Yeah, i think we can make "auto-restart interpreter on cron execution" checkbox restart specific interpreter instance to the notebook. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user toughrogrammer commented on the issue: https://github.com/apache/zeppelin/pull/1302 But isn't this original issue also important? I usually want to restart specific notebook. Because spark executors aren't returned automatically, I must kill zeppelin application from YARN web UI. And then, zeppelin notebook lost spark context and I need to restart spark interpreter. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1302 Ah i see. That definitely looks like a problem. I filed an issue https://issues.apache.org/jira/browse/ZEPPELIN-2995. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user toughrogrammer commented on the issue: https://github.com/apache/zeppelin/pull/1302 https://user-images.githubusercontent.com/1473538/31558707-001fa9e6-b089-11e7-9ca6-48aabcc60839.png;> I'm using spark interpreter per note isolated mode and I wrote a notebook for batch job with cron execution. (Please refer to the attached image.) When this notebook is executed by cron, interpreter is restarted. But problem is other notebook's spark context also to be expired. Every hour I need to re-run all paragraph and read large data set from storage. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1302 @toughrogrammer Could you explain little more about the problem? How cron execution is related with restart interpreter? ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user toughrogrammer commented on the issue: https://github.com/apache/zeppelin/pull/1302 How it's going on? I want to restart *note specific interpreter* when cron is executed or refreshing spark context, but current version(0.7.2), it's impossible. It's really unproductive experience. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @jongyoul I totally agree with you adding multi-tenancy but how about separating that to another PR because we also already have restarting interpreter function in the `Interpreter Setting page` . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1302 Can you add consideration for the multi-tenancy? If Shiro is enabled, current implementation will disable all of users' interpreters --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @corneadoug, @Leemoonsoo I re-based and added testcase. please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @corneadoug I'm going to add test case soon. :laughing: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Can you rebase so that we can check the CI? I will merge after it's green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @Leemoonsoo I agree with your opinion. Let me fix them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim @corneadoug, Shell we have some unittests for `public void restart(String settingId, String noteId)` before we merge? Restarting only a interpreter instance/process for a note is new ability. So i think it make sense to have a unittest. Also, shell we have https://github.com/apache/zeppelin/blob/master/docs/rest-api/rest-interpreter.md#restart-an-interpreter updated, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1302 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @corneadoug I just re-based thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1302 Tested LGTM @astroshim can you rebase? It should make the CI green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @corneadoug I fixed it. please review. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1302 Maybe a spinner just like the save button after editing an interpreter would be enough then. Its just a matter of having a small feedback. https://cloud.githubusercontent.com/assets/710411/18238936/7f06a16a-737c-11e6-88f4-4b65434488f0.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1302 Looks great to me, thank you @astroshim ! On @corneadoug point - it should be possible to animate the icon button \w arrows to be i.e rotating while "restart is in progress" so it stops spinning, as soon as restart is done. This might give user a nice visual feedback. But @astroshim is righ, restart is pretty fast due to the nature of implementation - interpreter process just gets killed and then it's is lazy-started only on next time user runs the paragraph where it is binded. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1302 My only feedback is that right now, it's hard to know if the interpreter has finished restarting or not. My guess is that it takes some time, so you shouldn't be able to restart it again and you should be warned somehow when it's done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Tested again and it works well. I like it :) Here is the new UI (for the other reviewers)  @Leemoonsoo If you have some time, could you please check this PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @AhyoungRyu I think `deactivated` button is better so I updated it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Looks good! I think it would be better the activated and deactivated interpreter buttons can be in line like below images. - Before (with this patch) https://cloud.githubusercontent.com/assets/10060731/18116842/d2a64028-6f85-11e6-93d0-ea613abf12ad.png;> - After https://cloud.githubusercontent.com/assets/10060731/18117512/3cba0ec8-6f8a-11e6-84f5-c6f1bf5ef089.png;> Or I'd like to suggest another option. How about simply changing `Restart` button color to grey for the deactivated interpreter button?(usually the grey color stands for `deactivated` I guess) https://cloud.githubusercontent.com/assets/10060731/18117095/6bd23a4e-6f87-11e6-94d5-d08abffb6561.png;> What do you think? :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 I just changed to 'icon'. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Great! Personally I would prefer "just icon" like the reload notes icon in Zeppelin home. But it's just my personal opinion. Final decision is up to you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Definitely looks better! I like @Leemoonsoo 's idea ð It's just my personal opinion, how about putting `refresh` icon to the left side of the interpreter name? I mean - Before https://cloud.githubusercontent.com/assets/10060731/18031438/96ca6208-6d1b-11e6-9022-109d7e6fe85c.png;> - After https://cloud.githubusercontent.com/assets/10060731/18031439/9d8905cc-6d1b-11e6-987a-ec9dd1f8a4e9.png;> And while we are familiar with the feature; "Restart Interpreter", some ppl may not. So what about showing some message with tooltip like this? https://cloud.githubusercontent.com/assets/10060731/18031452/6acf5a40-6d1c-11e6-912e-4c5af35e68ed.png;> What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 \cc @Leemoonsoo I fixed UI like following screenshot and process. please review.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 @Leemoonsoo Your suggestion about UI is definitely better! and also makes sense about restarting action on interpreter binding page. I will fix them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1302 And i think it's more make sense and useful if we can make restart button like, restart button on interpreter setting page : restart all interpreter instances/processes related to the setting. restart button on interpreter binding page : restart a interpreter instance/process for the note when "per Note" is enabled. Otherwise restart all interpreter instances/processes. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Thanks for the contribution. How about make UI little bit more consistent? On interpreter setting page, we have interpreter restart button look like  And interpreter binding page now have different style of restart button  How about use the similar style and similar icon for interpreter restart button? so user can easily guess what this button is for. For example,  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 Thank you very much about reviewing this PR. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim Oh that was my bad. Please ignore my above comment. I only build `zeppelin-web` not backend side. Tested again and it works well as expected. Let's wait the other reviewers :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1302 @astroshim I've also thought the interpreter `restart` button in separated page quite uncomfortable. This PR can be a good start for the better UX i think :) I tested your patch and it almost works well except one thing. >can only restart `scoped` and `isolated` interpreter. Since you said like above in the description, I edited `Spark` interpreter as `shared` mode in the interpreter menu and restarted with your new interpreter binding UI. I expected it failed with some error messages, but it restarted. Did I miss sth? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1302 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
