[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1426 @zjffdu and @prabhjyotsingh the new static Maps can these be converted to ConcurrentHashMaps's to prevent possible future contention with multiple users/threads. https://dzone.com/articles/java-7-hashmap-vs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Also, can you update the doc as well. Rest LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1426 LGTM except for one question --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1426 @prabhjyotsingh @felixcheung @Leemoonsoo I just update the PR to add a flag to display appInfo. By default it is false. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1426 @felixcheung DataFrame won't be affected, as it is handled in %livy.sql (`LivySparkSQLInterpreter`). And since `ZeppelinContext` is not available in livy, so you can not user `z.show(df)` in livy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1426 I think the problem is if the output is a DataFrame now it can't be turned into a table since %angular is already there because only the first type is picked up? That would seem to me a bigger problem. Also, while I think it's important to support multiple output types, for interpreter output customization like this it might be an opportunity to create a new framework to allow this to plug in to the paragraph "gear" menu or similar UX decorators? This could be a great opportunity to add Spark UI web link to the Spark interpreter group too. I agree with @zjffdu that this is important to have in the short term, and I think it's a good idea if we change the output type if only under the switch for Livy interpreter only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1426 Thanks for the info, I agree that the long term solution would be using [ support multiple interpreter result](https://issues.apache.org/jira/browse/ZEPPELIN-212). But for livy interpreter, it is very hard to figure out which spark app each session represent. And I think multiple user environment is common for livy users so additional info would be very helpful for livy users. So how about adding a new option to livy interpreter for this feature and by default it is turned off ? When [ support multiple interpreter result](https://issues.apache.org/jira/browse/ZEPPELIN-212) is implemented, we can turn the feature on by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1426 Add @felixcheung for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1426 I think displaying result with additional information is quick and simple approach. However, i think there're some downsides like - can not leverage output streaming - when user output want to use different zeppelin display system, like %table, %html, etc, it may be conflict with the feature this PR trying to provide. I think better approach would be [support multiple interpreter result]( https://issues.apache.org/jira/browse/ZEPPELIN-212) and display additional informations as a one of separate interpreter result with it's own result type. Although it'll going to be very large work, i think resolving ZEPPELIN-212 and build this feature on top of it, is right approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Here is before and after of this PR that I observe, and I see these 2 changes - now it does not stream output, i.e. it waits for the entire paragraph execution to be finished, and returns result. - and I see empty line between "1" and "2" where I wrote "Thread.sleep()", not a big deal, but it wasn't earlier. Before:  After:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
