[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath If you have trouble merging, tell me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/1429 @corneadoug removed the redundant beforeEach b8b4f24 Will merge if there are no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath do you want to try and merge this ? [This](https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide) will help you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath Could you just rebase once more? I will make a final check after --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/1429 @felixcheung removed "Copy of" prefix. @AhyoungRyu fixed folder related issue. @corneadoug fixed sequence bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1429 Except for the folder issue that @AhyoungRyu reported, I found another bug where the number do not increment: * Make a clone * Go back to the original note * Make another clone, the number is still 1 even though 1 already exist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath Thanks for the improvement. It's better than just "Untitled Note #" . But regarding `Copy of`, I agree with @felixcheung. If an user tries to clone a notebook in `this/is`, then `is 1` note will be created under `Copy of this` folder. It's a bit awkward in my point of view. https://cloud.githubusercontent.com/assets/10060731/18780471/afe6815c-81b8-11e6-9233-da67412cc82f.png; width="400px"> So just numbering would be enough I guess. What do you think? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/1429 @felixcheung I think either we remove "Copy of" or make it localizable. Will wait comments from others before making the choice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1429 I think it might be easier if we don't prefix "Copy of"? We might need to localize or make this localizable at some point --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
