Github user vectorijk commented on the issue:
https://github.com/apache/zeppelin/pull/1530
@Leemoonsoo @bzz Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1530
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1530
Tested and Looks great to me!
Thanks @vectorijk for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vectorijk commented on the issue:
https://github.com/apache/zeppelin/pull/1530
cc @Leemoonsoo @jongyoul
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user vectorijk commented on the issue:
https://github.com/apache/zeppelin/pull/1530
@bzz I have updated and added unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user vectorijk commented on the issue:
https://github.com/apache/zeppelin/pull/1530
@bzz Thanks for the quick response! I will write and update some tests for
this to make sure the changes doesn't break things before.
---
If your project is set up for it, you can reply to this
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1530
Thank you for contributing!
How do you think, how hard would be to add some tests here, to make sure
the change does not break things?
---
If your project is set up for it, you can reply to
Github user vectorijk commented on the issue:
https://github.com/apache/zeppelin/pull/1530
cc @zjffdu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i