[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1539 Tested and LGTM. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 CI is green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 @1ambda Thank you for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1539 @astroshim It is more clear since we already use that notations in the interpreter tab :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 @1ambda I added `placeholder` message for `Entity`. Does it make sense?  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 @1ambda Thank you for the testing and great suggestion about the `Entity` name. Let me fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1539 Build Command: mvn clean package -DskipTests Build Commit: **bf61afd** fix testcase (2 days ago) [astroshim] Build & Runtime Java: 1.8.0_102 Tested Backends: Mysql 5.7, MariaDB 10.1, Postgres 9.6 In my case, This PR works well with multiple users login (opened chrome, firefox, safari..)  @astroshim IMO, We can give more information about how users should name `Entity` at the top of **Credential Page**. Quite confusing to me at first. For example, > Example Interpreter Names: `jdbc.mysql`, `jdbc.hive` https://cloud.githubusercontent.com/assets/4968473/20253604/4a5ca1e6-aa70-11e6-8291-04972c52bcba.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 @nathanscully I fixed that you issued. Could you review again? @Leemoonsoo What `Entity` name did you set? `Entity` should be set as `jdbc`.`InterpreterName`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 Thank you @Leemoonsoo and @nathanscully to review. Let me address issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1539 Tested this branch but somehow i couldn't make it work. - if i set 'default.user' and 'default.password', i can access the database. - Turn on authentication and remove 'default.user' and 'default.password' does not access database with login credential - Turn on authentication, remove 'default.user' and 'default.password' and add credential in credential page does not access data base with provided credential. I'm not sure if i did something wrong or not.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 CI is green now. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1539 @astroshim Could you rebase and see if CI becomes green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 rebuild CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 @khalidhuseynov Thank you for sharing your good idea about the dropdown list. It might gives convenience users. and I agree with @Leemoonsoo about define convention for `entity` name. Let me fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1539 it would be even better to let user chose interpreter from dropdown list of interpreters in place of `entity` field in credentials menu, what do you think @Leemoonsoo @astroshim ? Also need to rebase I guess --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1539 There's also an option of adding that Entity key in interpreter settings via GUI (say `credetials.key` -> `entity`) and then using that `entity` when searching through credentials --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 @Leemoonsoo Thank you for review this. I was curious about the `Entity` name should be same with interpreter's. Could you tell me your idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1539 @astroshim Thanks for the contribution. Proposed jdbc interpreter update looks like searching Entity name, the same name with interpreter alias. I can think some possible problem here. For example Let's say an interpreter X read Entity name 'orange'. And a jdbc interpreter setting is created with alias 'orange'. Then both interpreter X and jdbc interpreter reads the same Entity 'orange', but they might expect different credentials. So i think we need introduce some convention for Entity name. Something like `jdbc.[alias]`. so user can create Entity like 'jdbc.orange', 'interpreterx.orange' Also, i think following docs need to be updated. https://github.com/apache/zeppelin/blob/master/docs/security/datasource_authorization.md https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1539 please review @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
